Re: Javascript code coverage ?

2014-06-17 Thread Philipp Kewisch
On 6/17/14 4:28 AM, Joshua Cranmer 🐧 wrote: > I tried once again when the debugger API was added, but that again > didn't work for some reason (I've forgotten why long ago... probably > something to do with insufficiently exposing interesting globals?). Oh, one more thing, there are a few bugs rel

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
The gaia-icons font currently uses ligatures to place icons, see here . The ligature character sequence is derived from the original filename of the SVG source file in `images/`. Is this what you were referring to? W. - Original Message - From: "Jet Villegas" To: "Wilson Page"

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
I'm inlining to minimise cross-origin issues and to reduce requests. The entire asset is <12k so I'm really not concerned with performance here, especially considering the number of PNG assets this replaces. We've been using a similar approach in Camera for quite some time and all has been well.

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
Maybe I'm late to the party, but I don't know what the PUA issue is? I suggest we offer gaia-icons repo that's an easy/ready-to-go package. If app owners wish to refine the icon-font to just the glyphs they need (to trim off a few kb) then they could run their own grunt-webfont script using a s

Re: Icon fonts in FxOS

2014-06-17 Thread Anne van Kesteren
On Tue, Jun 17, 2014 at 1:19 PM, Wilson Page wrote: > Maybe I'm late to the party, but I don't know what the PUA issue is? Code points carry semantics. If you assign meaning to unassigned code points through fonts, you have created a portability problem. That is, the font is required to make sens

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
If we are using ligatures in our apps, this isn't a problem. If someone wants to remove PUA glyphs, great! But this has no reason to block. - Original Message - From: "Anne van Kesteren" To: "Wilson Page" Cc: "Jonathan Kew" , "Patryk Adamczyk" , "John Daggett" , "b2g-internal" , "

Re: OMTC on Windows

2014-06-17 Thread avihal
On Friday, May 30, 2014 5:14:20 AM UTC+3, avi...@gmail.com wrote: > So, wrt TART, I now took the time to carefully examine tab animation visually > on one system. > > > > TL;DR: > > - I think OMTC introduces a clearly visible regression with tab animation > compared to without OMTC. > > - I

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
grunt-webfont is where the magic lives :) - Original Message - From: "Jonathan Kew" To: "Wilson Page" , "Anne van Kesteren" Cc: "Patryk Adamczyk" , "John Daggett" , "b2g-internal" , "L. David Baron" , "Jaime Chen" , "Jonathan Watt" , "Jet Villegas" , "Cameron McCormack" , "Vivie

Re: Icon fonts in FxOS

2014-06-17 Thread Jonathan Kew
On 17/6/14 13:17, Wilson Page wrote: If we are using ligatures in our apps, this isn't a problem. If someone wants to remove PUA glyphs, great! But this has no reason to block. Right, if we're embedding the font in our apps rather than installing it in the OS, then the PUA codepoints it inclu

Re: Icon fonts in FxOS

2014-06-17 Thread Jonathan Kew
On 17/6/14 11:52, Wilson Page wrote: I'm inlining to minimise cross-origin issues and to reduce requests. The entire asset is <12k so I'm really not concerned with performance here, especially considering the number of PNG assets this replaces. We've been using a similar approach in Camera for

Re: Icon fonts in FxOS

2014-06-17 Thread Jonathan Kew
On 17/6/14 11:10, Wilson Page wrote: The gaia-icons font currently uses ligatures to place icons, see here . The ligature character sequence is derived from the original filename of the SVG source file in `images/`. Is t

New bugzilla component: "Core: DOM: Content Processes"

2014-06-17 Thread Benjamin Smedberg
There is a new bugzilla component specifically to track issues with content processes. Core: DOM: Content Processes. This is intended to separate core-IPC bugs from content-process bugs in bugzilla, because they have different owners. Bugs in the core IPC layer and IPDL should continue to be

New crash signatures for out-of-memory crashes: "OOM | ..."

2014-06-17 Thread Benjamin Smedberg
Starting yesterday, you will see new crash signatures for out-of-memory crashes in crash-stats. The changes were implemented in bug 1007530, but here's the summary: OOM crashes are divided into three groups: known-small, known-large, and unknown-size. The known-small crashes will all have a

API propose to public place.

2014-06-17 Thread luoyonggang
At the current time, there is four function can not be accessed outside but required. LossyCopyUTF16toASCII(const char16_t* aSource, nsACString& aDest) LossyAppendUTF16toASCII(nsDependentString(aSource), aDest); CopyASCIItoUTF16(const char* aSource, nsAString& aDest) AppendASCIIt

connections to external hosts during tests now cause crashes

2014-06-17 Thread Nathan Froyd
[bcc dev-tree-management] In the continuing effort to make our testsuites more reliable, bug 995417 has landed on inbound. This bug enforces the long-standing policy of no external network connections in the testsuite with code: external network connections will now crash the browser if and wh

Re: API propose to public place.

2014-06-17 Thread Benjamin Smedberg
On 6/17/2014 10:58 AM, luoyongg...@gmail.com wrote: At the current time, there is four function can not be accessed outside but required. You may file a bug and attach a patch for these if you wish. I presume the code you pasted below would go in nsStringAPI.h but all patches and reviews ar

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
Following the grunt-webfont readme everything seemed to 'just work' for me (OSX). - Original Message - From: "Jonathan Kew" To: "Wilson Page" Cc: "Anne van Kesteren" , "Patryk Adamczyk" , "John Daggett" , "b2g-internal" , "L. David Baron" , "Jaime Chen" , "Jonathan Watt" , "Jet V

Re: Icon fonts in FxOS

2014-06-17 Thread Anthony Ricaud
On 16/06/14 21:34, Jet Villegas wrote: 1. Let people use the icon fonts anywhere. (ie. like "MS WingDings" can be used for this purpose) 2. The patch in bug 1008458 introduces "private" fonts that use the Unicode Private Use Area (PUA) for icon glyphs. 3. Use PUA characters as per bug 1008458 b

Re: Icon fonts in FxOS

2014-06-17 Thread Vivien Nicolas
Just want to make sure that there is no misunderstanding here: based on the data from https://bugzilla.mozilla.org/show_bug.cgi?id=948856#c37, some experience with loading icon fonts versus images versus svg that has been described on dev-gaia, *preloading the font is needed*. On 06/17/2014 12

Re: Icon fonts in FxOS

2014-06-17 Thread Vivien Nicolas
On 06/16/2014 09:34 PM, Jet Villegas wrote: Hi All: We need a path forward on the deployment of Icon fonts in FxOS. The Gaia team understandably wants to squeeze every bit of performance on their apps in v1.4: https://bugzilla.mozilla.org/show_bug.cgi?id=951593 We are concerned about leaking

Re: Icon fonts in FxOS

2014-06-17 Thread Wilson Page
Just to clarify: I am in favor of icon-fonts, but less baking them into the system. Do we have perf figures comparing normal @font-face loading (external or inlined) compared to the baked in solution? - Original Message - From: "Vivien Nicolas" To: "Wilson Page" , "Jonathan Kew" Cc

Re: Icon fonts in FxOS

2014-06-17 Thread Vivien Nicolas
On 06/17/2014 06:01 PM, Wilson Page wrote: Just to clarify: I am in favor of icon-fonts, but less baking them into the system. Do we have perf figures comparing normal @font-face loading (external or inlined) compared to the baked in solution? Yeah, looked at comment 37 of bug 948856. Between

Re: Icon fonts in FxOS

2014-06-17 Thread Jonathan Kew
On 17/6/14 14:31, Wilson Page wrote: grunt-webfont is where the magic lives :) Hmm. Magic indeed. Omitting the unwanted PUA codepoints would probably be a pretty minor tweak to the fontforge script there. But a brief attempt to get this up and runn

Re: Icon fonts in FxOS

2014-06-17 Thread Jonathan Kew
On 17/6/14 17:02, Vivien Nicolas wrote: On 06/17/2014 06:01 PM, Wilson Page wrote: Just to clarify: I am in favor of icon-fonts, but less baking them into the system. Do we have perf figures comparing normal @font-face loading (external or inlined) compared to the baked in solution? Yeah, lo

Re: Icon fonts in FxOS

2014-06-17 Thread Vivien Nicolas
On 06/17/2014 06:51 PM, Jonathan Kew wrote: On 17/6/14 17:02, Vivien Nicolas wrote: On 06/17/2014 06:01 PM, Wilson Page wrote: Just to clarify: I am in favor of icon-fonts, but less baking them into the system. Do we have perf figures comparing normal @font-face loading (external or inlined)

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Kent James
On 6/17/2014 8:01 AM, Nathan Froyd wrote: - For xpcshell, you should set up mock servers via httpd.js (see numerous examples in existing xpcshell tests). I use xpcshell to drive tests for an extension that attaches to external servers. This is all done by me and not part of any official Mozil

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Philipp Kewisch
On 6/17/14 7:58 PM, Kent James wrote: > On 6/17/2014 8:01 AM, Nathan Froyd wrote: >> - For xpcshell, you should set up mock servers via httpd.js (see >> numerous examples in existing xpcshell tests). > > I use xpcshell to drive tests for an extension that attaches to external > servers. This is al

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Ryan VanderMeulen
On 6/17/2014 2:22 PM, Philipp Kewisch wrote: Hey Kent, reading bug 995417, the crash only happens if MOZ_DISABLE_NONLOCAL_CONNECTIONS is set, which is set only in the testing infrastructure. Philipp Which is actually not ideal because it means we can end up with failures on TBPL that aren't

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Nathan Froyd
- Original Message - > On 6/17/2014 2:22 PM, Philipp Kewisch wrote: > > Hey Kent, > > > > reading bug 995417, the crash only happens if > > MOZ_DISABLE_NONLOCAL_CONNECTIONS is set, which is set only in the > > testing infrastructure. > > Which is actually not ideal because it means we can

Query

2014-06-17 Thread nivesh . naramsetti
Hi Boris.I have an issue with my addon.In Firefox F29,after debugging my add-on i found the error message as 'ERROR: Attempt to use .WrappedJSObject in untrusted code.Is it because of some security changes made in FF29 so that untrusted object cannot be accessed? Could you please help me out wit

Re: Query

2014-06-17 Thread Bobby Holley
See my response here: http://stackoverflow.com/a/23838442/3670407 On Tue, Jun 17, 2014 at 12:23 PM, wrote: > Hi Boris.I have an issue with my addon.In Firefox F29,after debugging my > add-on i found the error message as 'ERROR: Attempt to use .WrappedJSObject > in untrusted code.Is it because o

Re: Icon fonts in FxOS

2014-06-17 Thread James Burke
On 6/17/14, 10:08 AM, Vivien Nicolas wrote: That's true. Actually there are many other hacks that depends on the fact that application are certified. So even if I would like to have more apps as privileged apps just for the principle, it's not that simple. And we may need to reconsider the |pri

Re: Icon fonts in FxOS

2014-06-17 Thread Robert O'Callahan
On Wed, Jun 18, 2014 at 4:51 AM, Jonathan Kew wrote: > If I'm reading bug 948856 correctly, the difference may have been somewhat > less (150ms? comment 17) when the font was inlined in the CSS using a data > URI, rather than loaded from a separate file > > If we can't afford that, then we still

Is it time for mochitest-chrome on Android and B2G

2014-06-17 Thread Jonathan Griffin
Periodically, we field a request to add support for mochitest-chrome to Android and B2G. To date, we've avoided this by pointing out ways that mochitest-plain can be used for the same use case, which usually involves SpecialPowers. We have a new request for this, in the context of requestAuto

Re: Is it time for mochitest-chrome on Android and B2G

2014-06-17 Thread Bobby Holley
I can't comment on the importance of the a-team's other priorities, or the importance of running the tests in consideration on Android/B2G. However, as the author of SpecialPowers.wrap, I can say that using it for highly-involved chrome interaction should be considered Extremely Harmful. These wra

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Nicholas Nethercote
On Tue, Jun 17, 2014 at 8:01 AM, Nathan Froyd wrote: > > In the continuing effort to make our testsuites more reliable, bug 995417 has > landed on inbound. This bug enforces the long-standing policy of no external > network connections in the testsuite with code: external network connections >