Until today Gecko's support for string constants was quite poor. You
could create a literal string or a named literal string on the stack and
pass it to a method but any operation on the string ended up copying the
string. In effect a literal string was a dependent string whose length
was known
I think the "Target Milestone" field is poorly named, at least with
respect to what we use it for. In practice this field is set to the
version of m-c on which the patches originally landed, and doesn't
change when patches are uplifted to other branches.
However, I've seen many people mistake
if the goal of the styles is the readability, do we know that people actually
care which one of the described approaches we use, or is it also the "look, not
all of these things are the same" that offends us?
For example, I find the consistency of the positioning of {} for the loops and
conditi
On 2014-01-09, at 08:48, Milan Sreckovic wrote:
> For example, I find the consistency of the positioning of {} for the loops
> and conditionals extremely important for readability.
Outside of any real extremes, I’ve found that consistency is far more important
than any personal preferences.
(It's probably a good idea scope this discussion to common practice in
the "Firefox" components i.e. Core/Firefox/Toolkit/etc. Bugzilla
discussions like this one can get into the weeds pretty quickly when
people bring up other projects who use our Bugzilla installation and
who have different practi
On 1/9/14, 7:17 AM, Kartikaya Gupta wrote:
I think the "Target Milestone" field is poorly named, at least with
respect to what we use it for. In practice this field is set to the
version of m-c on which the patches originally landed, and doesn't
change when patches are uplifted to other branches.
On Thu, Jan 9, 2014 at 9:53 AM, Chris Peterson wrote:
> On 1/9/14, 7:17 AM, Kartikaya Gupta wrote:
>
>> I think the "Target Milestone" field is poorly named, at least with
>> respect to what we use it for. In practice this field is set to the
>> version of m-c on which the patches originally lande
On 1/9/14 9:53 AM, Chris Peterson wrote:
On 1/9/14, 7:17 AM, Kartikaya Gupta wrote:
I think the "Target Milestone" field is poorly named, at least with
respect to what we use it for. In practice this field is set to the
version of m-c on which the patches originally landed, and doesn't
change wh
On 1/7/2014, 3:46 PM, Mike Hoye wrote:
2 v. 4 spaces: more on that shortly.
An update on the research: Earlier, I said "four spaces" flat out, based
on some conversations with researchers, but since then all the research
I've been able to track down seems to cite the same paper. That paper
On 1/9/2014 12:53 PM, Chris Peterson wrote:
What is the use case for "Target Milestone" (in the "Patches Landed In"
sense)? As you point out, the Target Milestone is not updated if a fix
is uplifted, so Target Milestone does not even represent the first Gecko
release that contains the fix. That i
On 1/9/2014, 11:48 AM, Milan Sreckovic wrote:
if the goal of the styles is the readability, do we know that people actually care which
one of the described approaches we use, or is it also the "look, not all of these
things are the same" that offends us?
For example, I find the consistency of
I'm sure there are other use cases, but the most common one for me is
using it to sort out tracking flags for regressions and otherwise
complicated dependency trees.
Gavin
On Thu, Jan 9, 2014 at 9:53 AM, Chris Peterson wrote:
> On 1/9/14, 7:17 AM, Kartikaya Gupta wrote:
>>
>> I think the "Target
On Thu, Jan 9, 2014 at 3:33 AM, Neil wrote:
>
> Bug 514173 has landed, which makes use of the fact that code living in
> libxul can reasonably assume that string constants have infinite lifetime,
> meaning that any literal strings in libxul are shared rather than copied.
Cool! Have you done any m
On 01/09/2014 03:33 AM, Neil wrote:
> This does not apply to AssignLiteral on an nsString, since that used to
> take a char (&)[] parameter. Instead, consider assigning an
> NS_LITERAL_STRING, or you can also use the new char16_t overload of
> AssignLiteral by wrapping your string constant in MOZ_U
14 matches
Mail list logo
