Re: Changes to JS components/JSMs

2012-11-01 Thread Kyle Huey
On Tue, Oct 30, 2012 at 8:02 PM, Blair McBride wrote: > Does this break the usage of the BackstagePass object? (the thing that > Cu.import() returns). > Not if the pref isn't set. If the pref is set I suspect it still returns an object with the relevant properties, but that object is no longer

Re: Changes to JS components/JSMs

2012-11-01 Thread Gavin Sharp
On Thu, Nov 1, 2012 at 10:00 AM, Kyle Huey wrote: > Not if the pref isn't set. If the pref is set I suspect it still returns > an object with the relevant properties, but that object is no longer a > BackstagePass. I haven't verified that though. Will that break http://mxr.mozilla.org/mozilla-c

Re: Proposal for reorganizing test directories

2012-11-01 Thread Dave Mandelin
At the last Tuesday meeting I foolishly agreed :-) to take charge of following up on this discussion and seeing if we can come to a decision. So, here goes: First, I want to try to pour some gasoline on the dying embers and suggest that perhaps we should totally rearrange everything. As a develo

PGO: another test + PGO topcrashes

2012-11-01 Thread Dave Mandelin
I'm still thinking about PGO: 1. I did another test. I wanted to know the effect on games, so I played BananaBread and eyeballed modal fps. (If anyone knows of a more accurate way to measure fps in the game, let me know.) I got: opt 38 pgo 41 Similar magnitude to other domains. Super-unsci

Re: Proposal for reorganizing test directories

2012-11-01 Thread therealbrendaneich
On Thursday, November 1, 2012 5:47:57 PM UTC-7, Dave Mandelin wrote: > At the last Tuesday meeting I foolishly agreed :-) to take charge of > following up on this discussion and seeing if we can come to a decision. So, > here goes: ... > I would prefer something like this: > > > |-- tests/ > >

Re: PGO: another test + PGO topcrashes

2012-11-01 Thread Robert O'Callahan
On Fri, Nov 2, 2012 at 2:19 PM, Dave Mandelin wrote: > (b) Failing that, how about not fixing PGO bugs unless they are > reproducible, on a trial basis? If my lifecycle theory is correct, then the > total crash rate would stay roughly constant. And I assume that if the > crash rate doesn't actua

Re: PGO: another test + PGO topcrashes

2012-11-01 Thread Ehsan Akhgari
On 2012-11-01 9:19 PM, Dave Mandelin wrote: (a) How about building Windows with a newer version of MSVC, say 2012? (What version are we using now, anyway? The build instructions page says 2010 is official, but a tbpl log showed Visual Studio 9.0 on the path.) Maybe they have fixed bugs in PG

Re: Proposal for reorganizing test directories

2012-11-01 Thread Dave Mandelin
On Thursday, November 1, 2012 6:33:39 PM UTC-7, therealbr...@gmail.com wrote: > On Thursday, November 1, 2012 5:47:57 PM UTC-7, Dave Mandelin wrote: > > > At the last Tuesday meeting I foolishly agreed :-) to take charge of > > following up on this discussion and seeing if we can come to a decisi

Re: Proposal for reorganizing test directories

2012-11-01 Thread Robert O'Callahan
On Fri, Nov 2, 2012 at 2:53 PM, Dave Mandelin wrote: > Sure, it's not some grand thing. I just like things to be nicely > organized. And I really did find mochitest paths a hassle and a (small) tax > on development effort. > You could keep tests near the code and still have a predictable algorit

Re: Proposal for reorganizing test directories

2012-11-01 Thread Nicholas Nethercote
On Thu, Nov 1, 2012 at 6:33 PM, wrote: > > The tyranny of hierarchy never ends. Either we have subsidiarity for js and > other modules, or not. If "Gecko" is one big module -- ok, I get it. But you > need a principle for giving js its own tests while hoisting all others. "Every component that