Re: nasm will soon become a build dependency

2019-01-18 Thread Thomas Daede
On 1/18/19 11:20 AM, Kartikaya Gupta wrote: > Any update here? Is there a bug on file for making bootstrap install a > usable nasm? I just made one: https://bugzilla.mozilla.org/show_bug.cgi?id=1521186 It has two deps, on making the actual toolchain scripts. _

Re: nasm will soon become a build dependency

2019-01-18 Thread Kartikaya Gupta
Any update here? Is there a bug on file for making bootstrap install a usable nasm? On Fri, Dec 28, 2018 at 3:28 PM Andi-Bogdan Postelnicu wrote: > > I can confirm that we are having the same problem on Debian stretch and > before manually building nasm we had to disable av1 in order to be able

Re: nasm will soon become a build dependency

2019-01-07 Thread Thomas Daede
On 12/21/18 3:09 PM, Mike Hommey wrote: > On Fri, Dec 21, 2018 at 04:21:03PM -0500, Kartikaya Gupta wrote: >> I would certainly prefer this, and having this work smoothly would >> also be good for new contributors. Having to build and install extra >> packages is always a hassle. > > It's a hassle

Re: nasm will soon become a build dependency

2018-12-28 Thread Andi-Bogdan Postelnicu
I can confirm that we are having the same problem on Debian stretch and before manually building nasm we had to disable av1 in order to be able to move further with the static analysis builds for coverity. > On 28 Dec 2018, at 22:19, Botond Ballo wrote: > >> On Fri, Dec 21, 2018 at 4:21 PM Kar

Re: nasm will soon become a build dependency

2018-12-28 Thread Botond Ballo
On Fri, Dec 21, 2018 at 4:21 PM Kartikaya Gupta wrote: > > On Fri, Dec 21, 2018 at 4:10 PM Thomas Daede wrote: > > There is a toolchain build for nasm for windows: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1511224 > > > > If getting a newer nasm version is inconvenient for a majority of li

Re: nasm will soon become a build dependency

2018-12-21 Thread Thomas Daede
On 12/21/18 3:09 PM, Mike Hommey wrote: > On Fri, Dec 21, 2018 at 04:21:03PM -0500, Kartikaya Gupta wrote: >> I would certainly prefer this, and having this work smoothly would >> also be good for new contributors. Having to build and install extra >> packages is always a hassle. > > It's a hassle

Re: nasm will soon become a build dependency

2018-12-21 Thread Mike Hommey
On Fri, Dec 21, 2018 at 04:21:03PM -0500, Kartikaya Gupta wrote: > On Fri, Dec 21, 2018 at 4:10 PM Thomas Daede wrote: > > There is a toolchain build for nasm for windows: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1511224 > > > > If getting a newer nasm version is inconvenient for a majorit

Re: nasm will soon become a build dependency

2018-12-21 Thread Kartikaya Gupta
On Fri, Dec 21, 2018 at 4:10 PM Thomas Daede wrote: > There is a toolchain build for nasm for windows: > https://bugzilla.mozilla.org/show_bug.cgi?id=1511224 > > If getting a newer nasm version is inconvenient for a majority of linux > users, the toolchain build could be used to produce nasm binar

Re: nasm will soon become a build dependency

2018-12-21 Thread Thomas Daede
On 12/21/18 8:08 AM, Kartikaya Gupta wrote: > Looks like the default nasm in the Ubuntu 16.04 repositories is 2.11. > Are there plans to make `./mach bootstrap` find a 2.13 version from > somewhere, instead of just installing via `apt-get` and assuming it's > the right version? There is a toolchai

Re: nasm will soon become a build dependency

2018-12-21 Thread Kartikaya Gupta
Looks like the default nasm in the Ubuntu 16.04 repositories is 2.11. Are there plans to make `./mach bootstrap` find a 2.13 version from somewhere, instead of just installing via `apt-get` and assuming it's the right version? On Fri, Dec 21, 2018 at 12:00 AM Thomas Daede wrote: > > On 12/20/18

Re: nasm will soon become a build dependency

2018-12-20 Thread Thomas Daede
On 12/20/18 8:17 PM, Martin Thomson wrote: > The OP said >= 2.10. But you appear to have that. At the time of writing it was, but we now need 2.13. The configure script doesn't check for that either, I will make a note of it in the bug to fix this detection. _

Re: nasm will soon become a build dependency

2018-12-20 Thread Cameron McCormack
On Fri, Dec 21, 2018, at 3:17 PM, Martin Thomson wrote: > The OP said >= 2.10. But you appear to have that. Oh, missed that. I just tried building some other versions of nasm from source (since 2.11 is the latest packaged in my distribution) and 2.13 was the earliest that I could build with. _

Re: nasm will soon become a build dependency

2018-12-20 Thread Martin Thomson
On Fri, Dec 21, 2018 at 3:01 PM Cameron McCormack wrote: > On Fri, Dec 21, 2018, at 11:05 AM, Thomas Daede wrote: > > nasm is now required for building on Linux. > > Is there a minimum version required? I am getting errors like this > building: > The OP said >= 2.10. But you appear to have tha

Re: nasm will soon become a build dependency

2018-12-20 Thread Cameron McCormack
On Fri, Dec 21, 2018, at 11:05 AM, Thomas Daede wrote: > nasm is now required for building on Linux. Is there a minimum version required? I am getting errors like this building: /z/moz/g/third_party/dav1d/src/x86/ipred_ssse3.asm:42: error: operand 1: expression is not simple or relocatable $ n

Re: nasm will soon become a build dependency

2018-12-20 Thread Thomas Daede
nasm is now required for building on Linux. A configure check was missed, so if you are missing nasm, you will see this error: make[4]: *** No rule to make target '../../media/libdav1d/asm/config.o', needed by 'libxul.so'. Stop. This bug tracks adding the configure check: https://bugzilla.mozill

Re: nasm will soon become a build dependency

2018-11-27 Thread Thomas Daede
nasm is now preferred over yasm if it's detected at configure time. Note that compilation will currently fail if a very old nasm is installed. If this happens, either update nasm (such as via mach bootstrap), or remove it, and then rerun mach configure. Thomas On 10/26/18 12:57 PM, Thomas Daede

nasm will soon become a build dependency

2018-10-26 Thread Thomas Daede
Firefox is switching its AV1 implementation to dav1d, a new, multithreaded AV1 decoder. dav1d requires nasm >= 2.10, which means that it will become a build-time dependency of Firefox. mach bootstrap will automatically install nasm, and it is also available in most package managers. Building witho