Changes to already_AddRefed and getter_AddRefs

2014-03-15 Thread Kyle Huey
I have made changes to already_AddRefed (Bug 967364) and getter_AddRefs (Bug 345123) to eliminate some potential mistakes that can be made with them. For already_AddRefed: - already_AddRefed::get() has been renamed to already_AddRefed::take(), to make the transfer of ownership of the pointer in

Re: getter_AddRefs

2013-03-29 Thread Neil
Benjamin Smedberg wrote: On 3/26/2013 10:16 AM, Neil wrote: Why does getter_AddRefs have an operator nsISupports**? So far most of the uses I've found appear to be people enumerating an nsISimpleEnumerator directly into an nsCOMPtr type, although the documented idl return val

Re: getter_AddRefs

2013-03-26 Thread Benjamin Smedberg
On 3/26/2013 10:16 AM, Neil wrote: Why does getter_AddRefs have an operator nsISupports**? So far most of the uses I've found appear to be people enumerating an nsISimpleEnumerator directly into an nsCOMPtr type, although the documented idl return value is nsISupports. Is this an accep

getter_AddRefs

2013-03-26 Thread Neil
Why does getter_AddRefs have an operator nsISupports**? So far most of the uses I've found appear to be people enumerating an nsISimpleEnumerator directly into an nsCOMPtr type, although the documented idl return value is nsISupports. Is this an acceptable paradigm? -- Warning: May co