Re: Startup cache and resource:// urls

2015-11-24 Thread Nicolas B. Pierron
The concerns that I have is that the start-up cache proved to be useful in multiple experiments made by 3 different persons, and at different occasions and for different purposes: - Bug 813324 - Compiled JS cache for Firefox - Bug 1101386 - Missing bytecode cache causes SpiderMonkey to be 6x slow

Re: Startup cache and resource:// urls

2015-11-23 Thread Mike Hommey
On Mon, Nov 23, 2015 at 11:29:05PM -0800, Kris Maglione wrote: > On Tue, Nov 24, 2015 at 04:08:56PM +0900, Mike Hommey wrote: > >... which seems to be a *very* old thing because: > >- resource://app might have pointed to the plain Firefox directory where > > you could find the omnijar a long time a

Re: Startup cache and resource:// urls

2015-11-23 Thread Aaron Klotz
On 11/23/2015 10:22 PM, Mike Hommey wrote: Can the perf team look into this? Note the startup cache only matters on the first startup for a given build, and that might be a reason why we fail to track its performance impact. We can get rid of it if we properly encode JS source in the o

Re: Startup cache and resource:// urls

2015-11-23 Thread Kris Maglione
On Tue, Nov 24, 2015 at 04:08:56PM +0900, Mike Hommey wrote: ... which seems to be a *very* old thing because: - resource://app might have pointed to the plain Firefox directory where you could find the omnijar a long time ago (I don't remember if that ever was actually true), but it points *in

Re: Startup cache and resource:// urls

2015-11-23 Thread Mike Hommey
On Mon, Nov 23, 2015 at 10:26:39PM -0800, Kris Maglione wrote: > > Most code in Firefox itself fortunately uses resource:/// instead of > > resource://app/ (they have the same meaning, or at least were supposed > > to, since the bug broke this promise), so it was fortunately not a > > direct proble

Re: Startup cache and resource:// urls

2015-11-23 Thread Kris Maglione
On Tue, Nov 24, 2015 at 02:22:44PM +0900, Mike Hommey wrote: Note the startup cache only matters on the first startup for a given build, and that might be a reason why we fail to track its performance impact. Presumably also when we flush the startup cache for changes in add-ons? Most c

Startup cache and resource:// urls

2015-11-23 Thread Mike Hommey
Hi, I recently found out, while refactoring some parts of `make package`, that since Firefox 38, we've stopped shipping startup cache data for all the browser javascript modules and components. This turned out to be the consequence of resource://app/ having been overridden to point somewhere diffe