Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-04 Thread Mike Conley
Part of the way. The last bit is to de-duplicate all of the Profiler.js scripts in talos, and get them to use the asynchronous mechanisms for profile gathering and writing (since they're currently using dumpProfileToFile, which prevents us from getting out-of-process profiles). That'll be in bug 1

Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-04 Thread Benoit Girard
Thanks Mike for your hard work pushing this through! In theory it does let us profile e10s on TAlos, but I'm sure well will find more usability issues. It's unclear if they will be a blocker or not. If there's outstanding issues I don't think we know about them. Please file them and CC me on any i

Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-03 Thread Kartikaya Gupta
\o/ Does this get us all the way to "profile talos runs with e10s enabled", or are there still pieces missing for that? IIRC this set of patches was a prerequisite for being able to do that. On Thu, Dec 3, 2015 at 4:52 PM, Mike Conley wrote: > Just a heads up that there have been recent developm

SPS Profiles are now captured for entire subprocess lifetime

2015-12-03 Thread Mike Conley
Just a heads up that there have been recent developments with regards to gathering SPS profiles from multiple processes. Bug 1103094[1] recently landed in mozilla-central, which makes it so that if a subprocess starts up _after_ profiling has already been started in the parent, then the subprocess