Re: Requiring a try job prior to autolanding to inbound

2016-01-28 Thread Jed Davis
Adam Roach writes: > My understanding is that the autolander is available only to > developers with Level 3 access, right? Given that this is the same > group of people who can do a manual check-in, I don't see why we would > make autolanding have to clear a higher bar than manual landing. We co

Re: Requiring a try job prior to autolanding to inbound

2016-01-22 Thread Mark Finkle
On Fri, Jan 22, 2016 at 9:50 AM, Adam Roach wrote: > On 1/22/16 06:12, Daniel Minor wrote: > >> Another difference is that sheriffs require a try run before they will >> land >> a patch flagged "checkin-needed." In Bug 1239281 we're proposing to >> implement this requirement for autolanding. >> >

Re: Requiring a try job prior to autolanding to inbound

2016-01-22 Thread Adam Roach
On 1/22/16 06:12, Daniel Minor wrote: Another difference is that sheriffs require a try run before they will land a patch flagged "checkin-needed." In Bug 1239281 we're proposing to implement this requirement for autolanding. I'm always wary of using tools to enforce policy, since you frequentl

Re: Requiring a try job prior to autolanding to inbound

2016-01-22 Thread Daniel Minor
On Fri, Jan 22, 2016 at 8:00 AM, Andreas Tolfsen wrote: > Overall I think this idea makes sense. Is it your intention that the > try run should be 100% complete, or just that one exists and is > associated with the review? In some cases I find myself invoking > Autoland when I feel reasonably c

Re: Requiring a try job prior to autolanding to inbound

2016-01-22 Thread Andreas Tolfsen
Overall I think this idea makes sense. Is it your intention that the try run should be 100% complete, or just that one exists and is associated with the review? In some cases I find myself invoking Autoland when I feel reasonably confident about the results. On 22 January 2016 at 12:12, Daniel M

Requiring a try job prior to autolanding to inbound

2016-01-22 Thread Daniel Minor
One of our goals for autoland is to replace the "checkin-needed" process that is currently done manually by the sheriffs. We still have a few bugs to fix before this is ready, for instance, approval for autolanding is not carried forward for some users if they amend their patch. Another difference