Re: Clang static analysis [was Re: Reminder: NSPR synchronization primitives are not to be used]

2013-03-08 Thread Ehsan Akhgari
On 2013-03-06 12:34 PM, Joshua Cranmer 🐧 wrote: On 3/6/2013 11:26 AM, Gregory Szorc wrote: On 3/6/13 9:07 AM, Kyle Huey wrote: Gecko reviewers should be enforcing this. Static analysis should be helping to enforce this (and numerous other conventions). Bugs 733873 and 767563 (possibly dupes)

Re: Clang static analysis [was Re: Reminder: NSPR synchronization primitives are not to be used]

2013-03-06 Thread Steve Fink
On Wed 06 Mar 2013 09:34:28 AM PST, Joshua Cranmer 🐧 wrote: > On 3/6/2013 11:26 AM, Gregory Szorc wrote: >> >> Bugs 733873 and 767563 (possibly dupes) are open to track >> implementing a Clang plugin to perform analysis of our source and >> builds. All we need is a hero or two to get an initial ver

Clang static analysis [was Re: Reminder: NSPR synchronization primitives are not to be used]

2013-03-06 Thread Joshua Cranmer 🐧
On 3/6/2013 11:26 AM, Gregory Szorc wrote: On 3/6/13 9:07 AM, Kyle Huey wrote: Gecko reviewers should be enforcing this. Static analysis should be helping to enforce this (and numerous other conventions). Bugs 733873 and 767563 (possibly dupes) are open to track implementing a Clang plugin

Re: Reminder: NSPR synchronization primitives are not to be used

2013-03-06 Thread Gregory Szorc
On 3/6/13 9:07 AM, Kyle Huey wrote: Gecko reviewers should be enforcing this. Static analysis should be helping to enforce this (and numerous other conventions). Bugs 733873 and 767563 (possibly dupes) are open to track implementing a Clang plugin to perform analysis of our source and build

Reminder: NSPR synchronization primitives are not to be used

2013-03-06 Thread Kyle Huey
This is a friendly reminder that you should not be using NSPR synchronization primitives in new Gecko code unless you have a very good reason to. We built all these nice wrappers on them that provide deadlock checking, RAII, leak checking, etc. that you should use instead. Instead of PRLock - use