Re: nsAutoConfig

2017-11-01 Thread Mike Kaply
I didn't write the test, so I honestly don't know. I'll try to make time to take a look. Mike On Wed, Nov 1, 2017 at 12:04 PM, wrote: > Hey Mike, > according to our code coverage report, nsAutoConfig is never executed > during tests. > > As far as I can see, it is actually not tested, as the te

Re: nsAutoConfig

2017-11-01 Thread mcastelluccio
Hey Mike, according to our code coverage report, nsAutoConfig is never executed during tests. As far as I can see, it is actually not tested, as the test you mentioned is not setting the autoadmin.global_config_url pref that would make nsReadConfig instantiate nsAutoConfig. Is that correct? I'

Re: nsAutoConfig

2017-10-31 Thread Nicholas Nethercote
Thank you for the info! I will leave that code alone :) Nick On Wed, Nov 1, 2017 at 2:22 AM, wrote: > On Tuesday, October 31, 2017 at 12:10:21 AM UTC-5, Nicholas Nethercote > wrote: > > Hi, > > > > I was just looking at the extensions/pref/autoconfig/ directory and > trying > > to understand wh

Re: nsAutoConfig

2017-10-31 Thread mkaply
On Tuesday, October 31, 2017 at 12:10:21 AM UTC-5, Nicholas Nethercote wrote: > Hi, > > I was just looking at the extensions/pref/autoconfig/ directory and trying > to understand what it does. > > As far as I can tell, the code is there to allow custom deployments with > particular prefs set, as

Re: Re: nsAutoConfig

2017-10-31 Thread Marco Castelluccio
Are you sure the test you wrote is testing nsAutoConfig and not nsReadConfig? nsReadConfig does not instantiate nsAutoConfig unless autoadmin.global_config_url exists and is not emtpy: https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/

Re: nsAutoConfig

2017-10-31 Thread Masatoshi Kimura
On 2017/10/31 19:22, Marco Castelluccio wrote: > It is not covered by any automated test: > https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/src/nsAutoConfig.cpp > (this doesn't mean it isn't actually used ever, but it can be a clue).

Re: nsAutoConfig

2017-10-31 Thread Marco Castelluccio
It is not covered by any automated test: https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/src/nsAutoConfig.cpp (this doesn't mean it isn't actually used ever, but it can be a clue). - Marco. Il 31/10/2017 05:09, Nicholas Nethercote h