Re: crash reporting, inline functions, and you

2019-04-07 Thread Nicholas Nethercote
I've done a lot of profiling of Rust code using tools that are based around stack traces. I can't emphasize how useful it is to have inlined stack frames. Here is a highly typical example from a profile I had lying around: #1: 0x655A213: alloc (alloc.rs:75) #2: 0x655A213: alloc (alloc.rs:151) #3:

Re: crash reporting, inline functions, and you

2019-04-05 Thread Kartikaya Gupta
Thank you for doing this work! Any additional information for inlined frames in crash stacks will be hugely helpful. On Fri, Apr 5, 2019 at 12:34 PM Nathan Froyd wrote: > > TL;DR: We're making some changes to how inlined functions are handled > in our crash reports on non-Windows platforms in bug

Re: crash reporting, inline functions, and you

2019-04-05 Thread Calixte Denizet
Awesome and super useful work. I really hope it'll help us to detect the guilty patches. Calixte Le ven. 5 avr. 2019 à 18:34, Nathan Froyd a écrit : > TL;DR: We're making some changes to how inlined functions are handled > in our crash reports on non-Windows platforms in bug 524410. This > cha

Re: crash reporting, inline functions, and you

2019-04-05 Thread Bobby Holley
This is awesome - thank you Nathan! On Fri, Apr 5, 2019 at 9:34 AM Nathan Froyd wrote: > TL;DR: We're making some changes to how inlined functions are handled > in our crash reports on non-Windows platforms in bug 524410. This > change should mostly result in more understandable crash stacks fo