On Fri, Jul 26, 2013 at 9:36 PM, Brad Lassey wrote:
> On 7/26/13 9:30 AM, Ehsan Akhgari wrote:
>
>> I've written up the review policy at [1] and filed bug 898089 [2] to
>>> enforce/communicate this policy via Mercurial hooks.
>>>
>>>
>> While I supported the review policy change here, I'm fairly
On 7/26/13 9:30 AM, Ehsan Akhgari wrote:
I've written up the review policy at [1] and filed bug 898089 [2] to
enforce/communicate this policy via Mercurial hooks.
While I supported the review policy change here, I'm fairly strongly
opposed to the idea of the commit hook enforcing it. I've com
On Thu, Jul 25, 2013 at 5:28 PM, Gregory Szorc wrote:
> It appears this proposal was generally well received and I guess that
> means it's time to officially enact it.
>
Thanks for starting this conversation and driving it through, Gregory!
> I've written up the review policy at [1] and filed
It appears this proposal was generally well received and I guess that
means it's time to officially enact it.
I've written up the review policy at [1] and filed bug 898089 [2] to
enforce/communicate this policy via Mercurial hooks.
If you experience excessive lag obtaining build peer review,
On 18/07/13 12:00, Gregory Szorc wrote:
> Since new Makefile.in badness makes people's lives harder (especially
> when it makes the build slower), I would like to propose a more strict
> policy around Makefile.in changes: *if a non-list change in a
> Makefile.in isn't reviewed by a build peer, it d
On 2013-07-18 10:49 AM, Joe Drew wrote:
I am 100% in favour of this. My only request is that build peers
implement something similar to Firefox's catch-all reviewer account,
because suggested reviewers won't work for most build changes (the bug
won't be filed in Core::Build Config). If I can ty
I am 100% in favour of this. My only request is that build peers
implement something similar to Firefox's catch-all reviewer account,
because suggested reviewers won't work for most build changes (the bug
won't be filed in Core::Build Config). If I can type :build-peer instead
of :gps, it'll ev
Sounds good to me! FWIW my experience in getting reviews over small-ish
build system changes (I've never made large changes!) has been quite
positive, the peers are usually very responsive and are sometimes even
happy to review patches right away if there is something urgent that
needs to land
On 07/18/2013 02:45 PM, Benjamin Smedberg wrote:
> On 7/18/2013 2:43 AM, Tim Taubert wrote:
>> The proposal sounds good to me but I guess you wouldn't want to be
>> notified of every small addition/change to Makefiles in test
>> directories? I suppose you're targeting actual changes to dependencies
On 7/18/2013 2:43 AM, Tim Taubert wrote:
The proposal sounds good to me but I guess you wouldn't want to be
notified of every small addition/change to Makefiles in test
directories? I suppose you're targeting actual changes to dependencies
etc, but where do we draw the line?
I thought the propos
The proposal sounds good to me but I guess you wouldn't want to be
notified of every small addition/change to Makefiles in test
directories? I suppose you're targeting actual changes to dependencies
etc, but where do we draw the line?
Can we maybe add a push hook intelligent enough to separate act
I'm probably responsible for those Fennec build files (if they were
correct, it would have been blassey).
In any case, we probably did 'sneak' things past build peers. Not
intentionally, of course.
We were more worried about getting a product into the marketplace that
didn't suck than the c
On 7/17/2013 5:24 PM, Justin Lebar wrote:
> The flip side of this, of course, is that build peers need to ensure
> that they are not the long pole in reviews. But I presume you guys
> are prepared to turn around these additional reviews quickly,
> otherwise you wouldn't have asked for the extra lo
The flip side of this, of course, is that build peers need to ensure
that they are not the long pole in reviews. But I presume you guys
are prepared to turn around these additional reviews quickly,
otherwise you wouldn't have asked for the extra load.
On Wed, Jul 17, 2013 at 5:00 PM, Gregory Szor
14 matches
Mail list logo
