Re: Editing vendored crates take #2

2017-05-02 Thread Boris Zbarsky
On 5/2/17 2:54 PM, Josh Matthews wrote: My cargo from April 19 claims that "cargo vendor" isn't a real command. Did you mean `./mach vendor rust` Er, yes, I did. -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozill

Re: Editing vendored crates take #2

2017-05-02 Thread Ted Mielczarek
On Tue, May 2, 2017, at 02:54 PM, Josh Matthews wrote: > On 2017-04-28 3:07 PM, Boris Zbarsky wrote: > > On 4/28/17 1:05 PM, Josh Matthews wrote: > > 2) Run "cargo vendor" and watch it fail because of something I never > > figured out. > > My cargo from April 19 claims that "cargo vendor" isn't a

Re: Editing vendored crates take #2

2017-05-02 Thread Josh Matthews
On 2017-04-28 3:07 PM, Boris Zbarsky wrote: On 4/28/17 1:05 PM, Josh Matthews wrote: 2) Run "cargo vendor" and watch it fail because of something I never figured out. My cargo from April 19 claims that "cargo vendor" isn't a real command. Did you mean `./mach vendor rust` (which did end up de

Re: Editing vendored crates take #2

2017-04-28 Thread Kartikaya Gupta
At one point the steps at https://wiki.mozilla.org/Platform/GFX/Quantum_Render#Testing_third-party_rust_library_changes were known to work. I don't know if they have since been broken. On Fri, Apr 28, 2017 at 3:07 PM, Boris Zbarsky wrote: > On 4/28/17 1:05 PM, Josh Matthews wrote: >> >> Has anybo

Re: Editing vendored crates take #2

2017-04-28 Thread Boris Zbarsky
On 4/28/17 1:05 PM, Josh Matthews wrote: Has anybody been able to make this work? I _think_ I made it work recently-ish, like so: 1) Modify toolkit/library/rust/Cargo.toml with the relevant [replace] bit. 2) Run "cargo vendor" and watch it fail because of something I never figured out. 3

Re: Editing vendored crates take #2

2017-04-28 Thread Josh Matthews
I just tried moving my changes into third_part/rust/rust-cssparser. I also needed to modify the Cargo.toml there to update the paths to cssparser-macros and procedural-masquerade because they are vendored as separate crates, rather than in-library dependencies. At this point I was still hitting

Re: Editing vendored crates take #2

2017-04-28 Thread Jack Moffitt
There is this bug which the Cargo team is planning to work on to help with these problems, but it hasn't been implemented yet that I know of. https://github.com/rust-lang/cargo/issues/2649#issuecomment-279615299 jack. On Fri, Apr 28, 2017 at 11:28 AM, Bobby Holley wrote: > I definitely made thi

Re: Editing vendored crates take #2

2017-04-28 Thread Bobby Holley
I definitely made this work at some point: https://hg.mozilla.org/try/rev/18dc070e0308 The main difference with what you seem to be doing is that my version points directly into third-party/rust, which I think is preferable anyway. On Fri, Apr 28, 2017 at 10:05 AM, Josh Matthews wrote: > Back i