Re: Proposal to remove the function timer code

2012-09-20 Thread Mike Hommey
On Thu, Sep 20, 2012 at 08:26:06PM -0400, Ehsan Akhgari wrote: > On 12-09-20 1:54 AM, Mike Hommey wrote: > >>The sample labels will not provide instrumenting profiling. What > >>happens is that the sample labels build up a stack, and every time > >>that we pause the target thread when taking a sam

Re: Proposal to remove the function timer code

2012-09-20 Thread Ehsan Akhgari
On 12-09-20 1:54 AM, Mike Hommey wrote: The sample labels will not provide instrumenting profiling. What happens is that the sample labels build up a stack, and every time that we pause the target thread when taking a sample, we walk that pseudo stack and record it. This is what we use on platf

Re: Proposal to remove the function timer code

2012-09-19 Thread Mike Hommey
On Wed, Sep 19, 2012 at 05:47:15PM -0400, Ehsan Akhgari wrote: > On 12-09-19 5:08 PM, Steve Fink wrote: > >On 09/19/2012 06:33 AM, Ehsan Akhgari wrote: > >>On 12-09-19 1:01 AM, L. David Baron wrote: > >>>On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: > A while ago (I think more than

Re: Proposal to remove the function timer code

2012-09-19 Thread Ehsan Akhgari
On 12-09-19 5:08 PM, Steve Fink wrote: On 09/19/2012 06:33 AM, Ehsan Akhgari wrote: On 12-09-19 1:01 AM, L. David Baron wrote: On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility

Re: Proposal to remove the function timer code

2012-09-19 Thread Steve Fink
On 09/19/2012 06:33 AM, Ehsan Akhgari wrote: On 12-09-19 1:01 AM, L. David Baron wrote: On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly

Re: Proposal to remove the function timer code

2012-09-19 Thread Ehsan Akhgari
On 12-09-19 2:49 PM, Andrew McCreight wrote: - Original Message - Yep, sounds fine to me -- though we don't have equivalent functionality right now, e.g. we don't quite have the ability to time/measure "regions", if it's not being maintained it's not useful. I actually ended up reimp

Re: Proposal to remove the function timer code

2012-09-19 Thread Andrew McCreight
- Original Message - > Yep, sounds fine to me -- though we don't have equivalent > functionality > right now, e.g. we don't quite have the ability to time/measure > "regions", if it's not being maintained it's not useful. I actually ended up reimplementing something like this for the cyc

Re: Proposal to remove the function timer code

2012-09-19 Thread Ehsan Akhgari
I filed bug 792502 to kill FunctionTimer and friends. Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Proposal to remove the function timer code

2012-09-19 Thread Zack Weinberg
On 2012-09-19 1:01 AM, L. David Baron wrote: On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instru

Re: Proposal to remove the function timer code

2012-09-19 Thread Vladimir Vukicevic
On 9/19/2012 12:04 AM, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instrumented a whole bunch of code which was triggered throughout

Re: Proposal to remove the function timer code

2012-09-19 Thread Ehsan Akhgari
On 12-09-19 1:01 AM, L. David Baron wrote: On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instrume

Re: Proposal to remove the function timer code

2012-09-18 Thread Taras Glek
On 9/19/2012 7:04 AM, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instrumented a whole bunch of code which was triggered throughout

Re: Proposal to remove the function timer code

2012-09-18 Thread L. David Baron
On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: > A while ago (I think more than a couple of years ago now), Vlad > implemented FunctionTimer which is a facility to time how much each > function exactly takes to run. Then, I went ahead and instrumented > a whole bunch of code which was t

Proposal to remove the function timer code

2012-09-18 Thread Ehsan Akhgari
A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instrumented a whole bunch of code which was triggered throughout our startup path to get a sense of what th