Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-14 Thread smaug
On 02/15/2017 12:41 AM, Botond Ballo wrote: But yes, don't implement probes as JS event listener when the event is some rather commonly dispatched. Same applies to observer service observers etc. In bug 1238137, I added a SCROLL_INPUT_METHODS telemetry ping in autoscrollLoop. Is that also inapp

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-14 Thread Botond Ballo
> But yes, don't implement probes as JS event listener when the event is some > rather commonly dispatched. > Same applies to observer service observers etc. In bug 1238137, I added a SCROLL_INPUT_METHODS telemetry ping in autoscrollLoop. Is that also inappropriate? Thanks, Botond [1] http://se

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-13 Thread Georg Fritzsche
For hot code paths, recording every accumulation from C++ directly into Telemetry may also not be ideal. Telemetry::Accumulate() is not very expensive, but it does have costs (locking, lookups). It can e.g. be more efficient to accumulate in a local variable and record the result into Telemetry aft

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-12 Thread smaug
On 02/12/2017 08:52 PM, Jared Wein wrote: The original email looks to be related to: https://bugzilla.mozilla.org/show_bug.cgi?id=1338891 and https://bugzilla.mozilla.org/show_bug.cgi?id=1338902 though I agree that the message could have been explained a little better. Sorry about that. I tho

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-12 Thread Jared Wein
The original email looks to be related to: https://bugzilla.mozilla.org/show_bug.cgi?id=1338891 and https://bugzilla.mozilla.org/show_bug.cgi?id=1338902 though I agree that the message could have been explained a little better. - Jared On Sun, Feb 12, 2017 at 12:41 PM, Gijs Kruitbosch wrote: >

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-12 Thread Gijs Kruitbosch
Can you clarify what you mean by "JS implemented" here? I was under the impression the telemetry implementation was in C++... Separately, was there a concrete reason for you posting this warning? I don't wish to shame people, but a concrete example of a 'wrong' pattern might help in making it

Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-12 Thread smaug
___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform