Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-21 Thread Philip Chee
On 18/12/2014 18:13, Neil wrote: > Mike Hommey wrote: >> On Wed, Dec 17, 2014 at 06:06:25PM +, Neil wrote: >>> Ehsan Akhgari wrote: >>> MSVC 2012 and 2013 can still be used to build Firefox on Windows. >>> I downloaded the MSVC 2013 Community Edition, but there was no >>> sign

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-19 Thread Neil
Neil wrote: Neil wrote: Mike Hommey wrote: On Wed, Dec 17, 2014 at 06:06:25PM +, Neil wrote: I downloaded the MSVC 2013 Community Edition, but there was no sign of an SDK, so I downloaded that separately. Is this expected? If so, I'll update MDN. The SDK comes with it. So you say,

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-18 Thread Neil
Neil wrote: Mike Hommey wrote: On Wed, Dec 17, 2014 at 06:06:25PM +, Neil wrote: I downloaded the MSVC 2013 Community Edition, but there was no sign of an SDK, so I downloaded that separately. Is this expected? If so, I'll update MDN. The SDK comes with it. So you say, but it wasn't

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-18 Thread Mike Hommey
On Thu, Dec 18, 2014 at 10:13:01AM +, Neil wrote: > Mike Hommey wrote: > > >On Wed, Dec 17, 2014 at 06:06:25PM +, Neil wrote: > > > >>Ehsan Akhgari wrote: > >> > >>>MSVC 2012 and 2013 can still be used to build Firefox on Windows. > >>> > >>I downloaded the MSVC 2013 Community Edition, but

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-18 Thread Neil
Mike Hommey wrote: On Wed, Dec 17, 2014 at 06:06:25PM +, Neil wrote: Ehsan Akhgari wrote: MSVC 2012 and 2013 can still be used to build Firefox on Windows. I downloaded the MSVC 2013 Community Edition, but there was no sign of an SDK, so I downloaded that separately. Is this expecte

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Mike Hommey
On Wed, Dec 17, 2014 at 09:36:43PM -0500, Ehsan Akhgari wrote: > On 2014-12-17 5:43 PM, Joshua Cranmer 🐧 wrote: > >On 12/17/2014 10:10 AM, Ehsan Akhgari wrote: > >>Note that this is not a change in our in-production compiler for Windows > >>(MSVC 2013), it just disables building with MSVC 2010 loca

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Ehsan Akhgari
On 2014-12-17 5:43 PM, Joshua Cranmer 🐧 wrote: On 12/17/2014 10:10 AM, Ehsan Akhgari wrote: Note that this is not a change in our in-production compiler for Windows (MSVC 2013), it just disables building with MSVC 2010 locally. MSVC 2012 and 2013 can still be used to build Firefox on Windows.

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Joshua Cranmer 🐧
On 12/17/2014 10:10 AM, Ehsan Akhgari wrote: Note that this is not a change in our in-production compiler for Windows (MSVC 2013), it just disables building with MSVC 2010 locally. MSVC 2012 and 2013 can still be used to build Firefox on Windows. Is the plan/intent to keep MSVC 2012 working or

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Mike Hommey
On Wed, Dec 17, 2014 at 06:06:25PM +, Neil wrote: > Ehsan Akhgari wrote: > > >MSVC 2012 and 2013 can still be used to build Firefox on Windows. > > > I downloaded the MSVC 2013 Community Edition, but there was no sign of an > SDK, so I downloaded that separately. Is this expected? If so, I'll

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Jeff Walden
On 12/17/2014 08:31 AM, Nathan Froyd wrote: > It's worth noting that enums with explicit types don't work in all cases > with our current B2G compiler, see bug 1058561. Also gcc will wrongly warn (and you can't turn off the warning, even in -Werror builds) if you use |enum Foo : T| as the type of

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Neil
Ehsan Akhgari wrote: MSVC 2012 and 2013 can still be used to build Firefox on Windows. I downloaded the MSVC 2013 Community Edition, but there was no sign of an SDK, so I downloaded that separately. Is this expected? If so, I'll update MDN. -- Warning: May contain traces of nuts.

Re: PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Nathan Froyd
On Wed, Dec 17, 2014 at 11:10 AM, Ehsan Akhgari wrote: > This will allow us to use enum classes (currently shimmed by > MOZ_BEGIN_ENUM_CLASS/MOZ_END_ENUM_CLASS) in mozilla-central code. > It's worth noting that enums with explicit types don't work in all cases with our current B2G compiler, see

PSA: Support for Visual C++ 2010 has been dropped

2014-12-17 Thread Ehsan Akhgari
With a few days of delay in order to give Thunderbird a chance to update their infrastructure, I just landed bug 1084532 which makes it a configure error to build with MSVC 2010 and have also updated the relevant documentation on MDN that I could find. Note that this is not a change in our in-prod