Re: Mozilla naming style vs. C++ standard library containers

2017-02-19 Thread Henri Sivonen
On Thu, Feb 16, 2017 at 9:09 PM, Botond Ballo wrote: > In the case of begin() and end(), it's not just a matter of style. It seems that nsTArray, too, mixes these into a class that otherwise follows Mozilla naming, so I guess we have enough precedent for using the standard-library naming for iter

Re: Mozilla naming style vs. C++ standard library containers

2017-02-16 Thread Henri Sivonen
On Feb 16, 2017 9:09 PM, "Botond Ballo" wrote: On Thu, Feb 16, 2017 at 1:05 PM, smaug wrote: > AFAIK, uncapitalized method names in MFBT are the old style, and new code > should just > use Mozilla coding style. > This was discussed in some other thread in dev.platform, but I can't find it > righ

Re: Mozilla naming style vs. C++ standard library containers

2017-02-16 Thread Botond Ballo
On Thu, Feb 16, 2017 at 1:05 PM, smaug wrote: > AFAIK, uncapitalized method names in MFBT are the old style, and new code > should just > use Mozilla coding style. > This was discussed in some other thread in dev.platform, but I can't find it > right now. In the case of begin() and end(), it's no

Re: Mozilla naming style vs. C++ standard library containers

2017-02-16 Thread smaug
On 02/16/2017 07:24 PM, Henri Sivonen wrote: It seems that we already have MFBT code that has lower case methods begin/end/cbegin/cend, etc., for compatibility with C++ standard library iteration: https://dxr.mozilla.org/mozilla-central/source/mfbt/ReverseIterator.h#136 I guess these methods sho

Re: Mozilla naming style vs. C++ standard library containers

2017-02-16 Thread smaug
On 02/16/2017 08:05 PM, smaug wrote: On 02/16/2017 07:24 PM, Henri Sivonen wrote: It seems that we already have MFBT code that has lower case methods begin/end/cbegin/cend, etc., for compatibility with C++ standard library iteration: https://dxr.mozilla.org/mozilla-central/source/mfbt/ReverseIte

Mozilla naming style vs. C++ standard library containers

2017-02-16 Thread Henri Sivonen
It seems that we already have MFBT code that has lower case methods begin/end/cbegin/cend, etc., for compatibility with C++ standard library iteration: https://dxr.mozilla.org/mozilla-central/source/mfbt/ReverseIterator.h#136 I guess these methods shouldn't be capitalized, then. It seems that eve