Re: About the macro naming prefix NS_

2015-07-17 Thread Kyle Huey
With the caveat that you should maintain consistency with other, similar macros, of course. If you add a new cycle collection macro it should be NS_ prefixed, until someone gets around to renaming all the existing macros. - Kyle On Jul 17, 2015 9:52 PM, "Ehsan Akhgari" wrote: > On 2015-07-17 3:1

Re: About the macro naming prefix NS_

2015-07-17 Thread Eric Shepherd
> Ehsan Akhgari > July 17, 2015 at 9:52 AM > > > Yes. I think that accurately captures our current practice. > > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-pl

Re: About the macro naming prefix NS_

2015-07-17 Thread Ehsan Akhgari
On 2015-07-17 3:13 AM, Ting-Yu Lin wrote: Currently, the style guide recommends [1]: Macros begin with NS_, and are all caps (e.g. NS_IMPL_ISUPPORTS) It seems that many new macros begin with MOZ_ prefix. Should we fix the style guide and recommend people to use MOZ_ instead of NS_? Yes. I th

About the macro naming prefix NS_

2015-07-17 Thread Ting-Yu Lin
Currently, the style guide recommends [1]: Macros begin with NS_, and are all caps (e.g. NS_IMPL_ISUPPORTS) It seems that many new macros begin with MOZ_ prefix. Should we fix the style guide and recommend people to use MOZ_ instead of NS_? [1] https://developer.mozilla.org/en-US/docs/Mozilla/De