Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-26 Thread Boris Zbarsky
On 2/26/14 11:06 PM, Masayuki Nakano wrote: I'd like to want some suggestions about our classes which do NOT represent DOM classes. I don't have terribly strong opinions on these, in general... 1. All of them which don't start with "nsDOM" are in "mozilla". This seems fine as a general rule

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-26 Thread Masayuki Nakano
On 2014/02/12 23:22, Boris Zbarsky wrote: In general, the names for things that are standardized should just match the standard name, in the mozilla::dom namespace. In some (rare) cases the standard name starts with "DOM"; in those situations we should have our name start with "DOM" as well. I

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-21 Thread Boris Zbarsky
On 2/21/14 6:07 AM, Masayuki Nakano wrote: nsDOMEvent will be just "Event". Just like Element is just Element as long as you're in DOM code, yes. This is a good thing, imo. Of course in code not in the mozilla::dom namespace, you get mozilla::dom::Event or dom::Event, which seems fine to me

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-21 Thread Masayuki Nakano
On 2014/02/21 20:21, Neil wrote: And also the header file name will be "Event.h". Won't it be "mozilla/dom/Event.h" ? Oh, good point. http://mxr.mozilla.org/mozilla-central/source/dom/events/moz.build#38 38 EXPORTS.mozilla.dom += [ 39 'EventTarget.h', 40 'PointerEvent.h', 41 'To

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-21 Thread Neil
Masayuki Nakano wrote: nsDOMEvent will be just "Event". Well, only if you're using the mozilla::dom namespace. And also the header file name will be "Event.h". Won't it be "mozilla/dom/Event.h" ? -- Warning: May contain traces of nuts. ___ dev-p

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-21 Thread Masayuki Nakano
Hi, On 2014/02/12 23:22, Boris Zbarsky wrote: On 2/12/14 4:46 AM, Masayuki Nakano wrote: I'm not sure which is the best name for the classes. E.g., DOMWheelEvent vs. PointerEvent. I believe in this case PointerEvent is correct, because http://www.w3.org/TR/pointerevents/#pointerevent-interfac

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-12 Thread Boris Zbarsky
On 2/12/14 4:46 AM, Masayuki Nakano wrote: I'm not sure which is the best name for the classes. E.g., DOMWheelEvent vs. PointerEvent. I believe in this case PointerEvent is correct, because http://www.w3.org/TR/pointerevents/#pointerevent-interface but DOMWheelEvent should probably be just Wh

[Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-12 Thread Masayuki Nakano
Hello. A lot of classes under dom/events which were moved from content/events/* are defined in global namespace. However, now, a lot of classes in other modules are defined in mozilla or its descendant namespace. Therefore, *.h files in dom/events need to write type of arguments with full