Re: what if to not to give firefox sys_admin capability with apparmor?

2020-02-14 Thread Jed Davis
On Monday, February 10, 2020 at 11:14:26 AM UTC-7, gcpas...@gmail.com wrote: > IIRC CAP_SYS_ADMIN is needed to install seccomp-bpf filters. We don't need capabilities for seccomp-bpf. We do need capabilities for anything namespace-related: chroot()ing to a deleted directory to revoke filesystem

Re: Intent to deprecate - linux32 tests starting with Firefox 69

2019-04-08 Thread Jed Davis
jma...@mozilla.com writes: > As our next ESR is upcoming, I would like to turn off linux32 on > Firefox 69 and let it ride the trains and stay on 68 ESR. This will > allow builds/tests to be supported with security updates into 2021. Does this mean that Linux on 32-bit x86 is being demoted to Ti

Re: Performance profiling improvements #3

2018-10-31 Thread Jed Davis
Mike Hommey writes: > On Mon, Oct 22, 2018 at 02:20:32PM -0700, Panos Astithas wrote: >> To record a profile with the ‘perf’ command run the >> following commands and then load the firefox.symbol.data output file from >> https://perf-html.io: >> > sudo perf record -g -F 999 -p >> > sudo perf scr

Re: Enabling (many) assertions in opt builds locally and eventually Nightly

2018-09-20 Thread Jed Davis
Cameron McCormack writes: > (I wonder if we could collect all the same data, and use the same > crash reporting infrastructure, for non-crashing crash reports like > this.) For what it's worth, I've done something very close to this *accidentally*, on Linux, by manually sending a crash signal to

Re: Enabling seccomp-bpf for content process on nightly Linux desktop

2016-07-06 Thread Jed Davis
Ted Mielczarek writes: > On Tue, Jul 5, 2016, at 11:18 PM, Jed Davis wrote: >> (However, there aren't automated >> tests to ensure it keeps working; "crashing the content process" isn't a >> use case that the test framework docs were very helpful with

Re: Enabling seccomp-bpf for content process on nightly Linux desktop

2016-07-05 Thread Jed Davis
Steve Fink writes: > On 07/05/2016 01:33 AM, Julian Hector wrote: >> If you encounter a crash that may be due to seccomp, please file a bug in >> bugzilla and block Bug 1280415, we use it to track issues experienced on >> nightly. > > What would such a crash look like? Do they boil down to some s

Re: Enabling seccomp-bpf for content process on nightly Linux desktop

2016-07-05 Thread Jed Davis
Benjamin Smedberg writes: > Assuming these crashes show up in crash-stats.mozilla.com, are there > particular signatures, metadata, or other patterns that would let us say > "this crash is caused by a sandbox failure"? They should, and the expected distinguishing feature is a "Crash Reason" of "

Re: Static analysis for "use-after-move"?

2016-04-27 Thread Jed Davis
Kyle Huey writes: > Can we catch this pattern with a compiler somehow? > > Foo foo; > foo.x = thing; > DoBar(mozilla::Move(foo)); > if (foo.x) { /* do stuff */ } https://bugzilla.mozilla.org/show_bug.cgi?id=1186706 ("Consider static analysis for Move semantics") There are patches on the bug, bu

Re: Requiring a try job prior to autolanding to inbound

2016-01-28 Thread Jed Davis
Adam Roach writes: > My understanding is that the autolander is available only to > developers with Level 3 access, right? Given that this is the same > group of people who can do a manual check-in, I don't see why we would > make autolanding have to clear a higher bar than manual landing. We co

Re: HEADS-UP: Disabling Gecko Media Plugins on older Linux kernels (bug 1120045)

2015-01-29 Thread Jed Davis
On Thu, Jan 29, 2015 at 06:57:30AM +0900, Mike Hommey wrote: > So, in practice, because the h264 code is not sandboxed on some setups, > we're disabling it so that vp8, which is not sandboxed either, is used > instead. We have about the same amount of control over openh264 and > vp8 code bases. Wha

HEADS-UP: Disabling Gecko Media Plugins on older Linux kernels (bug 1120045)

2015-01-28 Thread Jed Davis
Short version: On desktop Linux systems too old to support seccomp-bpf system call filtering[1], Gecko Media Plugins will be disabled; in practice, this means OpenH264, which is used for H.264 video compression in WebRTC. This will be controlled with a pref, "media.gmp.insecure.allow". [1] Exampl

Re: Non-Trivial SpecialPowers Usage Considered Harmful

2014-08-18 Thread Jed Davis
Bobby Holley writes: [...] > If you find yourself itching to do something complicated, write a > mochitest-chrome test. The default template [2] now generates html files > (rather then XUL files), so the ergonomics there should be easier than > before. > > If you don't want to write a mochitest-ch

Re: Policing dead/zombie code in m-c

2014-04-24 Thread Jed Davis
On Thu, Apr 24, 2014 at 11:01:00AM -0400, Trevor Saunders wrote: > On Thu, Apr 24, 2014 at 09:20:06AM -0400, Benoit Jacob wrote: > > 2014-04-24 8:31 GMT-04:00 Henri Sivonen : > > > I have prepared a queue of patches that removes Netscape-era (circa > > > 1999) internationalization code that efforts

Re: Deciding whether to change the number of unified sources

2013-12-03 Thread Jed Davis
On Tue, Dec 03, 2013 at 11:47:48AM -0800, L. David Baron wrote: > On Tuesday 2013-12-03 10:18 -0800, Brian Smith wrote: > > Also, I would be very interested in seeing "size of libxul.so" for > > fully-optimized (including PGO, where we normally do PGO) builds. Do > > unified builds help or hurt lib

Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Jed Davis
On Thu, Nov 21, 2013 at 05:41:27PM -0500, Boris Zbarsky wrote: > On 11/21/13 3:15 PM, Gavin Sharp wrote: >> It would be good to explore alternatives to Bonsai. >> https://github.com/mozilla/mozilla-central is supposed to have full >> CVS history, right? > > Hmm. Where in there is the equivalent o

Re: Should we build a new in-process unwind library?

2013-08-30 Thread Jed Davis
On Fri, Aug 30, 2013 at 10:58:25AM +0200, Julian Seward wrote: > What we have works, but is less than ideal in a number of ways: > > (1) It's slow. CFI/EXIDX unwinding with Breakpad costs about 6600 > instructions/frame, or around 120+K/instructions per stack trace. > That makes it infeas

Re: Code coverage take 2, and other code hygiene tools

2013-06-25 Thread Jed Davis
On Mon, Jun 24, 2013 at 08:02:26PM -0700, Justin Lebar wrote: > Under what circumstances would you expect the code coverage build to break > but all our other builds to remain green? Anywhere you're using -Werror. I ran into this in a past life with GCC's may-use-uninitialized warning; if it's st

Re: Storage in Gecko

2013-05-06 Thread Jed Davis
On Mon, May 06, 2013 at 09:41:08AM -0700, David Dahl wrote: > KyotoCabinet might make a good backend for a new storage API: > > http://fallabs.com/kyotocabinet/ It's released under the GPL, so it's MPL-incompatible, if I understand correctly. As for the "Kyoto Products Specific FOSS Library Link

Re: Please upgrade to at least Mercurial 2.5.1

2013-02-21 Thread Jed Davis
On Thu, Feb 21, 2013 at 11:36:15AM +, Gervase Markham wrote: > The Mercurial download page: > http://mercurial.selenic.com/downloads/ > offers 2.5.1 for Mac and Windows, but no Linux packages. Can guidance be > provided as to where to get such things for commonly-run versions of Linux? Debian