Re: PSA: Automated code analysis now also in Phabricator

2018-07-17 Thread Jan Keromnes
under 8 minutes, so if you haven't heard from the bot in a while it means your patch is probably fine: https://p.datadoghq.com/sb/NsBIKn-240d11775d25dce0ef2c47d4b7ce0ae0 Jan On Tue, Jul 17, 2018 at 11:10 PM Mike Hommey wrote: > On Tue, Jul 17, 2018 at 05:06:07PM +0200, Jan Keromnes wrote

Re: PSA: Automated code analysis now also in Phabricator

2018-07-17 Thread Jan Keromnes
d the patch (e.g. after rebasing it). Note that the bot doesn't publish anything if no defect was detected. A complete analysis generally takes a few minutes. Jan Am 17.07.2018 16:55 schrieb "Jean-Yves Avenard" : Hi On 17 Jul 2018, at 3:22 pm, Jan Keromnes wrote: TL;DR -- “re

PSA: Automated code analysis now also in Phabricator

2018-07-17 Thread Jan Keromnes
TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential defects in pending patches for Firefox. Last year, we announced Code Review Bot (“reviewbot”, née “clangbot”), a Taskcluster bot that analyzes every patch submitted to MozReview, in order to automatically detect and report co

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread Jan Keromnes
Thanks glandium! Yes, reporting defects that are expanded from macros generates a lot of noise, and it's not always an issue we can fix (e.g. when the macro comes from third-party code). So we've decided to stop reporting these, and the fix was merged in time for tomorrow's push to production. TL

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-09 Thread Jan Keromnes
d, Oct 4, 2017 at 7:14 PM, Ehsan Akhgari > wrote: > >> On 10/04/2017 03:17 AM, Jan Keromnes wrote: >> >>> TL;DR -- We wrote a static analysis bot for MozReview ("clangbot") and >>> it's >>> about to complain about any patches that would in

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-04 Thread Jan Keromnes
ing the fix to production, so the bot should stop sending them soon. Apologies for the bugmail noise. On Wed, Oct 4, 2017 at 4:16 PM, Boris Zbarsky wrote: > On 10/4/17 3:17 AM, Jan Keromnes wrote: > >> Please report any bugs with the bot here: https://bit.ly/2y9N9Vx >> > > No

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-04 Thread Jan Keromnes
that are not using MozReview. Will those > patches be analyzed after landing? > > Nick > > On Wed, Oct 4, 2017 at 6:17 PM, Jan Keromnes wrote: > >> TL;DR -- We wrote a static analysis bot for MozReview ("clangbot") and >> it's >> about to complain a

Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-04 Thread Jan Keromnes
TL;DR -- We wrote a static analysis bot for MozReview ("clangbot") and it's about to complain about any patches that would introduce new C/C++ code defects to Firefox. Please report any bugs with the bot here: https://bit.ly/2y9N9Vx In an effort to improve the quality of Firefox, we want to catch

How to use the correct fonts on Firefox OS simulators?

2014-04-18 Thread Jan Keromnes
On Firefox OS devices, special fonts like "Fira Sans" and "Fira Mono" are used. On desktop environments (Simulator / B2G desktop), different fonts are used. We are trying to fix this in bug 992210, but we are not familiar with how fonts work in Firefox, and need some help. In Gaia, generic fon

Re: DXR gets multi-line highlighting

2014-03-14 Thread Jan Keromnes
I discovered this by chance today, shift+clicking the line numbers to reference a code range in a bug. Had no idea it was so recent - thanks a lot! Jan On Thursday, March 13, 2014 5:46:14 PM, Erik Rose wrote: A lot of you have asked for the ability to select and share ranges within source file