Re: Doxygen output?

2017-02-24 Thread Benoit Girard
I find it a bit unfortunate that people link are removed since mozilla loses a lot of valuable resources and small test cases. With that being said I have a repo with the scripts I used to run doxygen. I think mstange might be running it somewhere. https://github.com/bgirard/doxygen-mozilla It wi

Re: Do we have some documents listing up when we need to touch CLOBBER?

2016-12-16 Thread Benoit Girard
One of my goal when introducing CLOBBER was to document what was causing us to CLOBBER so that we could audit and fix them if we ever found the time. You can get a pretty good idea by going through the history of the file. I don't believe anyone has taken to time to go through the CLOBBER hg histo

Re: Faster gecko builds with IceCC on Mac and Linux

2016-07-04 Thread Benoit Girard
2 PM, Gijs Kruitbosch wrote: > On 04/07/2016 22:06, Benoit Girard wrote: > >> So to emphasize, if you compile a lot and only have one or two machines >> on your 100mps or 1gbps LAN you'll still see big benefits. >> > > I don't understand how this benefits

Re: Faster gecko builds with IceCC on Mac and Linux

2016-07-04 Thread Benoit Girard
This barely works in a office with 10MB/sec wireless uplink. Ideally you want machines to be accessible on a gigabit LAN. It's more about bandwidth throughput than latency AFAIK. i.e. can you *upload* dozens of 2-4MB compressed pre-processed file faster than you compile it? I'd imagine unless you c

Re: Documentation on how to read crash reports

2016-05-26 Thread Benoit Girard
There's some information I've learned about reading crash reports, which is obvious now but wasn't when I was an intern many years ago, that isn't really covered by these. Here's my workflow when looking at crashes: - Windows tells you if the exception occurred during a write or read. Look at the

Re: Run firefox as headless???

2016-04-07 Thread Benoit Girard
If xvfb doesn't work for you then as far as I know there's no way for it to be truly headless unfortunately. Looks like slimerjs is trying to to solve this issue: https://github.com/laurentj/slimerjs/issues/80 They mention using createWindowlessBrowser but I'm not familiar with it. On Thu, Apr 7,

Re: Run firefox as headless???

2016-04-07 Thread Benoit Girard
Check out slimerjs: https://slimerjs.org/ On Thu, Apr 7, 2016 at 6:50 PM, Devan Shah wrote: > Is it possible to run firefox in headless form to fetch url and get the > full Dom as rendered. Same way it would render on normal foredox > ___ > dev-platfor

Re: Testing Wanted: APZ Scrollbar dragging

2016-03-29 Thread Benoit Girard
dly this happens very infrequently, so I haven't been able to create > steps to reproduce, nor seen any pattern in where it triggers. > As Felipe points out this is a recent APZ regression and isn't tied to this feature. > > / Jonas > > > On Wed, Feb 17, 2016 at 1

Re: #include sorting: case-sensitive or -insensitive?

2016-03-28 Thread Benoit Girard
a) It's explained in the style docs: 1. The main header: Foo.h in Foo.cpp 2. Standard library includes: #include 3. Mozilla includes: #include "mozilla/dom/Element.h" Thus you'd want the second b) I'm assuming it includes the path. That's what I've seen most of the code do too and it m

Introducing MozGTestBench - Platform micro-benchmarks

2016-03-18 Thread Benoit Girard
In bug 1256408 I've landed code to allow adding *in-tree* platform micro-benchmarks for XUL code in less than 10 lines. These are just GTest where the execution time is reported to perfherder. This makes it easy to add low level platform micro-benchmarks for testing things that Talos is not well su

Re: Proposing preferring Clang over GCC for developer buidls

2016-03-02 Thread Benoit Girard
Note that, as you say, the debugging information produced by the compiler and the debugger that consumes it are completely orthogonal. I've tried several times to use lldb but I keep coming back to GDB. Particularly now with RR+GDB it's light years ahead. I find that GDB works quite well with the

Re: Testing Wanted: APZ Scrollbar dragging

2016-02-17 Thread Benoit Girard
, Nicholas Alexander wrote: > Benoit, (possibly kats), > > On Wed, Feb 17, 2016 at 10:35 AM, Benoit Girard > wrote: > >> Currently APZ does not cause scrollbar initiated scrolling to be async. >> I've been working in fixing this and I'd like some help testing it o

Testing Wanted: APZ Scrollbar dragging

2016-02-17 Thread Benoit Girard
Currently APZ does not cause scrollbar initiated scrolling to be async. I've been working in fixing this and I'd like some help testing it out before enabling it on Nightly. If you're interested please flip 'apz.drag.enabled' to true and restart. If you find any issue please make it block https://b

Re: rr chaos mode update

2016-02-14 Thread Benoit Girard
I've got RR working under digital oceans and it works great there. We've built a harness for generating replays. Once a replay is generated I match the replay with the bug and comment in the bug looking for developers to investigate. When they respond they can investigate by ssh'ing. Example: http

Re: mozregression – Engineering Productivity Project of the Month

2016-01-11 Thread Benoit Girard
I wanted to chime-in and emphasis this: One of the first thing you do when looking at a bug is establish if it's a regression and starting with mozregression right away if it is! From my experience running mozregression for easily reproduced regressions can be done in about 10 minutes and it real

Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-04 Thread Benoit Girard
Thanks Mike for your hard work pushing this through! In theory it does let us profile e10s on TAlos, but I'm sure well will find more usability issues. It's unclear if they will be a blocker or not. If there's outstanding issues I don't think we know about them. Please file them and CC me on any i

Re: Updates to Chrome platform support

2015-11-10 Thread Benoit Girard
There's been discussion of dropping 10.6.0 to 10.6.2 (free upgrade path for everyone to 10.6.3+) in hope of removing a graphics workaround but it's stalled and the upside wasn't really high: https://bugzilla.mozilla.org/show_bug.cgi?id=1003270 On Tue, Nov 10, 2015 at 4:37 PM, Chris Peterson wrote

Re: Finding out if the main thread is currently animating

2015-10-29 Thread Benoit Girard
We've explored several different ways of measuring this. Several of these are in the tree. Generally what I have found the most useful is to measure how we're servicing the content' main thread. This measurement is great because its measures how responsive Firefox is not only for scrolling/animatio

Re: Decommissioning "dumbmake"

2015-10-15 Thread Benoit Girard
+1 For my use case breaking dumbmake is preferable given that we now have 'build binaries'. When touching commonly included header I often like to run ./mach build gfx && ./mach build binaries. This effectively let's me say 'Make sure my gfx changes are good before you recompile the rest of gecko'

Re: Building js/xul/css from Firefox faster

2015-10-05 Thread Benoit Girard
This is great progress! I had hope that something like this would also include the 'build binaries' DAG. It might make it slightly slower but it should still be very fast and lessen the cognitive load. I was under the impression that 'build binaries' at some point was a single DAG but it doesn't s

Re: Building js/xul/css from Firefox faster

2015-10-05 Thread Benoit Girard
This is great progress! I had hope that something like this would also include the 'build binaries' DAG. It might make it slightly slower but it should still be very fast and lessen the cognitive load. I was under the impression that 'build binaries' at some point was a single DAG but it doesn't s

Re: Is APZ meant to be a permanent part of the platform?

2015-10-04 Thread Benoit Girard
On Sun, Oct 4, 2015 at 2:20 PM, Marcus Cavanaugh wrote: > we can't > achieve flawless 60fps performance without APZ. We can get close, but any > nontrival-but-reasonable demo will encounter jank, ostensibly due to > compositing and rendering taking too much time. (APZ pathways, rendering > the sa

Re: mach mozregression command

2015-09-17 Thread Benoit Girard
Yes that's a good point and a perfectly sensible. Thanks for the handy wrapper! On Wed, Sep 16, 2015 at 5:37 PM, J. Ryan Stinnett wrote: > On Wed, Sep 16, 2015 at 1:42 PM, Benoit Girard > wrote: > > I just > > hope that we continue to maintain mozregression as a stand

Re: mach mozregression command

2015-09-16 Thread Benoit Girard
This probably doesn't need to be mentioned but I'd like to discuss it anyways: We often ask bug reporters and various non developers to run bisection for us. Maintaining mozregression to work well without a code checkout (i.e. standalone) is important. I nearly feel that it should be so easy to ru

Re: Can we make a plan to retire Universal Mac builds?

2015-08-06 Thread Benoit Girard
Is this the data for people who are running only the latest release or some arbitrary Firefox releases where FHR/data collection is enabled? I ask because this data doesn't include any 10.4 and 10.5 usage so it's not an overall population snapshot. Sampling the crash data (very noisy I know) puts 1

Re: Allowing web apps to delay layout/rendering on startup

2015-07-31 Thread Benoit Girard
It should be represented as a color layer which is very cheap. We should only composite it once. We will use a bit of memory bandwidth but nothing major, the main thread impact should be very small. I agree, we should really have some data to support that drawing something like a display:none is c

Vim Users: Introducing YouCompleteMe Support

2015-07-20 Thread Benoit Girard
(4) show compile errors while editing, (5) it's accurate. Follow this guide to setup YCM with the clang option, it should take ~15 minutes to setup: https://developer.mozilla.org/en-US/docs/YouCompleteMe -Benoit Girard ___ dev-platform mailing list d

Re: Summary of e10s performance (Talos + Telemetry + crash-stats)

2015-07-15 Thread Benoit Girard
For the e10s talos regressions see https://bugzilla.mozilla.org/show_bug.cgi?id=1174776 and https://bugzilla.mozilla.org/show_bug.cgi?id=1184277. We've already diagnose one source of the regression to be a difference with GC/CC behavior when running e10s talos. On Fri, Jul 10, 2015 at 5:44 PM, Vla

Re: Per-test chaos mode now available, use it to help win the war on orange!

2015-07-10 Thread Benoit Girard
I've filed a bug for enabled Chaos Mode without recompiling: https://bugzilla.mozilla.org/show_bug.cgi?id=1182516 On Mon, Jun 8, 2015 at 9:12 AM, wrote: > On Thursday, June 4, 2015 at 6:15:35 PM UTC-4, Chris AtLee wrote: > > Very interesting, thank you! > > > > Would there be a way to add an en

Re: PSA: Xcode+gecko for newbies instructional video

2015-05-22 Thread Benoit Girard
I did the eclipse generation. It's not really meant to compile, it's only meant for writing code ATM. The challenge with Eclipse is dealing with the CDT limitations and quirks. There's part of our code base that is correct C++ that the CDT does not understand, some of which is for performance reaso

Re: Is MOZ_SHARK still used?

2015-04-06 Thread Benoit Girard
+1 for removing it. While a great tool at the time, it's now a dead end with good alternatives. On Mon, Apr 6, 2015 at 11:11 AM, Eric Shepherd (Sheppy) < esheph...@mozilla.com> wrote: > Is it worth talking to someone from the TenFourFox project > (http://www.floodgap.com/software/tenfourfox/) to

Re: Capturing additional metadata in moz.build files

2014-12-10 Thread Benoit Girard
On Tue, Dec 9, 2014 at 1:46 PM, Gregory Szorc wrote: > * Building a subscription service for watching code and reviews > They all sound great. Except I'm not sure what you mean by this one. Are you suggesting that we have something like a list of email in moz.build to register for updates to a

Re: Profiling on Linux

2014-11-13 Thread Benoit Girard
Thanks for pointing this out, there's no single all purpose tool. Just a reminder that we have documentation on how to look into performance problems here: https://developer.mozilla.org/en-US/docs/Mozilla/Performance Zoom already has a page on there. If there's any mozilla specific information ab

Re: MozReview ready for general use

2014-11-06 Thread Benoit Girard
Cool. I'm eager to try this out. Sadly https://hg.mozilla.org/hgcustom/version-control-tools is giving me a 503 error at this time. On Wed, Nov 5, 2014 at 11:50 PM, Mark Côté wrote: > A couple months ago I gave a sneak peak into our new repository-based > code-review tool based on Review Board.

Re: NS_StackWalk is totally broken on Win64

2014-11-06 Thread Benoit Girard
Off the top of my head: - Are you compiling with --enable-profiling? - The actual unwind is performed by DbgHelp library. Make sure it's up-to-date. We have had this issue on windows xp that require a DbgHelp update. Unlikely for win8 but a good thing to check. - The call is made here: http://mxr.m

Re: Intent to ship: CSS will-change

2014-10-31 Thread Benoit Girard
x27;t give them the performance benefits that they > expect. > > > On 2014-10-31 3:36 PM, Benoit Girard wrote: >> >> Yes, it's implemented in part 1-4 of my patch queue in bug 961871. >> >> Here's how it works -but is subject to change at any time-: >> - T

Re: Intent to ship: CSS will-change

2014-10-31 Thread Benoit Girard
used an author could lose their will-change optimizations because we decided to re-rasterize a scaled layer at a higher resolution. This happens seemingly unpredictably from an author' point of view. On Fri, Oct 31, 2014 at 3:10 PM, L. David Baron wrote: > On Friday 2014-10-31 14:17 -04

Intent to ship: CSS will-change

2014-10-31 Thread Benoit Girard
MQx1k/R_cPDxwEtEYJ [4] https://status.modern.ie/csswillchange?term=will-change [5] https://wpdev.uservoice.com/forums/257854-internet-explorer-platform/suggestions/6261294-css-will-change [6] https://developer.mozilla.org/en-US/docs/Web/CSS/will-change - Benoit G

Re: profiler in TB

2014-10-29 Thread Benoit Girard
The profiler addon on TB shouldn't be using the panel. It has another piece of UI because jetpack doesn't support the panel in TB. Adding that support will make these issues go away of course. Since it's the same code base it's likely just a regression where the panel code is used in shared code.

Re: Announcing Eclipse CDT IDE Support

2014-10-24 Thread Benoit Girard
I believe for b2g you can use the following which will only rebuild gecko: cd objdir-gecko/ ../gecko/mach ide eclipse On Fri, Oct 24, 2014 at 12:22 AM, Botond Ballo wrote: >> A new command has now landed: './mach ide eclipse' > > Nice! Thanks for all your work on this. > >> will perform the follo

Announcing Eclipse CDT IDE Support

2014-10-23 Thread Benoit Girard
A new command has now landed: './mach ide eclipse' and all you need is the eclipse CDT binary on your path. This is your ideal pre-coffee/lunch command and will perform the following: - Rebuild the project - Generate an eclipse workspace + gecko project - Import the mozilla coding style - Launch t

Re: gtests that start XPCOM

2014-10-23 Thread Benoit Girard
Like Ted mentions GTest doesn't support running test in parallel -in the same process-, you have to launch multiple processes which the ./mach gtest command helps you do. Currently GTest has a ScopedXPCOM thing. I'm not sure exactly what this implies however: http://mxr.mozilla.org/mozilla-central

Re: Experiment with running debug tests less often on mozilla-inbound the week of August 25

2014-08-19 Thread Benoit Girard
I completely agree with Jeff Gilbert on this one. I think we should try to coalesce -better-. I just checked the current state of mozilla-inbound and it doesn't feel any of the current patch really need their own set of tests because they're are not time sensitive or sufficiently complex. Right no

Re: Recommendations on source control and code review

2014-04-13 Thread Benoit Girard
I didn't know this existed. I filed bug 995763 to get this link added to the 'review requested' email to hopefully increase visibility. On Sat, Apr 12, 2014 at 12:10 PM, Kartikaya Gupta wrote: > Just a reminder that this page exists: > > https://developer.mozilla.org/en-US/docs/Developer_Guide/

Re: Using preferences off the main thread now asserts

2014-03-06 Thread Benoit Girard
Thanks for doing this. However I feel like our options for code that need preferences off the main thread are a bit poor. The first option is to send an IPC message to the main thread but that has very poor performance, requires a lot of boilerplate code and either an sync message or async+restruc

Re: Tagging legitimate main thread I/O

2014-02-07 Thread Benoit Girard
With the profiler' IO tracking feature we have a few options: We match certain signatures after the data is collected. + Doesn't require changes to gecko, adjustments are cheap - Matching signatures can be tricky/unreliable We instrumented gecko to allow IO between two calls + Similar to shutdown

Re: Please give ask.mozilla.org for a spin

2014-02-04 Thread Benoit Girard
I notice that right now we need 5 karma to up vote so there's a bit of a catch-22 for the up voting to start. I think right now it's up to the admin to get a pool of users to break the catch-22. On Mon, Feb 3, 2014 at 5:32 PM, Taras Glek wrote: > Hi, > A few people noticed that we do not have a

Re: Should we build a new in-process unwind library?

2014-01-05 Thread Benoit Girard
My goal is to make SPS's stack easier to grab. SPS provides native stack (if possible) plus pseudo stack. So it generally has more data then just a native stack and is much more portable. That being said making the unwind library independent is a win-win. On Thu, Jan 2, 2014 at 11:03 AM, Jim Che

Re: OMTC for Windows users (nightly only)

2013-12-04 Thread Benoit Girard
Congratulations! This is a major step forward for modernizing our rendering on desktop, removing old code and simplifying how we render. This will unblock important optimizations such as OMTAnimation and APZC. I'm omitting many benefits. Great work! On Wed, Dec 4, 2013 at 3:05 AM, Nicholas Camero

Re: PSA: The profiling branch has shut down

2013-11-12 Thread Benoit Girard
That's correct. It means that benchmarking on nighties isn't really accurate so beware when running web/js benchmarks. Also it is wrong to assume an average performance cost and scale the nightly results by a factor. We made this decision with the hope that we could better gather performance data

Re: Measuring power usage

2013-11-06 Thread Benoit Girard
You might be interested in bug 769431 where Intel modified power gadget to export symbols that the profiler can use to sample the power state and correlate it with execution. On Tue, Nov 5, 2013 at 11:02 AM, jmaher wrote: > I am working on using intel power gadget to measure the power usage. >

Re: unified shader for layer rendering

2013-10-10 Thread Benoit Girard
On Thu, Oct 10, 2013 at 7:59 AM, Andreas Gal wrote: > Rationale: > switching shaders tends to be expensive. > In my opinion this is the only argument for working on this at moment. Particularly at the moment where we're overwhelmed with high priority desktop and mobile graphics work, I'd like to

Re: You want faster builds, don't you?

2013-09-23 Thread Benoit Girard
On Mon, Sep 23, 2013 at 12:49 AM, Robert O'Callahan wrote: > I observe that Visual Studio builds do not spawn one cl process per > translation unit. Knowing how slow Windows is at spawning processes, I > suspect the build would be a lot faster if we used a single cl process to > compile multiple t

Re: Code Review Session

2013-05-29 Thread Benoit Girard
On Mon, May 27, 2013 at 10:54 PM, Anthony Jones wrote: > A pre-upload check would give the fastest feedback. I'll be checking in a script in the mozilla repo that can be ran offline and produce the same results. On Tue, May 28, 2013 at 10:44 AM, Mike Hoye wrote: > On 2013-05-27 10:54 PM, Antho

Re: Code Review Session

2013-05-24 Thread Benoit Girard
e of the code but importing it turns out to be a low effort/high reward. I've already started working on a robot to post to bugzilla. Perhaps later we can replace it with a more intelligent tool. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=875605 -Benoit Girard _

Re: Standalone GTests

2013-05-08 Thread Benoit Girard
If you plan on adding more tests to GTest please build against patches in bug 844288 which will hopefully land soon. Note that I have one outstanding problem left on Windows where the linking only fails on TBPL jobs. I personally have a strong preference for keeping tests, particularly unit tests,

Re: Doxygen For Mozilla-Central Modules

2013-05-01 Thread Benoit Girard
On Wed, May 1, 2013 at 12:47 PM, Ralph Giles wrote: > You might consider putting only the variables you've > changed in your Doxyfiles, relying on the defaults for everything else. Thanks for the feedback. I started with the config in config/doxygen.cfg.inbut it does seem significantly out of d

Re: Doxygen For Mozilla-Central Modules

2013-05-01 Thread Benoit Girard
Right now doxygen runs directly on the source code so it's not trivial to run doxygen on there. I'd be happy to accept a pull that builds and indexes dist/idl. On Wed, May 1, 2013 at 12:35 PM, Joshua Cranmer 🐧 wrote: > On 5/1/2013 11:21 AM, Benoit Girard wrote: > >> I&#x

Re: Doxygen For Mozilla-Central Modules

2013-05-01 Thread Benoit Girard
sts to run doxygen on additional submodules. > > There > > are several problems with the configuration files that could improve > > the > > results (e.g. include path) that I do NOT plan on fixing but will > > gladly > > accept a pull request. Note that the res

Doxygen For Mozilla-Central Modules

2013-05-01 Thread Benoit Girard
submodules. There are several problems with the configuration files that could improve the results (e.g. include path) that I do NOT plan on fixing but will gladly accept a pull request. Note that the results appear to be sufficiently useful without these fixes. -Ben

Re: reorganizing some test directories

2013-04-10 Thread Benoit Girard
With the fix to bug 844288 gtest will also need their own directory. I was planning on allowing users to use /tests folder for their tests but to go in line with this upcoming change I'll update my patches and suggest that anyone who adds gtest to use /tests/gtest to conform with this new style. I

Re: GTest has landed

2013-02-25 Thread Benoit Girard
It's not and it's a great suggestion. I filed bug 844869. On Mon, Feb 25, 2013 at 11:04 AM, L. David Baron wrote: > On Monday 2013-02-25 10:57 -0500, Benoit Girard wrote: >> GTest has landed this weekend on mozilla-central[1]. It should now be >> ready for developers

GTest has landed

2013-02-25 Thread Benoit Girard
/GTest [1] https://bugzilla.mozilla.org/show_bug.cgi?id=767231 [2] http://benoitgirard.wordpress.com/2013/02/25/gtest-has-landed-start-writing-your-unit-tests/ Benoit Girard ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.or

Re: Try Server wait times - please cancel unwanted/busted runs

2012-12-19 Thread Benoit Girard
I filed a bug for doing what I suggested. Turns out we don't need CORS headers for a GET: https://bugzilla.mozilla.org/show_bug.cgi?id=823135 On Fri, Dec 7, 2012 at 5:02 PM, Benoit Girard wrote: > If we could expose the data via a cross domain API in text format I can > modify tr

Re: Try Server wait times - please cancel unwanted/busted runs

2012-12-07 Thread Benoit Girard
If we could expose the data via a cross domain API in text format I can modify trychooser to display loaded platforms. On Fri, Dec 7, 2012 at 2:06 PM, Ehsan Akhgari wrote: > On 2012-12-07 1:54 PM, Benoit Girard wrote: > >> Is there an API we can query to know what the estimated

Re: Try Server wait times - please cancel unwanted/busted runs

2012-12-07 Thread Benoit Girard
Is there an API we can query to know what the estimated wait time or load for a slave pool is? Perhaps 'http://trychooser.pub.build.mozilla.org/' could be modified to give an indication of the load for a particular platform. I would be more mindful at balancing my load if the information was provid

RE: HTML depth limit?

2012-10-29 Thread Benoit Girard
I actually run into the same problem with the cleopatra tree widget. Each tree level adds 2 or 3 levels to the DOM for that page so I think after 100 to 200 levels the expansion stops. Ehsan mentions that we have a limit on our frame tree as we use recursion but I don't know where this code lives.

Re: Changing reftest required resolution

2012-08-28 Thread Benoit Girard
I've already done this work but we decided to just increase the resolution for our tegra board: See https://bugzilla.mozilla.org/show_bug.cgi?id=66 which includes an outdated patch that adds a screen(w,h) annotation to each test and a patch to compute the required size per test. On Tue, Aug 2