On Mon, Dec 17, 2018 at 1:22 PM Steve Fink wrote:
> In theory, I would definitely prefer if all the code were auto-formatted
> during regular development(*), but in practice the performance means
> it's not as transparent as it needs to be -- I have noticed that since
> enabling the format-source
On Fri, Dec 14, 2018 at 4:55 PM Kartikaya Gupta wrote:
> On Fri, Dec 14, 2018 at 1:58 PM Sylvestre Ledru
> wrote:
> > We have more and more tools at review phase (clang-format, flake8,
> eslint, clang-tidy, codespell, etc) which propose some auto-fixes.
>
> Honestly I find it quite annoying when
In theory, I would definitely prefer if all the code were auto-formatted
during regular development(*), but in practice the performance means
it's not as transparent as it needs to be -- I have noticed that since
enabling the format-source extension, rebasing my patch stacks is
significantly sl
On Sun, Dec 16, 2018 at 9:08 PM Makoto Kato wrote:
> Hi,
>
> Is Objective-C++ (*.mm) still old format? Or Should I file a bug for it?
>
We didn't include Objective-C++ in the initial reformatting of the tree
mostly to avoid scope creep, but clang-format is well capable of formatting
it. Please
On Mon, Dec 17, 2018 at 9:33 AM Kartikaya Gupta wrote:
> Local commit hooks are even better, thanks! Are there instructions
> somewhere on how to set up the hooks and make sure they run properly?
>
We've yet to document these hooks but enabling them is very similar to
enabling the lint hooks whi
Local commit hooks are even better, thanks! Are there instructions
somewhere on how to set up the hooks and make sure they run properly?
On Mon, Dec 17, 2018 at 9:22 AM Ehsan Akhgari wrote:
>
> On Fri, Dec 14, 2018 at 7:20 AM Kartikaya Gupta wrote:
>>
>> Personally I would prefer if we rewrote t
On Fri, Dec 14, 2018 at 7:20 AM Kartikaya Gupta wrote:
> Personally I would prefer if we rewrote the commits locally to be
> formatted prior to submitting it into Phabricator. That way everything
> stays in sync. Also usually clang-formatting a patch is the last thing
> I want to do before submis
Le 14/12/2018 à 22:55, Kartikaya Gupta a écrit :
On Fri, Dec 14, 2018 at 1:58 PM Sylvestre Ledru wrote:
We have more and more tools at review phase (clang-format, flake8, eslint,
clang-tidy, codespell, etc) which propose some auto-fixes.
Honestly I find it quite annoying when I'm trying to r
Hello,
Here's the list of new issues found and filed by the Desktop Release QA
team last two weeks.
Additional details on the team's priorities last week, as well as the
plans for the current week are available at: https://tinyurl.com/y8yjg3vj
Bugs logged by Desktop Release QA in the last 7 da
9 matches
Mail list logo
