Re: Plan for Sunsetting MozReview

On 05/09/2018 04:40, Kris Maglione wrote: Concur. Aside from future-proofing things, reading comments in phabricator is pretty painful, especially for bugs with multiple patches. With the old flow, I could look at all of them in one place. Now, I have to open a half dozen separate pages, and th

Re: Plan for Sunsetting MozReview

On Tue, Sep 04, 2018 at 07:37:28PM +0200, Dão Gottwald wrote: This may have been discussed before since it's kind of an obvious question: Was there a conscious decision not to post phabricator review comments to bugzilla? It's a somewhat significant change from how we've used bugzilla. I can see

Re: Plan for Sunsetting MozReview

Dão Gottwald wrote on 5/9/18 1:37 am: This may have been discussed before since it's kind of an obvious question: https://groups.google.com/forum/#!msg/mozilla.dev.platform/V1vuWPeD_hc/d-hio96ZAwAJ https://groups.google.com/forum/#!msg/mozilla.dev.platform/Y8kInYxo8UU/e3Pi-_FpBgAJ https://groups

NS_strdup() and nsMemory::Clone() have been renamed

Greetings, In bug 1486690 I renamed both variants of NS_strdup() as NS_xstrdup(). I also renamed nsMemory::Clone() as moz_xmemdup() and moved it into mozalloc. Rationale: - These functions are all infallible, and the 'x' prefix makes this clear, as per our allocator naming convention (e.g. moz_x