Re: Intent to ship: block audible autoplay media intervention

2018-07-05 Thread Chris Pearce
On Friday, July 6, 2018 at 3:10:58 AM UTC+12, Mounir Lamouri wrote: > On Wed, 4 Jul 2018, at 18:22, Chris Pearce wrote: > > Hi Mounir, > > > > Replies inline below... > > > > > > On Thu, Jul 5, 2018 at 2:56 AM, Mounir Lamouri wrote: > > > > > Hi Chris, > > > > > > Very excited to see Firefox g

Intent to unship: explicit values in image-orientation

2018-07-05 Thread Cameron McCormack
https://drafts.csswg.org/css-images-3/#the-image-orientation The CSS image-orientation property allows an author to control whether an image (in an or generated content) is automatically rotated and flipped according to the EXIF data in the image. Originally, the specification only allowed ex

Re: Update: Phabricator and commit series

2018-07-05 Thread Henrik Skupin
Mark Côté wrote on 03.07.18 21:34: > We’re aiming for late July for these implementations, which will allow us > to close down MozReview soon after, in time for the data center closure. What does that mean for not yet landed patches? Will there be a way to still retrieve the commit series after t

Re: Compile webrtc from source in firefox

2018-07-05 Thread Nils Ohlmeier
> On Jul 5, 2018, at 10:34, Jean-Yves Avenard wrote: > On 05/07/2018 10:17, amantell...@gmail.com wrote: >> Hi, >> I don't understand which webrtc code is used by firefox builder. >> I need to modify the webrtc part and recompile it to be used by firefox. >> any help? >> >> > > Firefox use its

Re: PSA: pay attention when setting multiple reviewers in Phabricator

2018-07-05 Thread James Graham
On 05/07/2018 18:19, Mark Côté wrote: I sympathize with the concerns here; however, changing the default would be a very invasive change to Phabricator, which would not only be complex to implement but troublesome to maintain, as we upgrade Phabricator every week or two. This is, however, som

Re: PSA: pay attention when setting multiple reviewers in Phabricator

2018-07-05 Thread Andreas Tolfsen
Also sprach Mark Côté: > On Thu, Jul 5, 2018 at 11:37 AM, Andreas Tolfsen wrote: > >> Also sprach Andrew Halberstadt: >> >>> It might be worth investigating whether we can switch Phabricator's >>> default (so that multiple reviews are all blocking, and to make >>> them non-blocking would requir

Re: Rust crate approval

2018-07-05 Thread Ted Mielczarek
On Sun, Jul 1, 2018, at 7:56 PM, Xidorn Quan wrote: > The point is that adding a new crate dependency is too easy > accidentally, and it is very possible for reviewers to overlook that. So > it may make sense to introduce a blacklist-ish thing to avoid that to > happen. FYI, we had some discuss

Re: Compile webrtc from source in firefox

2018-07-05 Thread Jean-Yves Avenard
On 05/07/2018 10:17, amantell...@gmail.com wrote: Hi, I don't understand which webrtc code is used by firefox builder. I need to modify the webrtc part and recompile it to be used by firefox. any help? Firefox use its own copy, the code is found in media/webrtc

Re: Intent to ship: block audible autoplay media intervention

2018-07-05 Thread Jean-Yves Avenard
Hi On 05/07/2018 17:10, Mounir Lamouri wrote: FWIW, WebKit uses the audio track availability and Blink intends to do this at some point. There are fundamental technical issues to resolve before this can be achieved. And at this stage, I'm not convinced it could ever be achieved, nor if th

Re: PSA: pay attention when setting multiple reviewers in Phabricator

2018-07-05 Thread Jean-Yves Avenard
Hi On 05/07/2018 19:19, Mark Côté wrote: This is, however, something we can address with our new custom commit-series-friendly command-line tool. We are also working towards the superior solution of automatically selecting reviewers based on module owners and peers and enforcing this in Lan

Re: open socket and read file inside Webrtc

2018-07-05 Thread Jean-Yves Avenard
Hi On 05/07/2018 10:16, amantell...@gmail.com wrote: I want to open a file inside webrtc core part. If you could extend the reasons on the why it would allow us to help you. What is your ultimate objective? why do you think you need to open a file inside webrtc core? Is it because you w

Re: open socket and read file inside Webrtc

2018-07-05 Thread Alex Gaynor
Can you describe in a bit more detail what you're trying to accomplish? As a general rule, the design of the sandbox is that the content process shouldn't/can't access any system resources, and any resource you need should be provided via IPC to the parent process. alex On Thu, Jul 5, 2018 at 11

Re: PSA: pay attention when setting multiple reviewers in Phabricator

2018-07-05 Thread Andreas Tolfsen
Also sprach Andrew Halberstadt: > It might be worth investigating whether we can switch Phabricator's > default (so that multiple reviews are all blocking, and to make > them non-blocking would require the extra step). I agree with Andrew. Making the default “everyone explicitly marked as review

Re: Update: Phabricator and commit series

2018-07-05 Thread Dão Gottwald
2018-07-03 21:34 GMT+02:00 Mark Côté : > We’re aiming for late July for these implementations, which will allow us > to close down MozReview soon after, in time for the data center closure. > What's going to happen to bugzilla attachments pointing to MozReview? Are we going to migrate the patche

Re: open socket and read file inside Webrtc

2018-07-05 Thread angelo mantellini
Alternatives? Il Mer 4 Lug 2018, 19:56 Eric Rescorla ha scritto: > On Wed, Jul 4, 2018 at 5:24 AM, wrote: > > > Hi, > > I'm very new with firefox (as developer, of course). > > I need to open a file and tcp sockets inside webrtc. > > I read the following link > > https://wiki.mozilla.org/Securi

Re: Rust crate approval

2018-07-05 Thread Henri Sivonen
On Wed, Jun 27, 2018 at 5:02 AM, Adam Gashlin wrote: > * Already vendored crates > Can I assume any crates we have already in mozilla-central are ok to use? Seems like a reasonable assumption. > * Updates > I need winapi 0.3.5 for BITS support, currently third_party/rust/winapi is > 0.3.4. There

Re: DNS Rebinding protection

2018-07-05 Thread Brannon Dorsey
> > First, I think downright denying "private IP addresses" from DNS responses > is very hard and is doomed to break the web experience for a set of users > who use private/local DNSes etc. > Yes, I concur. Lets not block them outright, but rather only in the instance that a domain name that prev

Update: Phabricator and commit series

2018-07-05 Thread Mark Côté
Hi all, After listening to feedback and discussing requirements with some of engineering leadership, the Engineering Workflow team has decided to write a new command-line application to better support submitting and updating commit series with Phabricator. We’ve been in touch with Phacility, and i

Re: PSA: pay attention when setting multiple reviewers in Phabricator

2018-07-05 Thread Andrew Halberstadt
It might be worth investigating whether we can switch Phabricator's default (so that multiple reviews are all blocking, and to make them non-blocking would require the extra step). Personally I think setting multiple reviewers up on a first come first serve is disrespectful to those reviewers' time

Re: Update: Phabricator and commit series

2018-07-05 Thread Mark Côté
Yup, patches will be archived. We have a plan for the migration that I will announce soonish (was intending on doing so earlier, but the commit-series work required some adjustments to the plan). Mark On Wed, Jul 4, 2018 at 6:11 AM, Dão Gottwald wrote: > 2018-07-03 21:34 GMT+02:00 Mark Côté :

Re: Intent to ship: block audible autoplay media intervention

2018-07-05 Thread Mounir Lamouri
On Wed, 4 Jul 2018, at 18:22, Chris Pearce wrote: > Hi Mounir, > > Replies inline below... > > > On Thu, Jul 5, 2018 at 2:56 AM, Mounir Lamouri wrote: > > > Hi Chris, > > > > Very excited to see Firefox going forward with autoplay blocking. A couple > > of comments inline. > > > > On Tue, 3 Ju

Re: Rust crate approval

2018-07-05 Thread Ehsan Akhgari
On Mon, Jul 2, 2018 at 4:05 PM, Lars Bergstrom wrote: > Cool! I was just worried, especially since hyper and tokio/mio are > *already* vendored in-tree (though openssl is not yet). It appears they're > used for network access in some test tools and an audio ipc server > prototype. So we're not ta

Re: open socket and read file inside Webrtc

2018-07-05 Thread amantellini
I want to open a file inside webrtc core part. Il giorno mercoledì 4 luglio 2018 21:53:22 UTC+2, Adam Roach ha scritto: > On 7/4/18 7:24 AM, amantell...@gmail.com wrote: > > Hi, > > I'm very new with firefox (as developer, of course). > > I need to open a file and tcp sockets inside webrtc. > > I

Compile webrtc from source in firefox

2018-07-05 Thread amantellini
Hi, I don't understand which webrtc code is used by firefox builder. I need to modify the webrtc part and recompile it to be used by firefox. any help? Angelo ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo