Re: Hash table iterators, and a call for help

2016-02-03 Thread Nicholas Nethercote
On Fri, Jul 24, 2015 at 11:26 AM, Nicholas Nethercote wrote: > > Given that, I went ahead and filed bugs to get rid of the ~200 > nsBaseHashtable::EnumerateRead() calls and ~140 > nsBaseHashtable::Enumerate() calls. They are all marked as blocking > https://bugzilla.mozilla.org/show_bug.cgi?id=118

Flash on Firefox Win64 runs on windowless mode only

2016-02-03 Thread Makoto Kato
Hi all. NPAPI on Firefox for Windows still supports both windowed mode and windowless mode. Since protected mode is unimplemented on Flash Win64, Firefox Win64 uses our sandbox (sandbox level = 2) for plugin process (Flash only). But this sandbox setting causes some issues on window mode (IME and

Web API / developer docs / dev. evangelism meeting Thursday at 8 AM PST

2016-02-03 Thread Eric Shepherd
The Web API documentation community meeting, with representatives from the technical evangelism and the API development teams, will take place on Thursday at 8 AM Pacific Time (see http://bit.ly/1GghwBR for your time zone). Typical meetings include news about recent API development progress an

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Mike Hommey
On Wed, Feb 03, 2016 at 10:41:03AM -0800, Bobby Holley wrote: > On Wed, Feb 3, 2016 at 10:32 AM, Ehsan Akhgari > wrote: > > > On 2016-02-03 12:50 PM, Martin Thomson wrote: > > > >> On Thu, Feb 4, 2016 at 2:21 AM, Milan Sreckovic > >> wrote: > >> > >>> 99.77% of the users on all channels have SSE

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Ehsan Akhgari
On 2016-02-03 1:41 PM, Bobby Holley wrote: On Wed, Feb 3, 2016 at 10:32 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 2016-02-03 12:50 PM, Martin Thomson wrote: On Thu, Feb 4, 2016 at 2:21 AM, Milan Sreckovic mailto:msrecko...@mozilla.com>> wrote:

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Bobby Holley
On Wed, Feb 3, 2016 at 10:32 AM, Ehsan Akhgari wrote: > On 2016-02-03 12:50 PM, Martin Thomson wrote: > >> On Thu, Feb 4, 2016 at 2:21 AM, Milan Sreckovic >> wrote: >> >>> 99.77% of the users on all channels have SSE2 support; >>> 51.7% of all users are on 32-bit Windows; >>> 0.44% of all users

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Ehsan Akhgari
On 2016-02-03 12:50 PM, Martin Thomson wrote: On Thu, Feb 4, 2016 at 2:21 AM, Milan Sreckovic wrote: 99.77% of the users on all channels have SSE2 support; 51.7% of all users are on 32-bit Windows; 0.44% of all users on 32-bit Windows do not have SSE2 support. Those numbers wouldn't justify a

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Martin Thomson
On Thu, Feb 4, 2016 at 2:21 AM, Milan Sreckovic wrote: > 99.77% of the users on all channels have SSE2 support; > 51.7% of all users are on 32-bit Windows; > 0.44% of all users on 32-bit Windows do not have SSE2 support. Those numbers wouldn't justify a change to me. When we make decisions about

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Ralph Giles
On Wed, Feb 3, 2016 at 5:23 AM, Henri Sivonen wrote: > My understanding is that the new > MP4 demuxer that's written in Rust is currently only being built in > the x86_64 case, so, AFAICT (I'd love to be wrong!), Rust code in > 32-bit Firefox isn't a solved problem yet. We're actually building i

Re: Touch events enabled on Windows desktop (nightly only)

2016-02-03 Thread Mike Taylor
On 2/3/16 9:46 AM, Kartikaya Gupta wrote: Thanks for the pointer to the metabug! I'll keep an eye on it and try to test those issues to see if they still happen. This was a major concern for me as well, which is why this is Nightly-only for now. Even if there are sites that are broken I definitel

Re: Touch events enabled on Windows desktop (nightly only)

2016-02-03 Thread Kartikaya Gupta
Thanks for the pointer to the metabug! I'll keep an eye on it and try to test those issues to see if they still happen. This was a major concern for me as well, which is why this is Nightly-only for now. Even if there are sites that are broken I definitely think we should push hard to get them fixe

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Milan Sreckovic
Right - I mentioned the number earlier, but let me summarize: 99.77% of the users on all channels have SSE2 support; 51.7% of all users are on 32-bit Windows; 0.44% of all users on 32-bit Windows do not have SSE2 support. — - Milan > On Feb 2, 2016, at 23:06 , Martin Thomson wrote: > > On We

Re: How to remove #ifdef XP_MACOSX in xul files?

2016-02-03 Thread Ehsan Akhgari
On 2016-02-03 4:03 AM, 罗勇刚(Yonggang Luo) wrote: If we have simple runtime directive to direct which part of XUL files should be exclude out , Like IE( There is no such thing, but you should be able to dynamically collapse the elements that you don't want in JS. __

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Chris H-C
So I reran the analysis, this time breaking down by OS the users who we can't say for certain have SSE2: https://gist.github.com/chutten/e4ccd0d5a46b782bae53 This was on a 25% sample of users reporting in from release Firefox on Jan 21. The tl;dr is that it's mostly WinXP. So much so that it's al

Re: Touch events enabled on Windows desktop (nightly only)

2016-02-03 Thread Jim Mathies
On Monday, February 1, 2016 at 11:50:44 AM UTC-6, Kartikaya Gupta wrote: > In bug 1180706 I turned on the dom.w3c_touch_events.enabled pref for > Windows desktop builds. This should be in Jan 31 nightly. For devices > that have touchscreens, this has two effects: The last time we turned this on it

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Ehsan Akhgari
On 2016-02-03 8:23 AM, Henri Sivonen wrote: For Rust code that doesn't explicitly try to use SSE2, are we going to use the default official rustc which emits SSE2-requiring code and, therefore, make Firefox require SSE2 on 32-bit x86? Or are we going to use rustc in a non-default configuration so

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Kurt Roeckx
On 2016-02-03 14:23, Henri Sivonen wrote: As for the consequences of requiring SSE2 unconditionally, I'm personally more worried about a conflict with Linux distros that don't already require SSE2 (even if near 100% of their users actually had SSE2-enabled hardware; this concern is not about the

Re: Does SSE2 usage still need to be conditional?

2016-02-03 Thread Henri Sivonen
On Fri, Jan 29, 2016 at 10:29 PM, Chris H-C wrote: > tl;dr - Around 99.5% of Firefox Desktop clients on release channel > represented by (a 20% sample of) pings submitted by on January 21, 2016 had > "hasSSE2" detected. > > Here's the analysis and results on github. Please feel free to check my >

Re: How to remove #ifdef XP_MACOSX in xul files?

2016-02-03 Thread Yonggang Luo
On Tue, Feb 2, 2016 at 9:08 PM, Gijs Kruitbosch wrote: > On 02/02/2016 12:36, Philip Chee wrote: > >> On 01/02/2016 18:17, Philipp Kewisch wrote: >> >>> You can use runtime checks for the OS, e.g. using Services.appinfo >>> >>> Philipp >>> >> >> Dude, he's talking about XUL, not JS. Please stop g

MozReview/Autoland in degraded state

2016-02-03 Thread Gregory Szorc
MozReview and Autoland are currently in a degraded state: * HTTP pushes are disabled * SSH pushes require LDAP SCM Level 3 access * Autoland is disabled * r+ carry forward has been disabled / the overall "status" column in the commits list may not turn green The last bullet point is particularly