Re: xulrunner 31, swt 4.5, ZOOM

2015-07-03 Thread James Cheng
昂鞥哦啊嗯嗯o鞥偶鞥/t身材一 2015年7月3日 下午3:30於 寫道: > Hi, > > I have an SWT application that uses a browser to display HTML pages. > Latest SWT 4.5 now support XulRunner v31, but something has changed: zoom > is not working anymore. It was working before with SWT 4.4 and XulRunner > v10. > > I have no experienc

Re: xulrunner 31, swt 4.5, ZOOM

2015-07-03 Thread smaug
On 07/03/2015 10:27 AM, mihai.slavcov...@gmail.com wrote: Hi, I have an SWT application that uses a browser to display HTML pages. Latest SWT 4.5 now support XulRunner v31, but something has changed: zoom is not working anymore. It was working before with SWT 4.4 and XulRunner v10. I have no

Fwd: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-03 Thread Michael Layzell
With regard to what #2 is doing, I threw the following into a file with nsRefPtr, and got clang to dump the AST: struct Foo {void AddRef() {} void Release() {}}; nsRefPtr bar; void foo() { Foo* x = true ? nullptr : bar; } `-FunctionDecl 0x103805750 line:943:6 foo 'void (void)' `-CompoundStmt

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-03 Thread Michael Layzell
On Fri, Jul 3, 2015 at 8:56 AM, Neil wrote: > Sure, but that won't stop someone from writing Arg foo = > ReturnFoo2(); will it? > > Something like that is fairly trivial for a static analysis system like our clang plugin to catch, if we want to create a type like that. Restricting certain types t

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-03 Thread Neil
Aryeh Gregor wrote: we still want a new type for function parameters that accepts implicit conversions from nsRefPtr/nsCOMPtr, to use instead of raw pointers. Sure, but that won't stop someone from writing Arg foo = ReturnFoo2(); will it? -- Warning: May contain traces of nuts.

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-03 Thread Neil
Nathan Froyd wrote: I guess we could fix this in current m-c to be smarter about the parameter passing, perhaps by declaring that ParameterStorage> is StoreCopyPassByConstLRef>? (Similarly for nsRefPtr.) So what's StorensRefPtrPassByPtr for? -- Warning: May contain traces of nuts.

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-03 Thread Aryeh Gregor
On Thu, Jul 2, 2015 at 3:50 PM, Neil wrote: > Would you mind reminding me what the failure case this avoids is? already_AddRefed ReturnFoo1() { nsRefPtr foo = new Foo(); return foo.forget(); } nsRefPtr ReturnFoo2() { return new Foo(); } // This doesn't compile Foo* foo = ReturnFoo1(); //

xulrunner 31, swt 4.5, ZOOM

2015-07-03 Thread mihai . slavcovici
Hi, I have an SWT application that uses a browser to display HTML pages. Latest SWT 4.5 now support XulRunner v31, but something has changed: zoom is not working anymore. It was working before with SWT 4.4 and XulRunner v10. I have no experience with XulRunner or XUL. Did something changed betw