Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Michael Layzell
The patches I am working on already use Bobby Holley's OriginAttributes, in fact we use the origin attribute on the nsIPrincipal, and only expose an nsIPrincipal from the API. Internally, we use the origin attribute for serialization, but to external consumers of the API, all that is available are

Re: Strange Error: Reentrancy error: some client, attempted to display a message to the console while in a console,listener

2015-06-30 Thread Robert Strong
I've only seen those when anything tries to print to the console after a test has called do_test_finish and in that case I suspect it is due to xpcshell shutting down, etc. Robert On Tue, Jun 30, 2015 at 11:35 PM, ishikawa wrote: > Hi, > > I am not sure where to ask and so ask three mailing lis

Re: Secure contexts required for new web platform features

2015-06-30 Thread Anne van Kesteren
On Tue, Jun 30, 2015 at 11:18 PM, Boris Zbarsky wrote: > On 6/30/15 5:00 PM, Richard Barnes wrote: >> Second, when we implement new web platform features, they will be enabled >> only on secure contexts. > > Might I ask who this "we" is (I don't recall general DOM module owner buy-in > on this, bu

Strange Error: Reentrancy error: some client,attempted to display a message to the console while in a console,listener

2015-06-30 Thread ishikawa
Hi, I am not sure where to ask and so ask three mailing lists. First off, TB 38.0.1 after many months of waiting solved many outstanding issues, Great. I hope we can correct many remaining issues in the months ahead. I am testing full debug build of C-C TB locally. This is done by running |make

Re: web-platform-tests on debug builds running on try

2015-06-30 Thread Hiroyuki Ikezoe
Hi! Just FYI The try result [1] shows only /html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html, but /service-workers/service-worker/fetch-csp.https.html is another suspicion. See https://treeherder.mozilla.org/logviewer.html#?job_id=8942921&repo=try and https://

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread Joshua Cranmer 🐧
On 6/30/2015 6:01 AM, Axel Hecht wrote: On 6/30/15 9:13 AM, Mike Hommey wrote: On Mon, Jun 29, 2015 at 11:19:08PM -0700, Nicholas Nethercote wrote: Hi, I'm wondering what the largest chunks of code there are in the codebase that are candidates for removal, i.e. probably with a bit of work but

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-06-30 Thread Joshua Cranmer 🐧
On 6/30/2015 4:35 PM, Jeff Muizelaar wrote: I believe this is predicated on removing the implicit conversion from nsRefPtr to T* You'd get the same benefit, I think, by making operator T*() && = delete;, syntax which is accepted on gcc 4.8.1+, clang, and MSVC 2015 IIRC. -- Joshua Cranmer Thu

Re: How create a full copy of mozbuild and dependencies at https://github.com/html-shell/mozbuild

2015-06-30 Thread Yonggang Luo
Well, the https://pypi.python.org/pypi/mozbuild is not enough to building mozilla source tree, that's why I created mozbuildfull package. The intention of mozbuildfull is to creating tags version of mozbuild that can building related version of mozilla source tree and distributed with XUL SDK, so

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Jonas Sicking
On Tue, Jun 30, 2015 at 5:50 PM, Jonas Sicking wrote: > On Tue, Jun 30, 2015 at 4:16 PM, Ehsan Akhgari > wrote: >> On 2015-06-30 6:04 PM, Jonas Sicking wrote: >>> >>> There are actually one downside with this change. >>> >>> It means that if a user denies access to https://website.com to use >>>

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Jonas Sicking
On Tue, Jun 30, 2015 at 3:55 PM, Martin Thomson wrote: > I wonder, has the subject of double-keying been raised in this > context? It comes up frequently in this context. And when I say > double-keying, I mean forming a key from the tuple of the requesting > principal and the top level browsing c

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Jonas Sicking
On Tue, Jun 30, 2015 at 4:16 PM, Ehsan Akhgari wrote: > On 2015-06-30 6:04 PM, Jonas Sicking wrote: >> >> There are actually one downside with this change. >> >> It means that if a user denies access to https://website.com to use >> cookies, then http://website.com will still have full ability to

web-platform-tests on debug builds running on try

2015-06-30 Thread James Graham
Web-platform-tests are now running in debug builds on try only. However due to some teething problems, they are not currently all green. This is expected to be fixed in the next 24 hours but, in the meantime, if you see some orange that seems unrelated to your change, particularly orange that l

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Martin Thomson
On Tue, Jun 30, 2015 at 4:18 PM, Ehsan Akhgari wrote: > I personally am not sure if that is a sound idea for all permission types. > It's probably the right thing for geolocation, but not for cookies. As I understand it, the key for permission manager is a simple string. Rather than make new APIs

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Ehsan Akhgari
On 2015-06-30 6:55 PM, Martin Thomson wrote: I wonder, has the subject of double-keying been raised in this context? It comes up frequently in this context. And when I say double-keying, I mean forming a key from the tuple of the requesting principal and the top level browsing context principal

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Ehsan Akhgari
On 2015-06-30 6:04 PM, Jonas Sicking wrote: There are actually one downside with this change. It means that if a user denies access to https://website.com to use cookies, then http://website.com will still have full ability to use cookies since it's a different origin. That is a good point. A

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Martin Thomson
I wonder, has the subject of double-keying been raised in this context? It comes up frequently in this context. And when I say double-keying, I mean forming a key from the tuple of the requesting principal and the top level browsing context principal (though origin may suffice). If there are disr

Re: Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Jonas Sicking
There are actually one downside with this change. It means that if a user denies access to https://website.com to use cookies, then http://website.com will still have full ability to use cookies since it's a different origin. For a DENY policy it often makes more sense to deny a whole domain name

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread David Zbarsky
On Tuesday, June 30, 2015 at 9:01:45 AM UTC-4, kgu...@mozilla.com wrote: > On Tuesday, June 30, 2015 at 3:41:43 AM UTC-4, Kearwood "Kip" Gilbert wrote: > > Would anyone be opposed to combining the Matrix4x4 class and gfx3DMatrix? > > Rather than adding support for transforms and projections that

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-06-30 Thread Jeff Muizelaar
I believe this is predicated on removing the implicit conversion from nsRefPtr to T* -Jeff On Tue, Jun 30, 2015 at 5:28 PM, Robert O'Callahan wrote: > Will it ever be possible to eliminate TemporaryRef and use moves instead? > > Rob > -- > oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oi

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-06-30 Thread Robert O'Callahan
Will it ever be possible to eliminate TemporaryRef and use moves instead? Rob -- oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo owoiotoho oao oboroootohoeoro oooro osoiosotoeoro owoiololo oboeo osouobojoeocoto otooo ojouodogomoeonoto.o oAogoaoiono,o oaonoyooonoeo owohooo

Re: Secure contexts required for new web platform features

2015-06-30 Thread Boris Zbarsky
On 6/30/15 5:00 PM, Richard Barnes wrote: Second, when we implement new web platform features, they will be enabled only on secure contexts. Might I ask who this "we" is (I don't recall general DOM module owner buy-in on this, but maybe I missed it?) what the definition of "new web platform f

Re: Intent to ship Notification API on Web Workers

2015-06-30 Thread smaug
yes, please! On 06/30/2015 06:46 AM, nsm.nik...@gmail.com wrote: Hello, Target release: Firefox 41 Implementation and shipping bug: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=916893 Specification: https://notifications.spec.whatwg.org/ Gecko already implements support for the Notif

Secure contexts required for new web platform features

2015-06-30 Thread Richard Barnes
As a next step toward deprecating non-secure HTTP [1], we are making the following two changes to how we develop new web platform features, effective immediately: First, when we work on developing specifications for new web platform features, we will make sure that these specifications require sec

mozilla::TemporaryRef is gone; please use already_AddRefed

2015-06-30 Thread Nathan Froyd
Bug 1161627 has landed on inbound, which converts all uses of mozilla::TemporaryRef to already_AddRefed and removes TemporaryRef. (already_AddRefed moved to MFBT several months ago, in case you were wondering about the spreading of XPCOM concepts.) TemporaryRef was added for easier porting of code

Intent to migrate the permissions database to use origins instead of host names

2015-06-30 Thread Ehsan Akhgari
Historically our permissions database has used host names as part of the permission entry, which means that if we stored a permission for http://example.com, it would also apply to https://example.com (and http://example.com:8080 for that matter). This is undesirable specially once you note that t

Re: How create a full copy of mozbuild and dependencies at https://github.com/html-shell/mozbuild

2015-06-30 Thread Gregory Szorc
The mozbuild Python package is available on PyPI: https://pypi.python.org/pypi/mozbuild It's also possible to obtain an archive of the source from hg.mozilla.org. See the instructions for the "archive" command/URL at https://hg.mozilla.org/mozilla-central/help/hgweb. I would strongly prefer to no

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread kgupta
On Tuesday, June 30, 2015 at 3:41:43 AM UTC-4, Kearwood "Kip" Gilbert wrote: > Would anyone be opposed to combining the Matrix4x4 class and gfx3DMatrix? > Rather than adding support for transforms and projections that involve > vertices behind the w=0 plane to gfx3DMatrix, it may be cleaner to r

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread Axel Hecht
On 6/30/15 9:13 AM, Mike Hommey wrote: On Mon, Jun 29, 2015 at 11:19:08PM -0700, Nicholas Nethercote wrote: Hi, I'm wondering what the largest chunks of code there are in the codebase that are candidates for removal, i.e. probably with a bit of work but not too much. One that comes to mind is

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread Kearwood "Kip" Gilbert
Would anyone be opposed to combining the Matrix4x4 class and gfx3DMatrix? Rather than adding support for transforms and projections that involve vertices behind the w=0 plane to gfx3DMatrix, it may be cleaner to refactor affected call-sites to use Matrix4x4 instead. The remaining references to

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread Bobby Holley
There's a bunch of XPConnect code that can go away when we finally kills nsDOMClassInfo. We're 95% of the way there, just lacking will to push it over the line. On Mon, Jun 29, 2015 at 11:19 PM, Nicholas Nethercote < n.netherc...@gmail.com> wrote: > Hi, > > I'm wondering what the largest chunks o

Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread Mike Hommey
On Mon, Jun 29, 2015 at 11:19:08PM -0700, Nicholas Nethercote wrote: > Hi, > > I'm wondering what the largest chunks of code there are in the > codebase that are candidates for removal, i.e. probably with a bit of > work but not too much. > > One that comes to mind is rdf/ (see > https://bugzilla