The OrangeFactor is now calculated per push

2015-05-15 Thread Jonathan Griffin
OrangeFactor [ http://brasstacks.mozilla.com/orangefactor/ ] now displays oranges/push; it used to display oranges/testrun. The definition of testrun was always a bit fuzzy, but was intended to compensate for the fact that some pushes will naturally have more oranges than others due to manual or p

Re: Replacing Mozmill driven tests for Firefox with Marionette

2015-05-15 Thread Henrik Skupin
Andrew Halberstadt wrote on 05/13/2015 04:24 PM: > I thought thunderbird was using a very out-of-date version of mozmill > which was already unmaintained anyway? Or did you already upgrade to the > latest version? Yes, its a very outdated version of Mozmill from the hotfix-1.5 branch, which we

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-15 Thread Dan Mosedale
Indeed, a good argument could be made that the old "quirks mode" years of the web were a strong example of the web suffering a lot while learning this very lesson (and modern web standardization processes work pretty hard to try and avoid it). Dan On Fri, May 15, 2015 at 9:47 AM, Martin Thomson

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-15 Thread Martin Thomson
On Thu, May 14, 2015 at 11:16 PM, Panos Astithas wrote: > This. From the perspective of a library method validating inputs, I've > always found it pays off to rely on Postel's principle. Sorry, that's a red flag for me. Postel was wrong. (Search for that phrase.) __

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-05-15 Thread Ehsan Akhgari
On 2015-05-13 10:03 AM, Benjamin Smedberg wrote: I think it's time I made an official decision here. I think Ehsan's proposal makes a lot of sense both as good engineering and because we know Google has already proved it for us. I approve. Ehsan, will you please make the necessary changes to our