Re: Documenting uses of Github at Mozilla

2014-10-06 Thread Karl Dubost
Mike, Le 1 oct. 2014 à 23:17, Mike Hoye a écrit : > Embracing the unknown sounds fun and easy, nope. not easy. Your email is the exact proof of that ;) and my answer too. > but we should keep in mind that services that we don't control - or as a > minimum have a contractual relationship with -

Re: Why does nsWindowMediator have a lock?

2014-10-06 Thread Neil
Josh Matthews wrote: As far as I can tell, nsWindowMediator::mListLock protects mOldestWindow and mTopmostWindow. However, the only direct users of nsWindowMediator are the enumerators in nsAppShellWindowEnumerator.cpp, and all uses of nsIWindowMediator that I could find appear to be in JS (i

Re: Using c++11 right angle bracket in template code?

2014-10-06 Thread Neil
Ehsan Akhgari wrote: The usage of the iterator object which can also store state allows you to check for that exact pattern, so arguably you won't lose anything using range-based for loops if we added a good iterator implementation to nsTArray that checks for mutations. If you need to check

Why does nsWindowMediator have a lock?

2014-10-06 Thread Josh Matthews
As far as I can tell, nsWindowMediator::mListLock protects mOldestWindow and mTopmostWindow. However, the only direct users of nsWindowMediator are the enumerators in nsAppShellWindowEnumerator.cpp, and all uses of nsIWindowMediator that I could find appear to be in JS (ie. on the main thread)

Re: Intent to implement: WOFF2 webfont format

2014-10-06 Thread Anne van Kesteren
On Mon, Oct 6, 2014 at 11:07 PM, Zack Weinberg wrote: > https://www.owlfolio.org/htmletc/strawman-mime-type-for-fonts/ back in 2011. I tried fixing this together with Håkon back in 2008: https://annevankesteren.nl/2008/08/font-mime-types We couldn't get agreement with the IETF fast enough so ins

Re: Intent to implement: WOFF2 webfont format

2014-10-06 Thread Zack Weinberg
On 2014-10-03 4:37 AM, Jonathan Kew wrote: it seems we fetch fonts using Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 which doesn't look even remotely sensible. Agree, but note that there are no official MIME types for most font formats. (I *think* application/

Re: Using c++11 right angle bracket in template code?

2014-10-06 Thread Ehsan Akhgari
On 2014-10-06, 11:20 AM, Trevor Saunders wrote: Hence, I suggest for cases like this, |auto| should be a recommendation. IIRC, it is one of the cases that |auto| was introduced for. For cases like: for (int32_t i = 0; i < array.Length(); i++) I even want to write it as for (decltype(array.

Re: c++ unit test in content process

2014-10-06 Thread Patrick Wang
I see. I'll try to write with a more end-to-end test framework then. Thank you. Patrick On 10/3/14 9:59 PM, Benjamin Smedberg wrote: > > On 10/3/2014 9:46 AM, Patrick Wang wrote: >> The test I am writing is to test an implementation of WebRTC's TCP >> socket in content process. These codes are b

Re: Documenting uses of Github at Mozilla

2014-10-06 Thread Tantek Çelik
Since all these repo links are likely to become unfindable in email... Contributions welcome: https://wiki.mozilla.org/Github Thanks, Tantek On Thu, Oct 2, 2014 at 12:46 PM, Mike Hoye wrote: > On 2014-10-01 12:16 PM, Ehsan Akhgari wrote: >> >> On 2014-10-01, 11:59 AM, Ralph Giles wrote: >>> >

Re: c++ unit test in content process

2014-10-06 Thread Kyle Huey
On Mon, Oct 6, 2014 at 8:21 AM, Jason Orendorff wrote: > That said, if you see ways to improve the situation, go strong. The reason > we have tests and a testing culture here at all is herculean efforts from > Rob Sayre and others who saw what needed doing and did it. srsly. That guy rocked. -

Re: c++ unit test in content process

2014-10-06 Thread Milan Sreckovic
And as “bad” as it is, it’s as good as it gets, and it will only get worse - unless we continue the efforts to make things better. Sometimes it’s a long haul, and you can’t get the approval to spend a lot of time digging out of some places, but often even small things help. -- - Milan On Oct

Re: Using c++11 right angle bracket in template code?

2014-10-06 Thread Neil
Trevor Saunders wrote: for (auto l = tarray.Length() - 1; l < tarray.Length(); l--) Which is how you'd iterate backwards over a non empty array. for (auto l = tarray.Length(); l-- > 0; ) -- Warning: May contain traces of nuts. ___ dev-platform mail

Re: c++ unit test in content process

2014-10-06 Thread Jason Orendorff
On 10/03/2014 08:59 AM, Benjamin Smedberg wrote: On 10/3/2014 9:46 AM, Patrick Wang wrote: The test I am writing is to test an implementation of WebRTC's TCP socket in content process. These codes are build on top of TCPSocket's IPDL in C++ and don't have IDL so it cannot be called directly fro

Re: Using c++11 right angle bracket in template code?

2014-10-06 Thread Trevor Saunders
On Thu, Oct 02, 2014 at 01:58:52PM -0400, Ehsan Akhgari wrote: > On 2014-10-02, 1:14 AM, Xidorn Quan wrote: > >On Wed, Oct 1, 2014 at 6:27 PM, Ehsan Akhgari >> wrote: > > > >On 2014-10-01, 7:42 PM, L. David Baron wrote: > > > >On Wednesday 2014-10-01 16:

Re: Enabling NSPR logging in release builds

2014-10-06 Thread Gabriele Svelto
On 06/10/2014 14:59, Milan Sreckovic wrote: > Any noticable impact on the binary code size? From the bug: no logging logging % change compressed linux64 tarball 52,118,232 52,194,342 0.15% uncompressed linux64 tarball121,528,320 1

Re: Enabling NSPR logging in release builds

2014-10-06 Thread Milan Sreckovic
Any noticable impact on the binary code size? -- - Milan On Oct 3, 2014, at 16:12 , Eric Rahm wrote: > Hi all- > > In bug 806819 we're planning on landing a change that allows us to turn on > NSPR logging in release builds [1]. To be clear, by default all logging > output is disabled, this wi

Re: Xulrunner standalone application auto update stopped working

2014-10-06 Thread Neil
Manish wrote: Also we came across this error on console: Error: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName] Source File: XStringBundle Line: 21 If you had a debug build you could try setting a breakpoint here: http://