Upcoming mass conversion of PRUnichar to char16_t

2014-01-02 Thread Ehsan Akhgari
Hi everyone, I just attached some patches to replace PRUnichar with char16_t to bug 927728. I'm planning to land these patches this weekend or early next week. You can find a script in bug 927728 to help unbitrot your mq patches. When I'm ready to land this I will close m-c/inbound/b2g-inbound/

Re: On the usefulness of style guides (Was: style guide proposal)

2014-01-02 Thread Nicholas Nethercote
On Thu, Jan 2, 2014 at 1:44 PM, Ehsan Akhgari wrote: >> >> The sad part is JS used to be C. Its idiosyncratic C++ rules could have >> been inherited from Gecko instead. > > FWIW this is the earliest version of the SpiderMonkey coding style document > that I can find, dating back to 2006: >

Re: On the usefulness of style guides (Was: style guide proposal)

2014-01-02 Thread Ehsan Akhgari
On 12/25/2013, 4:46 PM, Mike Hommey wrote: On Wed, Dec 25, 2013 at 10:00:33PM +1300, Robert O'Callahan wrote: The JS engine has always been a problem when trying to enforce consistent standards across Gecko. Part of that comes from it being viewed as an independent product, much more so than any

Re: Should we build a new in-process unwind library?

2014-01-02 Thread Jim Chen
This is great! Thanks for working on it! Can the new library be used independently outside of SPS? For hang detection (bug 909974) we'd like to have the ability to unwind the hung thread's stack, and this library would be perfect for that. Cheers, Jim On 12/19/13 2:04 PM, Julian Seward wrote: >