Re: An object that corresponds to the life of a document load?

2012-10-01 Thread Henri Sivonen
On Mon, Oct 1, 2012 at 5:25 PM, Henri Sivonen wrote: > Do we have an object that represents the life of a document load from > the very beginning of deciding to load a URL in a browsing context to > the firing of the load event? So we don't have this. I'm wondering how feasible it would be to mov

Re: try: -p all considered harmful?

2012-10-01 Thread Justin Lebar
> For example, suppose > > * we land W, X, Y, and Z all in a row within 10 minutes or so, > * csets W and X have try runs and csets Y and Z do not, and > * we have capacity for two builds > > then I'd rather get builds for [WX and YZ] than for [W and XYZ]. Erm, I mean that I'd rather get [WXY,

Re: try: -p all considered harmful?

2012-10-01 Thread Justin Lebar
> For case 1., an idea that has been floated here and again (in Automation and > Tools and Release Engineering, anyway) is landing directly from try -> > inbound (or central) for green try pushes. However, this isn't a small > endeavor, both for the reasons of building the infra + software to do th

Re: try: -p all considered harmful?

2012-10-01 Thread Justin Dolske
On 10/1/12 1:10 PM, Ehsan Akhgari wrote: Perhaps we could find some quick load reductions by coalescing pushes that have had successful try runs. EG, If 20 changesets have successfully had try runs, doing 20 more (full!) runs on mozilla-inbound is wasteful. For example: We could create a mozill

Re: try: -p all considered harmful?

2012-10-01 Thread Ryan VanderMeulen
FWIW, I'm torn on this topic as a sheriff who has often had to wade through the fallout of poorly-tested patches (I've landed a few myself too!). It can be a massive pain when we're in periods of heavy load with a lot of coalescing going on. It can lead to very long periods of tree closure whil

Re: Proposal to remove support for the -t all trychooser syntax

2012-10-01 Thread Jeff Hammel
On 10/01/2012 04:32 PM, Ehsan Akhgari wrote: Over in bug 796087, I'm proposing for us to remove the -t all try server flag. The rationale is that the set of Talos tests vary greatly and most of the people who test performance are only interested in a subset of Talos tests. So I'm suggesting tha

Proposal to remove support for the -t all trychooser syntax

2012-10-01 Thread Ehsan Akhgari
Over in bug 796087, I'm proposing for us to remove the -t all try server flag. The rationale is that the set of Talos tests vary greatly and most of the people who test performance are only interested in a subset of Talos tests. So I'm suggesting that we should disallow -t all as it is a very eas

Re: NS_New$THING vs. new $THING

2012-10-01 Thread Nathan Froyd
- Original Message - > Ehsan Akhgari wrote: > > There might be times where you want the concrete type of the thing > > that your ctor function returns to be opaque, in which case it > > might > > make sense to go with the NS_NewFoo style of method. > > That might even apply here, since my

Re: NS_New$THING vs. new $THING

2012-10-01 Thread Neil
Ehsan Akhgari wrote: There might be times where you want the concrete type of the thing that your ctor function returns to be opaque, in which case it might make sense to go with the NS_NewFoo style of method. That might even apply here, since my understanding was that mutable arrays need to

MemShrink meeting Tuesday 10/02/2012 @ 4:00pm PDT

2012-10-01 Thread Jet Villegas
Tomorrow's MemShrink meeting will be brought to you by the BananaBread browser benchmarks: https://github.com/kripken/misc-js-benchmarks/tree/master/banana The wiki page for this meeting is at: https://wiki.mozilla.org/Performance/MemShrink Agenda: * Prioritize unprioritized MemShrink bugs.

Re: try: -p all considered harmful?

2012-10-01 Thread Ehsan Akhgari
On 2012-09-29 10:54 PM, Justin Dolske wrote: On 9/29/12 1:14 PM, Justin Lebar wrote: As part of this debate, I calculated that for patches with a reasonable chance of success, pushing to m-i and failing actually saves resources. Hmm. Veering off on a bit of a tangent... Perhaps we could find

Re: try: -p all considered harmful?

2012-10-01 Thread Ehsan Akhgari
On 2012-10-01 4:03 PM, Kyle Huey wrote: On Mon, Oct 1, 2012 at 1:01 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 2012-09-30 2:47 AM, Justin Lebar wrote: Unfortunately, due to https://bugzilla.mozilla.org/__show_bug.cgi?id=767501

Re: try: -p all considered harmful?

2012-10-01 Thread Kyle Huey
On Mon, Oct 1, 2012 at 1:01 PM, Ehsan Akhgari wrote: > On 2012-09-30 2:47 AM, Justin Lebar wrote: > >> Unfortunately, due to https://bugzilla.mozilla.org/** show_bug.cgi?id=767501 , the only way to get b2g builds on try is to use

Re: try: -p all considered harmful?

2012-10-01 Thread Ehsan Akhgari
On 2012-09-30 2:47 AM, Justin Lebar wrote: Unfortunately, due to https://bugzilla.mozilla.org/show_bug.cgi?id=767501, the only way to get b2g builds on try is to use '-p all'. Sounds like that should be a P1 for reducing load then. Much-to-most of this "B2G-only" code compiles on other platf

Re: NS_New$THING vs. new $THING

2012-10-01 Thread Kyle Huey
On Mon, Oct 1, 2012 at 12:30 PM, Ehsan Akhgari wrote: > On 2012-10-01 12:27 PM, Nathan Froyd wrote: > >> I recently filed a bug (bug 792169) for adding NS_NewIMutableArray, in >> service of deleting nsISupportsArray. The reviewer asked me to use >> more standard C++ instead of perpetuating the NS

Re: NS_New$THING vs. new $THING

2012-10-01 Thread Ehsan Akhgari
On 2012-10-01 12:27 PM, Nathan Froyd wrote: I recently filed a bug (bug 792169) for adding NS_NewIMutableArray, in service of deleting nsISupportsArray. The reviewer asked me to use more standard C++ instead of perpetuating the NS_New* idiom and I did so, with a static |Create| member function.

Extending jar.mn to support cross-module overrides

2012-10-01 Thread Axel Hecht
Hi, for both android and b2g, we end up only needing a handful of localized files from toolkit. I propose to extend JarMaker.py and jar.mn to support something like a fake relativesrcdir, say @relativesrcdir toolkit/locales and then the following lines would pick up files from toolkit/loca

Re: New branches in the git mirror

2012-10-01 Thread Ehsan Akhgari
Just as a quick update, as of yesterday people asked me to add two more branches: * services (following the services-central hg repository) * alder (following the Alder project branch where the WebRTC work is happening) Cheers, -- Ehsan On Sun, Sep 30, 2012 at 1:46 PM

Re: try: -p all considered harmful?

2012-10-01 Thread Jeff Hammel
On 09/28/2012 09:58 PM, Kannan Vijayan wrote: On 12-09-28 10:03 PM, Seth Fowler wrote: On Sep 28, 2012, at 6:28 PM, Boris Zbarsky wrote: The point is that the patches that _do_ need to land urgently are blocked on lack of resources because people are wasting too many cycles with unnecesary t

NS_New$THING vs. new $THING

2012-10-01 Thread Nathan Froyd
I recently filed a bug (bug 792169) for adding NS_NewIMutableArray, in service of deleting nsISupportsArray. The reviewer asked me to use more standard C++ instead of perpetuating the NS_New* idiom and I did so, with a static |Create| member function. However, looking through other code--especial

An object that corresponds to the life of a document load?

2012-10-01 Thread Henri Sivonen
Do we have an object that represents the life of a document load from the very beginning of deciding to load a URL in a browsing context to the firing of the load event? nsIChannel/nsIRequest is not it, because it only lasts until the end of the network stream after which point there's still time

Re: try: -p all considered harmful?

2012-10-01 Thread Chris AtLee
On 30/09/12 03:43 AM, Justin Lebar wrote: We're all trying to build the best system we can here. We've been publishing as much raw data as we can, as well as reports like wait time data for ages. We're not trying to hide this stuff away. I understand. My point is just that the data we currentl

Re: New branches in the git mirror

2012-10-01 Thread Ehsan Akhgari
On 2012-09-30 8:27 PM, Mike Ratcliffe wrote: Thanks, that is excellent! How often are these updated. I have set them up to get updated every minute now. Previously, inbound was updated every minute and the other branches every half an hour. Cheers, Ehsan __

Re: try: -p all considered harmful?

2012-10-01 Thread Ben Hearsum
On 09/29/12 12:58 AM, Kannan Vijayan wrote: > 1. A patch that is expected to succeed, but you want to run it through > try to verify. > For "optimistic" pushes, we expect that the patch goes from green => > green. For "pessimistic" pushes we expect a listing of all oranges that > arise from that

Re: try: -p all considered harmful?

2012-10-01 Thread Ben Hearsum
On 09/28/12 08:32 PM, Chris Pearce wrote: > If Try is hogging resources needed by Inbound, we should lower the > priority of Try. Try is already a lower priority than Inbound (and almost everything else). Those values are defined here: https://github.com/mozilla/build-buildbot-configs/blob/master/

Re: try: -p all considered harmful?

2012-10-01 Thread Ben Hearsum
On 09/29/12 03:12 PM, Mike Hommey wrote: > I'm not sure this is still the case, but something i noticed is that > cancelling windows builds actually doesn't cancel them until the current > step they are doing is finished. This happened when we switched to 64-bit Windows build machines. https://bug