Re: Proposal to remove the function timer code

2012-09-18 Thread Taras Glek
On 9/19/2012 7:04 AM, Ehsan Akhgari wrote: A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instrumented a whole bunch of code which was triggered throughout

Re: Adding hardware tokens to UA string

2012-09-18 Thread Henri Sivonen
On Tue, Sep 18, 2012 at 7:59 PM, Jonas Sicking wrote: > On Tue, Sep 18, 2012 at 3:30 AM, Henri Sivonen wrote: >> FWIW, when preferential content access is tied to ISP instead of >> hardware brand, Mozilla has gone as far as sending letters to D.C. >> against such tying. (Yes, preferred access by

Re: Proposal to remove the function timer code

2012-09-18 Thread L. David Baron
On Wednesday 2012-09-19 00:04 -0400, Ehsan Akhgari wrote: > A while ago (I think more than a couple of years ago now), Vlad > implemented FunctionTimer which is a facility to time how much each > function exactly takes to run. Then, I went ahead and instrumented > a whole bunch of code which was t

Proposal to remove the function timer code

2012-09-18 Thread Ehsan Akhgari
A while ago (I think more than a couple of years ago now), Vlad implemented FunctionTimer which is a facility to time how much each function exactly takes to run. Then, I went ahead and instrumented a whole bunch of code which was triggered throughout our startup path to get a sense of what th

Re: Adding hardware tokens to UA string

2012-09-18 Thread Justin Dolske
On 9/18/12 1:37 AM, Jonas Sicking wrote: I think this is the worst abuse of a UA string I've ever heard of. Actually, I would say this is one of the stronger use cases that I've seen for UA sniffing. ... So it seems to me that not putting hardware tokens in the UA string effectively disables

Re: Request for reviewers and super-reviewers to require more in-code documentation of new code

2012-09-18 Thread Joshua Cranmer
On 9/18/2012 11:58 AM, Gregory Szorc wrote: grep is not a suitable discovery mechanism for casual developers. What they want is a categorized list. Something like [1]. And, this should be easily accessible. |make documentation| doesn't count because it requires obtaining a source tree. We shoul

Re: Adding hardware tokens to UA string

2012-09-18 Thread Robert Kaiser
Jonas Sicking schrieb: For Firefox OS, we are getting requests from partners to add tokens to the UA string which identify the hardware device on which Firefox OS is running. I think using the UA is surely the wrong place for this. If we allow the models that want to be achieved with this at a

Re: Adding hardware tokens to UA string

2012-09-18 Thread Jonas Sicking
On Tue, Sep 18, 2012 at 3:30 AM, Henri Sivonen wrote: > On Tue, Sep 18, 2012 at 11:37 AM, Jonas Sicking wrote: >> Say that HTC wants to >> market their phones towards soccer enthusiasts. They could do this by >> paying the local soccer league access to a set of games which will be >> streamed fro

Re: Request for reviewers and super-reviewers to require more in-code documentation of new code

2012-09-18 Thread Gregory Szorc
On 9/17/12 10:40 AM, Justin Lebar wrote: Many believe that MDN should be where user-facing API documentation lives. Who's the user here? Add-on developers, Gecko developers, or something else? It sounds like maybe you mean Gecko developers? I really don't think the task of Gecko developers,

Re: Adding hardware tokens to UA string

2012-09-18 Thread Robert Kaiser
Mike Hommey schrieb: On Tue, Sep 18, 2012 at 01:17:16PM +0300, Henri Sivonen wrote: (Remember Web sites in the 1990s that blocked access from browsers that the authors hadn't tested. Those were not cool.) Such sites still exist, and they still aren't cool. Right, just nowadays Firefox is usu

Re: "Touch" or "Tablet"?

2012-09-18 Thread Asa Dotzler
On 8/2/2012 6:32 AM, Gervase Markham wrote: http://blogs.msdn.com/b/ie/archive/2012/07/12/ie10-user-agent-string-update.aspx IE10 has introduced the Touch token to the UA string, which overlaps in intent with our Tablet token. Dao suggests it would be nice to get cross-browser consistency here.

Re: Adding hardware tokens to UA string

2012-09-18 Thread Gervase Markham
On 18/09/12 09:48, Jonas Sicking wrote: I don't think there's a "good detection practice" for detecting what hardware the user is running. So either: 1) we need to invent one; or 2) we think that there is no legitimate use for the information (or perhaps that there are a small number, but th

Re: Adding hardware tokens to UA string

2012-09-18 Thread Gervase Markham
On 18/09/12 09:37, Jonas Sicking wrote: So it seems to me that not putting hardware tokens in the UA string effectively disables this business model. I'm not sure that's true. Having no way to detect the underlying hardware platform effectively disables this business model - or perhaps, "busi

Re: Adding hardware tokens to UA string

2012-09-18 Thread Mike Hommey
On Tue, Sep 18, 2012 at 01:17:16PM +0300, Henri Sivonen wrote: > On Thu, Sep 13, 2012 at 9:27 AM, Jonas Sicking wrote: > > * App stores only want to deliver applications to devices which they > > know will run on the device. > > This would make sense in an Apple-esque walled garden with relativel

Re: Adding hardware tokens to UA string

2012-09-18 Thread Henri Sivonen
On Tue, Sep 18, 2012 at 11:37 AM, Jonas Sicking wrote: > Say that HTC wants to > market their phones towards soccer enthusiasts. They could do this by > paying the local soccer league access to a set of games which will be > streamed from HTCs website. ... > I can't say that I hold this business m

Re: Adding hardware tokens to UA string

2012-09-18 Thread Henri Sivonen
On Thu, Sep 13, 2012 at 9:27 AM, Jonas Sicking wrote: > * App stores only want to deliver applications to devices which they > know will run on the device. This would make sense in an Apple-esque walled garden with relatively few different device models. However, if Mozilla's app initiative is su

Re: Adding hardware tokens to UA string

2012-09-18 Thread Henri Sivonen
On Thu, Sep 13, 2012 at 12:20 PM, Dirkjan Ochtman wrote: > Since Firefox OS is openly accessible to hardware vendors, wouldn't it > be easy for them to override any decision made by Mozilla if they or > their content partners would prefer it that way? The code is available, but it doesn't follow

Re: Adding hardware tokens to UA string

2012-09-18 Thread Henri Sivonen
On Thu, Sep 13, 2012 at 9:27 AM, Jonas Sicking wrote: > For Firefox OS, we are getting requests from partners to add tokens to > the UA string which identify the hardware device on which Firefox OS > is running. We already had this debate for Firefox for Android. I think we should apply the same

Re: Adding hardware tokens to UA string

2012-09-18 Thread Jonas Sicking
On Thu, Sep 13, 2012 at 7:21 AM, Gervase Markham wrote: > On 13/09/12 07:27, Jonas Sicking wrote: >> >> * Some content providers strike deals with hardware manufacturers >> which allow devices made by the manufacturer to access content for >> free. One way that this is implemented is by looking fo

Re: Adding hardware tokens to UA string

2012-09-18 Thread Jonas Sicking
On Thu, Sep 13, 2012 at 2:49 AM, Nicholas Nethercote wrote: > On Thu, Sep 13, 2012 at 4:27 PM, Jonas Sicking wrote: >> >> * Some content providers strike deals with hardware manufacturers >> which allow devices made by the manufacturer to access content for >> free. One way that this is implement