Re: 0d3789584915 - main - ctl: use socket buffer mutexes in struct socket directly

2024-05-23 Thread Ravi Pokala
Hi Gleb, Isn't this the exact opposite of the summary? This change *doesn't* use the mutexes directly, it uses the wrappers to *avoid* using the mutexes directly. Thanks, Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Gleb Smirnoff mai

Re: 3781e77995e9 - main - riscv: actually enable sanitizers

2022-03-13 Thread Ravi Pokala
-Original Message- From: Piotr Kubaj Date: 2022-03-13, Sunday at 15:39 To: Ravi Pokala Cc: "src-committ...@freebsd.org" , "dev-commits-src-...@freebsd.org" , "dev-commits-src-main@FreeBSD.org" Subject: Re: 3781e77995e9 - main - riscv: actually enable san

Re: 868c1b8431f2 - main - fstyp: detect Raspberry Pi Pico boot filesystem as FAT

2022-03-29 Thread Ravi Pokala
"0x55 0xaa" at offset 510 is the signature for a (P)MBR partition table, not a FAT filesystem. -Ravi (rpokala@) -Original Message- From: on behalf of Ed Maste Date: 2022-03-29, Tuesday at 14:33 To: , , Subject: git: 868c1b8431f2 - main - fstyp: detect Raspberry Pi Pico boot filesy

Re: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd.

2022-04-07 Thread Ravi Pokala
-Original Message- From: on behalf of John Baldwin Date: 2022-04-07, Thursday at 17:03 To: , , Subject: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd. The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=885

Re: 214df80a9cb3 - main - nvme: new define for size of host memory buffer sizes

2022-04-09 Thread Ravi Pokala
-Original Message- From: on behalf of Warner Losh Date: 2022-04-08, Friday at 22:06 To: , , Subject: git: 214df80a9cb3 - main - nvme: new define for size of host memory buffer sizes The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=214df8

Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around

2022-04-12 Thread Ravi Pokala
-Original Message- From: on behalf of Kyle Evans Date: 2022-04-12, Tuesday at 17:34 To: , , Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() printing around The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45

Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around

2022-04-12 Thread Ravi Pokala
-Original Message- From: Kyle Evans Date: 2022-04-12, Tuesday at 18:04 To: Ravi Pokala Cc: src-committers , "" , Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala wrote: > > -

Re: 214df80a9cb3 - main - nvme: new define for size of host memory buffer sizes

2022-04-13 Thread Ravi Pokala
-Original Message- From: on behalf of John Baldwin Date: 2022-04-13, Wednesday at 10:05 To: , Warner Losh Cc: Ravi Pokala , Warner Losh , src-committers , , Subject: Re: 214df80a9cb3 - main - nvme: new define for size of host memory buffer sizes On 4/11/22 10:13 AM, Rodney W

git: 00a80538b447 - main - lacp: short timeout erroneously declares link-flapping

2022-04-27 Thread Ravi Pokala
The branch main has been updated by rpokala: URL: https://cgit.FreeBSD.org/src/commit/?id=00a80538b4471b2978c5a1990f48189f2c692e24 commit 00a80538b4471b2978c5a1990f48189f2c692e24 Author: Greg Foster AuthorDate: 2022-04-26 06:38:23 + Commit: Ravi Pokala CommitDate: 2022-04-27 19:41

Re: 0b6bacc7874f - main - Add ofw_bus_iommu_map() that maps PCI requester ID to an IOMMU specifier based on "iommu-map" DTS property.

2022-05-06 Thread Ravi Pokala
-Original Message- From: on behalf of Ruslan Bukin Date: 2022-05-06, Friday at 08:51 To: , , Subject: git: 0b6bacc7874f - main - Add ofw_bus_iommu_map() that maps PCI requester ID to an IOMMU specifier based on "iommu-map" DTS property. The branch main has been updated by br:

Re: d021434a7960 - main - openzfs: fix gcc kernel module builds

2021-01-01 Thread Ravi Pokala
-Original Message- From: on behalf of Ryan Libby Date: 2020-12-27, Sunday at 15:03 To: , , Subject: git: d021434a7960 - main - openzfs: fix gcc kernel module builds The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=d021434a796008efbb936

Re: d021434a7960 - main - openzfs: fix gcc kernel module builds

2021-01-02 Thread Ravi Pokala
-Original Message- From: Ryan Libby Date: 2021-01-01, Friday at 17:10 To: Ravi Pokala Cc: src-committers , , Subject: Re: d021434a7960 - main - openzfs: fix gcc kernel module builds On Fri, Jan 1, 2021 at 3:42 PM Ravi Pokala wrote: > > -Original M

Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern.

2021-01-07 Thread Ravi Pokala
-Original Message- From: on behalf of Vladimir Kondratyev Date: 2021-01-07, Thursday at 15:33 To: Jessica Clarke , Vladimir Kondratyev Cc: "src-committ...@freebsd.org" , "dev-commits-src-...@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 92cf602e3809 - main - Cop

Re: 936440560bde - main - sysctl: implement debug.kdb.panic_str

2021-01-08 Thread Ravi Pokala
-Original Message- From: on behalf of Warner Losh Date: 2021-01-08, Friday at 13:31 To: , , Subject: git: 936440560bde - main - sysctl: implement debug.kdb.panic_str The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=936440560bde54050e1ad9d

Re: aef769614f92 - main - pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases

2021-01-14 Thread Ravi Pokala
-Original Message- From: on behalf of Kyle Evans Date: 2021-01-14, Thursday at 07:58 To: Emmanuel Vadot Cc: Kyle Evans , Renato Botelho , src-committers , , Subject: Re: git: aef769614f92 - main - pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases On Th

Re: ad1ebbe5cea8 - main - loader: create local copy of mode list provided by vbeinfoblock

2021-01-18 Thread Ravi Pokala
Hi Toomas, -Original Message- From: on behalf of Toomas Soome Date: 2021-01-16, Saturday at 00:23 To: , , Subject: git: ad1ebbe5cea8 - main - loader: create local copy of mode list provided by vbeinfoblock The branch main has been updated by tsoome: URL: https://cgit.Free

git: bdde49b7c723 - main - nvdimm(4): Export NVDIMM health flags via sysctl

2021-02-18 Thread Ravi Pokala
The branch main has been updated by rpokala: URL: https://cgit.FreeBSD.org/src/commit/?id=bdde49b7c7232c6936525f84ffb90856a7cd8e74 commit bdde49b7c7232c6936525f84ffb90856a7cd8e74 Author: Ravi Pokala AuthorDate: 2021-02-16 08:03:32 + Commit: Ravi Pokala CommitDate: 2021-02-18 23:08

Re: ba27dd8be821 - main - zfs: merge OpenZFS master-9312e0fd1

2021-02-22 Thread Ravi Pokala
-Original Message- From: on behalf of Martin Matuska Date: 2021-02-22, Monday at 04:02 To: , , Subject: git: ba27dd8be821 - main - zfs: merge OpenZFS master-9312e0fd1 The branch main has been updated by mm: URL: https://cgit.FreeBSD.org/src/commit/?id=ba27dd8be821792e15bdabf

Re: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template

2021-02-22 Thread Ravi Pokala
-Original Message- From: on behalf of Ed Maste Date: 2021-02-22, Monday at 07:31 To: , , Subject: git: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=aa

Re: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template

2021-02-22 Thread Ravi Pokala
-Original Message- From: Ravi Pokala Date: 2021-02-22, Monday at 10:48 To: Ed Maste , , , Subject: Re: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template -Original Message- From: on behalf of Ed Maste Date: 2021-02-22, Mo

Re: 8a272653d9fb - main - stress2: Initial import

2021-03-04 Thread Ravi Pokala
-Original Message- From: on behalf of Peter Holm Date: 2021-03-03, Wednesday at 06:12 To: , , Subject: git: 8a272653d9fb - main - stress2: Initial import The branch main has been updated by pho: URL: https://cgit.FreeBSD.org/src/commit/?id=8a272653d9fbd9fc37691c9aad6a05089b

Re: 895a22583df2 - main - [PowerPC] Fix ISA_206 subword atomics

2021-03-30 Thread Ravi Pokala
-Original Message- From: on behalf of Brandon Bergren Date: 2021-03-30, Tuesday at 18:28 To: Brandon Bergren , , , Subject: Re: git: 895a22583df2 - main - [PowerPC] Fix ISA_206 subword atomics On Tue, Mar 30, 2021, at 8:23 PM, Brandon Bergren wrote: > The branch main has been

Re: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9)

2021-04-26 Thread Ravi Pokala
-Original Message- From: on behalf of Baptiste Daroussin Date: 2021-04-26, Monday at 20:09 To: , , Subject: git: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9) The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=0cd4b781a

Re: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9)

2021-04-27 Thread Ravi Pokala
-Original Message- From: Baptiste Daroussin Date: 2021-04-27, Tuesday at 00:05 To: Ravi Pokala Cc: , , Subject: Re: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9) On Mon, Apr 26, 2021 at 09:13:53PM -0700, Ravi Pokala wrote: > -Original Mess

Re: ee8b757a949a - main - ipmi: support getting address from EFI

2021-04-30 Thread Ravi Pokala
-Original Message- From: on behalf of Eric van Gyzen Date: 2021-04-29, Thursday at 08:25 To: , , Subject: git: ee8b757a949a - main - ipmi: support getting address from EFI The branch main has been updated by vangyzen: URL: https://cgit.FreeBSD.org/src/commit/?id=ee8b757a949a

git: de57e0ef5a15 - main - jedec_dimm(4): Add manufacturing year and week.

2023-04-28 Thread Ravi Pokala
The branch main has been updated by rpokala: URL: https://cgit.FreeBSD.org/src/commit/?id=de57e0ef5a15c75231191e643d4d1949ddbca92d commit de57e0ef5a15c75231191e643d4d1949ddbca92d Author: Ravi Pokala AuthorDate: 2023-04-25 06:07:39 + Commit: Ravi Pokala CommitDate: 2023-04-28 17:53

git: 15d69c840d86 - main - jedec_dimm(4): Refactor offset adjustment and page0 reset

2023-04-28 Thread Ravi Pokala
The branch main has been updated by rpokala: URL: https://cgit.FreeBSD.org/src/commit/?id=15d69c840d860a8c0decb063f768ad695427a0d4 commit 15d69c840d860a8c0decb063f768ad695427a0d4 Author: Ravi Pokala AuthorDate: 2023-04-27 05:03:48 + Commit: Ravi Pokala CommitDate: 2023-04-28 17:53

Re: d1c8420702b7 - main - Move more DIRDEPS_BUILD settings

2023-05-12 Thread Ravi Pokala
This change also drops 'arm' from 'TARGET_ARCHES_arm' ; this was causing make -DWITH_META_MODE tinderbox to try to 'make buildworld' for arm:arm, which of course doesn't exist anymore. -Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of

Re: e35448a901aa - main - powerpc: Drop old workaround for old gcc

2023-02-14 Thread Ravi Pokala
> However, that causes problems > for programs that do: It feels like there was supposed to be an example there, but there isn't one...? Thanks, Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Warner Losh mailto:i...@freebsd.org>> Date:

Re: df2b419a4105 - main - ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep.

2023-03-06 Thread Ravi Pokala
Hi Alexander, Knowing ~nothing about ifnet, if I were to see 'if_foreach_sleep()', my first thought would be that the loop itself was sleeping between each iteration, not that the callback was allowed to sleep. Perhaps this should be renamed to 'if_foreach_sleepable()'? Just a thought. Thanks

Re: df2b419a4105 - main - ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep.

2023-03-06 Thread Ravi Pokala
Chernikov mailto:melif...@freebsd.org>> Date: 2023-03-06, Monday at 09:06 To: Ravi Pokala mailto:rpok...@freebsd.org>> Cc: "mailto:src-committ...@freebsd.org>>" mailto:src-committ...@freebsd.org>>, "mailto:dev-commits-src-...@freebsd.org>>" mailto:

Re: f7acb7ed41f2 - main - Allow forcing non-posted memory on arm64

2023-03-19 Thread Ravi Pokala
Hi Andrew, This breaks arm64.LINT-FDT: | >>> stage 3.1: building everything | -- | /usr/home/rpokala/freebsd/src/clean-main/sys/arm64/arm64/nexus.c:87:61: error: expected identifier | SYSCTL_INT(_kern, OID_AUTO, force_nonposted, CTLFLAG

Re: d2d4e1271b33 - main - stand: Change zfs_fmtdev to take a struct devdesc *

2022-08-11 Thread Ravi Pokala
-Original Message- From: on behalf of Warner Losh Date: 2022-08-11, Thursday at 09:27 To: , , Subject: git: d2d4e1271b33 - main - stand: Change zfs_fmtdev to take a struct devdesc * The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=d2d4e1

Re: f486b352470e - main - LinuxKPI: add struct dmi_header and unsupported dmi_walk()

2022-09-26 Thread Ravi Pokala
-Original Message- From: on behalf of "Bjoern A. Zeeb" Date: 2022-09-26, Monday at 12:42 To: , , Subject: git: f486b352470e - main - LinuxKPI: add struct dmi_header and unsupported dmi_walk() The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?

Re: 5e4854cbf8d8 - main - rescue: Link libzutil after libzfs.

2022-10-03 Thread Ravi Pokala
-Original Message- From: on behalf of John Baldwin Date: 2022-10-03, Monday at 16:11 To: , , Subject: git: 5e4854cbf8d8 - main - rescue: Link libzutil after libzfs. The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=5e4854cbf8d8a9b056472967

Re: 1024bb26337b - main - qdivrem: Predict division by zero as false.

2022-10-04 Thread Ravi Pokala
-Original Message- From: on behalf of Hans Petter Selasky Date: 2022-10-04, Tuesday at 04:53 To: , , Subject: git: 1024bb26337b - main - qdivrem: Predict division by zero as false. The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=102

Re: 3f8f02b2abfe - main - arm64: Hyper-V: enablement for ARM64 in Hyper-V (Part 2)

2022-10-21 Thread Ravi Pokala
-Original Message- From: on behalf of Wei Hu Date: 2022-10-21, Friday at 02:47 To: , , Subject: git: 3f8f02b2abfe - main - arm64: Hyper-V: enablement for ARM64 in Hyper-V (Part 2) The branch main has been updated by whu: URL: https://cgit.FreeBSD.org/src/commit/?id=3f8f02b2a

Re: 64c3edc237a5 - main - Allow the extres regulator code to build without FDT

2022-10-27 Thread Ravi Pokala
-Original Message- From: on behalf of Andrew Turner Date: 2022-10-27, Thursday at 09:31 To: , , Subject: git: 64c3edc237a5 - main - Allow the extres regulator code to build without FDT The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?

Re: f0f3e3e961d3 - main - ipmi: use a queue for kcs driver requests when possible

2022-11-01 Thread Ravi Pokala
Hi Chuck, As best as I can tell, the stack for handling a request from userland (e.g. `ipmitool') looks like this: ipmi_polled_enqueue_request_highpri() kcs_driver_request_queue() /* assuming not panicked or dumping core */ kcs_driver_request() sc->ipmi_driver_request() ipmi_submit_driver_reques

Re: f0f3e3e961d3 - main - ipmi: use a queue for kcs driver requests when possible

2022-11-01 Thread Ravi Pokala
Date: 2022-11-01, Tuesday at 14:55 To: Ravi Pokala Cc: , , Subject: Re: f0f3e3e961d3 - main - ipmi: use a queue for kcs driver requests when possible Hi Ravi, the usual path (the IPMI_SYSTEM_INTERFACE_ADDR_TYPE case) for an "application" request (ie. one from us

Re: d0b5e4a30ac9 - main - mana(4): Make the code cross-platform

2022-11-03 Thread Ravi Pokala
Hi Li-Wen, Shouldn't these new "%ju"s and "%jx"s have (uintmax_t) casts? Thanks, Ravi (rpokala@) -Original Message- From: on behalf of Li-Wen Hsu Date: 2022-11-03, Thursday at 21:16 To: , , Subject: git: d0b5e4a30ac9 - main - mana(4): Make the code cross-platform The branch m

Re: b1258b76435a - main - tcp: add conservative d.cep accounting algorithm

2022-11-06 Thread Ravi Pokala
Hi Richard, This change adds 'int tlen' and 'int pkts' as an arguments to tcp_ecn_input_segment(). However, while the function uses 'pkts', it does not use 'tlen'. Is it supposed to? Was the argument added now for planned use in the future? If it is not currently being use, it should be marked

Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images

2022-11-06 Thread Ravi Pokala
Hi Li-Wen, If I'm reading this (and 72a1cb05cd23) correctly, this will run `zpool upgrade' on the "zroot" pool on every boot. That's fine for the first time a VM image is used, since presumably the root pool and the bootloader were generated from the same sources. But if the root pool is subseq

Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images

2022-11-07 Thread Ravi Pokala
-Original Message- From: Li-Wen Hsu Date: 2022-11-06, Sunday at 22:48 To: Ravi Pokala Cc: , , Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images On Mon, Nov 7, 2022 at 1:33 PM Ravi Pokala wrote: > > Hi

Re: 1e9c9ab59577 - main - pkgbase: do not record dependency on non-existent liby package

2022-11-18 Thread Ravi Pokala
-Original Message- From: on behalf of Ed Maste Date: 2022-11-18, Friday at 10:19 To: , , Subject: git: 1e9c9ab59577 - main - pkgbase: do not record dependency on non-existent liby package The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?

Re: e0b7defdeeb6 - main - orders.7: Sync with NetBSD after CGPM

2022-11-20 Thread Ravi Pokala
Am I the only one mildly annoyed that {Quadr,Quint,Sext,Sept,Oct,Non}illion are off-by-one? You'd think _Quad_rillion would be 10^(3*_4_), _Quint_illion would be 10^(3*_5_), etc, but they're actually 10^(3*_5_) and 10^(3*_6_), respectively. Stupid standards... ;-) -Ravi (rpokala@) -Origin

Re: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters.

2022-02-20 Thread Ravi Pokala
-Original Message- From: on behalf of Michal Meloun Date: 2022-02-20, Sunday at 03:39 To: , , Subject: git: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters. The branch main has been updated by mmel: URL: https://cgit.FreeBSD.org/src/c

Re: a813b0965d8e - main - sdhci: Make ext_resources non-optional

2022-02-23 Thread Ravi Pokala
-Original Message- From: on behalf of Mateusz Guzik Date: 2022-02-23, Wednesday at 04:02 To: Emmanuel Vadot Cc: Emmanuel Vadot , , , Subject: Re: git: a813b0965d8e - main - sdhci: Make ext_resources non-optional On 2/23/22, Emmanuel Vadot wrote: > On Tue, 22 Feb 2022 20:05:4

Re: 01f8011736ff - main - iicbus: Add missing dependency for iicbus module.

2022-02-23 Thread Ravi Pokala
-Original Message- From: on behalf of Michal Meloun Date: 2022-02-23, Wednesday at 07:30 To: , , Subject: git: 01f8011736ff - main - iicbus: Add missing dependency for iicbus module. The branch main has been updated by mmel: URL: https://cgit.FreeBSD.org/src/commit/?id=01f8

Re: 6543fa5a5c47 - main - dumpon: warn if the configured netdump link is down

2022-05-16 Thread Ravi Pokala
-Original Message- From: on behalf of Mitchell Horne Date: 2022-05-14, Saturday at 06:28 To: , , Subject: git: 6543fa5a5c47 - main - dumpon: warn if the configured netdump link is down The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=

Re: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810

2022-05-28 Thread Ravi Pokala
Hi Eric, This change appears to have broken the amd64 LINT-{NOINET,NOINET6,NOIP} kernels: LINT-NOINET /usr/home/rpokala/freebsd/src/clean-main/sys/modules/irdma/../../dev/irdma/irdma_cm.c:1659:11: error: implicit declaration of fun

Re: 4014365e4219 - main - mixer: remove volume backwards compat, add % interpretation

2022-06-18 Thread Ravi Pokala
H Kyle, | +Note that relative percentages are still relative to 1.0, not to the current | +value. | +If the volume is currently 0.40 and an adjustment of +20% is specified, then | +thet final volume will be set to 0.60. What you're describing are *absolute* percentages, not relative. Please rewor

Re: 75cbdbc9832e - main - kboot: aarch64 support

2022-07-28 Thread Ravi Pokala
> exec.c tweaked slightly Relative to what? -Ravi (rpokala@) -Original Message- From: on behalf of Warner Losh Date: 2022-07-28, Thursday at 14:37 To: , , Subject: git: 75cbdbc9832e - main - kboot: aarch64 support The branch main has been updated by imp: URL: https://cgi

Re: b3fd5464a903 - main - rb_tree: resolve name clash

2022-08-02 Thread Ravi Pokala
-Original Message- From: on behalf of Doug Moore Date: 2022-08-02, Tuesday at 09:49 To: , , Subject: git: b3fd5464a903 - main - rb_tree: resolve name clash The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=b3fd5464a903180994313bd903f3c17

Re: d07acc58d898 - main - systm: Relax __result_use_check annotations

2024-01-12 Thread Ravi Pokala
Hi Mark, > failing to check for errors when copying *in* is a much more severe bug In that you might get panics. But failing to check for errors when copying *out* can be a security leak; depending on the context, a panic might be preferable. I agree with what Mateusz just said: make __result_

Re: edacf4b4824a - main - UPDATING: fix a typo, adjust a white space

2023-08-19 Thread Ravi Pokala
No, there was definitely a typo: "chagned" is not a word in English. As for the white space, that's a different issue, and I'm staying away from that bikeshed. -Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Alexey Dokuchaev mailto:da..

Re: 6cec93da46c4 - main - Revert "radix_trie: have vm_radix use pctrie code"

2023-09-11 Thread Ravi Pokala
Hi Doug, > Revert "radix_trie: have vm_radix use pctrie code" That's "what", not "why". Why are you reverting the change? Thanks, Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Doug Moore mailto:do...@freebsd.org>> Date: Monday, Septem

Re: 6cec93da46c4 - main - Revert "radix_trie: have vm_radix use pctrie code"

2023-09-11 Thread Ravi Pokala
Thanks! -Ravi (rpokala@) -Original Message- From: Doug Moore mailto:unkad...@gmail.com>> Date: Monday, September 11, 2023 at 10:26 To: Ravi Pokala mailto:rpok...@freebsd.org>>, mailto:src-committ...@freebsd.org>>, mailto:dev-commits-src-...@freebsd.org>>, mai

Re: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag

2023-09-26 Thread Ravi Pokala
In that case, an updated comment seems appropriate, so it’s not removed again. -Ravi (rpokala@) From: on behalf of Warner Losh Date: Tuesday, September 26, 2023 at 07:51 To: Mateusz Guzik Cc: src-committers , "" , "" Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: wha

Re: 26103ccba8b7 - main - zfs: enable block cloning by default

2023-10-10 Thread Ravi Pokala
Hi Martin, The commit message says "what", not "why". Why was block cloning disabled by default before, and why is it being enabled now? Thanks, Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Martin Matuska mailto:m...@freebsd.org>> D

Re: 26103ccba8b7 - main - zfs: enable block cloning by default

2023-10-10 Thread Ravi Pokala
Thanks for the explanation, Alexander. -Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Alexander Motin mailto:m...@freebsd.org>> Date: Wednesday, October 11, 2023 at 08:58 To: Ravi Pokala mailto:rpok...@freebsd.org>>

git: bb8b3b174118 - main - modules: gpioaei: Fix arm64.LINT-FDT breakage

2024-11-01 Thread Ravi Pokala
The branch main has been updated by rpokala: URL: https://cgit.FreeBSD.org/src/commit/?id=bb8b3b1741188ab284e8b48ec367961a480421cb commit bb8b3b1741188ab284e8b48ec367961a480421cb Author: Ravi Pokala AuthorDate: 2024-11-02 05:08:11 + Commit: Ravi Pokala CommitDate: 2024-11-02 05:08

Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs

2024-11-01 Thread Ravi Pokala
f Colin Percival mailto:cperc...@freebsd.org>> Date: Friday, November 1, 2024 at 19:13 To: Ravi Pokala mailto:rpok...@freebsd.org>>, mailto:src-committ...@freebsd.org>>, mailto:dev-commits-src-...@freebsd.org>>, mailto:dev-commits-src-main@FreeBSD.org>> Subject: Re: 6540a

Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs

2024-11-01 Thread Ravi Pokala
Hi Colin, This seems to have broken arm64.LINT-FDT: % less _.arm64.LINT-FDT ... -- >>> stage 3.1: building everything --

Re: cfbe7a62dc62 - main - nfs, rpc: Ensure kernel credentials have at least one group

2024-11-02 Thread Ravi Pokala
Hi Olivier, This appears to break amd64.MINIMAL and amd64.MINIMALUP: % less _.amd64.MINIMAL linking kernel.full ld: error: undefined symbol: vnet_entry_nfsrv_defaultgid >>> referenced by vfs_export.c:141 (sys/kern/vfs_export.c:141)

Re: 38663adb6144 - main - Revert "ixl: fix multicast filters handling"

2024-12-19 Thread Ravi Pokala
> Revert "ixl: fix multicast filters handling" Yes, but *why*? -Ravi (rpokala@) -Original Message- From: mailto:owner-src-committ...@freebsd.org>> on behalf of Mark Johnston mailto:ma...@freebsd.org>> Date: Thursday, December 19, 2024 at 05:49 To: mailto:src-committ...@freebsd.org>>,

Re: a1097094c4c5 - main - newvers: Set explicit git revision length

2024-12-19 Thread Ravi Pokala
It occurred to me to see what Linux distros do. I spot-checked several distros that we have in our lab (several versions of Debian, RHEL, Rocky, SLES, OpenSuSE, Ubuntu), and it looks like only SLES and OpenSuSE embed a Git hash in their 'uname -a' output. For both those distros, it uses just sev

Re: 9234a50752cd - main - ng_ksocket: add IPv6 support for address parsing and unparsing

2025-01-11 Thread Ravi Pokala
Hi Gleb, I believe this change breaks LINT-NOINET6 and LINT-NOIP: >>> stage 3.1: building everything -- linking kernel ld: error: undefined symbol: in6_getscope >>> referen

git: 8d079c6a9a5d - main - if_infininband: Support BPF write for broadcast frames

2025-02-23 Thread Ravi Pokala
The branch main has been updated by rpokala: URL: https://cgit.FreeBSD.org/src/commit/?id=8d079c6a9a5dfdc75adaf9bc31f2ee8111b849a1 commit 8d079c6a9a5dfdc75adaf9bc31f2ee8111b849a1 Author: Nicholas Dance AuthorDate: 2025-02-05 23:33:20 + Commit: Ravi Pokala CommitDate: 2025-02-24 00

Re: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK

2025-03-10 Thread Ravi Pokala
Ah, I see. Thanks, Ravi (rpokala@) -Original Message- From: John Baldwin mailto:j...@freebsd.org>> Date: Monday, March 10, 2025 at 11:15 To: Ravi Pokala mailto:rpok...@freebsd.org>>, mailto:src-committ...@freebsd.org>>, mailto:dev-commits-src-...@freebsd.org>&

Re: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK

2025-03-11 Thread Ravi Pokala
Hi John, > This reverts commit 234683726708cf5212d672d676d30056d4133859. The commit message for that change says that this allocation might be done while holding a lock, and so M_WAITOK is not valid. So then why is this change okay? Thanks, Ravi (rpokala@0 -Original Message- From: m