Re: git: fce03f85c5bf - main - TCP can be subject to Sack Attacks lets fix this issue.

2024-05-06 Thread Gary Jennejohn
etinet/tcp_stacks/sack_filter.c > > index e82fcee2ffac..fc9ee8454a1e 100644 > > --- a/sys/netinet/tcp_stacks/sack_filter.c > > +++ b/sys/netinet/tcp_stacks/sack_filter.c > > > #ifndef _KERNEL > > + > > +static u_int tcp_fixed_maxseg(const struct tcpcb *tp) > > +{ > > + /* Lets pretend their are timestamps on for user space */ > > + return (tp->t_maxseg - 12); > > +} > > Typo in the comment? > Yes. Should be Let's as a contraction of Let us. -- Gary Jennejohn

Re: git: fce03f85c5bf - main - TCP can be subject to Sack Attacks lets fix this issue.

2024-05-06 Thread Gary Jennejohn
On Mon, 6 May 2024 11:11:36 + Gary Jennejohn wrote: > On Mon, 06 May 2024 09:27:31 +0200 > Alexander Leidinger wrote: > > > Am 2024-05-05 15:10, schrieb Randall Stewart: > > > The branch main has been updated by rrs: > > > > > > URL: >

Re: git: 65904399db91 - main - efibootmgr: allow -u as a valid option

2024-03-25 Thread Gary Jennejohn
rgc, argv, > + "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:u:v", lopts, NULL)) != -1) { > switch (ch) { > case 'A': > opts.set_inactive = true; > -u is not documented in the man page for efibootmgr, although it was already in the source. -- Gary Jennejohn

Re: git: 65904399db91 - main - efibootmgr: allow -u as a valid option

2024-03-25 Thread Gary Jennejohn
On Mon, 25 Mar 2024 07:37:54 -0700 Mark Peek wrote: > On Mon, Mar 25, 2024 at 2:01?AM Gary Jennejohn wrote: > > > On Sun, 24 Mar 2024 19:39:49 GMT > > Mark Peek wrote: > > > > > The branch main has been updated by mp: > > > > > &g

Re: git: bf8f6ffcb66a - main - Mention kern.timecounter.alloweddeviation in nanosleep.1

2021-10-09 Thread Gary Jennejohn
ead about it, only > > sysctl -d and kern_tc.c. > > > > The only thing I worry that may be missing from this change is this > > reference > > in any other manual pages that might need it as much as nanosleep. > Well, nanosleep is just an example of a syscall requesting timeout. > Another poster childs there are select(2), and poll(2) family which > explicitly use precision. > > To get the definitive list, you would need to review all uses of > callout_reset() variants. > -- Gary Jennejohn

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-21 Thread Gary Jennejohn
scons.bell: enable bell With this set to 1 a ^G in xterm results in a beep. After setting the sysctl to 0 a ^G in xterm produces no sound at all. -- Gary Jennejohn

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-22 Thread Gary Jennejohn
ke the 20 year old defaults, > so I am going to change them to what I like and use" It is NOT > forward progress on making a better system, it is tilting at > defaults, very long established defaults, that should probably > just be left alone. > > I dont like a lot of the defaults on a lot of OS's, I tweak them > to my needs. FreeBSD keeps tweaking things such that I have to > tweak my tweaks to keep things as I see fit. THAT IS A POLA VIOLATION! > -- Gary Jennejohn

Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()

2021-04-27 Thread Gary Jennejohn
t; > > > -Neel > > > > > > Can you use and link to Phabricator for your src commits? As much as > > > possible it is preferable to get it right in one go, for MFCs, > > > bisection, etc and this kind of churn should be preventable with quick > > > reviews. Feel free to tag me

Re: git: 3394d4239b85 - main - cam: allocate CCBs from UMA for SCSI and ATA IO

2021-05-15 Thread Gary Jennejohn
1' tunables to enable it. Testing > is welcome; I will flip the default to enable in two weeks from now. > [snip diff] I built and installed world and kernel and enabled both tunables. System's been up for about two hours using both ada and da disks pretty intensely and has

Re: git: 0a99422970d7 - main - Move mips and arm to 1000Hz by default.

2021-06-17 Thread Gary Jennejohn
our Handbook or Wiki. > It's discussed in /sys/conf/NOTES, but most users probably wouldn't think about looking there. An entry in the Handbook or Wiki could be useful. -- Gary Jennejohn ___ dev-commits-src-main@freebsd.org mailing list http

Re: git: 0f882bb14a0e - main - NOTES: Update the HZ entry with latest advice.

2021-06-18 Thread Gary Jennejohn
options HZ=100 > > ___ > dev-commits-src-...@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to "dev-commits-src-all-unsubscr...@freebsd.org" --

Re: git: 23408297fbf3 - main - Merge llvm-project 12.0.1 rc2

2021-06-20 Thread Gary Jennejohn
These were both clean builds, i.e. the target directory was empty when I started the build, so every file had to be newly compiled. -- Gary Jennejohn ___ dev-commits-src-main@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"

Re: git: 6b1c5775d1c2 - main - Move libc++ from /usr/lib to /lib

2021-12-30 Thread Gary Jennejohn
gt; This is strange. I just did buildworld/installworld at main-n252047-f1d5e2c862e and cc works just fine for me. My /libexec/ld-elf.so.1 is from December 22nd, but it's identical to the ld-elf.so.1 which was built today (based on sum values). And my /usr/lib/libc++.so.1 was installed today. There's no /lib/libc++.so.1 on my system even though I had the modified Makefile when I did the buildworld/installworld. I don't delete old files using ObsoleteFiles.inc. Still, libc++.so.1 should be present in your obj directory and you can just copy it to /lib and/or /usr/lib as a temporary fix. -- Gary Jennejohn

Re: git: 4358928e235c - main - amd64 loader: plug hard hang with serial console enabled

2023-04-01 Thread Gary Jennejohn
return; > } > #endif > What if env is NULL? Shouldn't the code return without changing anything? Seems to me that this if() should be split into two if() clauses. -- Gary Jennejohn

Re: git: fcad8ada9afc - main - Revert "Add myself (cc) as a src commiter."

2023-04-04 Thread Gary Jennejohn
little bit sad missing asami@ and jkh@ from current development process > Wow, Greg, you kept a diary of all your commits? I never thoght to do that. I remember that after I made my first commit in 1994 bde@ (RIP) asked me whether I copy/pasted the diff. I answered yes because I didn't want to risk making an error if I typed it in. Never got any follow up from him. -- Gary Jennejohn

Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024

2023-05-09 Thread Gary Jennejohn
AXSIZE 256 > > > +#defineCPU_MAXSIZE 1024 > > >   > > >  #ifndefCPU_SETSIZE > > >  #defineCPU_SETSIZE CPU_MAXSIZE > > > > Hi Ed, > > > > this somehow breaks bhyve on my system. It immediately exits

Re: git: 36db6b04962a - main - hier(7): document /home/ and /usr/home/

2023-05-11 Thread Gary Jennejohn
asets, in > the zfs case). > > All of this really is a horrible kludge, and it is a house of cards. I'm > amazed that it doesn't break more often. I'm tempted to remove the kludge > and change the zfs setup to create a home dataset rather than usr/home. > However, if zfs users explicitly configure a home directory under /usr/home, > this would end up in the usr dataset. An alternative would be to remove the > code from pw to create the parent directory entirely (which seems sensible), > and create a /home directory for ufs installs. I don't know how well known > it is that adduser/pw will create parent directories for home directories > though. This cleanup would change the default location for home directories > to /home, which makes more sense. It would require documentation, e.g. in > the release notes. The changes would only affect new installations, not > upgrades. > > Thoughts? > Adding home would require a change to BSD.root.dist, since it's not currently in there. Only usr is present. IMHO changing pw would be a reasonable approach. -- Gary Jennejohn

Re: git: 36db6b04962a - main - hier(7): document /home/ and /usr/home/

2023-05-11 Thread Gary Jennejohn
mes more data on it than is on /usr. > > However, we now default to a single large file system (with datasets, in > > the ZFS case). > > ZFS makes it all easier of course, but at its present state is not usable > on 13+, so I'm confined to UFS until ZoL guys can fix their sh^code. :( > > ./danfe > -- Gary Jennejohn

Re: git: 108230743472 - main - pwd.1: replace /home with /sys in example

2023-05-23 Thread Gary Jennejohn
use > .Xr file 1 > to inspect the > -.Pa /home > +.Pa /sys > directory: > .Bd -literal -offset indent > $ /bin/pwd -L > -/home/fernape > -$ file /home > -/home: symbolic link to usr/home > +/sys/kern > +$ file /sys > +/sys: symbolic link to usr/src/sys > .Ed > .Sh SEE ALSO > .Xr builtin 1 , > -- Gary Jennejohn

Re: git: 685866bbe13d - main - routing: fix build without ROUTE_MPATH

2022-08-11 Thread Gary Jennejohn
ion 'add_route_flags_mpath' [-Wunused-function] add_route_flags_mpath(struct rib_head *rnh, struct rtentry *rt, ^ 1 warning generated. This is because the function is only called if ROUTE_MPATH is defined, but the forward declaration and implementation of add_route_flags_mpath are not gated with #ifdef ROUTE_MPATH. -- Gary Jennejohn

Re: git: 685866bbe13d - main - routing: fix build without ROUTE_MPATH

2022-08-11 Thread Gary Jennejohn
On Thu, 11 Aug 2022 10:49:07 +0100 "Alexander V. Chernikov" wrote: > > On 11 Aug 2022, at 10:27, Gary Jennejohn wrote: > > > > I did a buildkernel and got this warning message: > > > > /usr/src/sys/net/route/route_ctl.c:787:1: warning: unused functio

Re: git: ba94a95402f3 - main - gpart(8): add minimal reference to glabel(8) to manual page

2022-01-10 Thread Gary Jennejohn
does. > > .Sh PARTITION TYPES > > Partition types are identified on disk by particular strings or magic > > values. > > @@ -1507,6 +1511,7 @@ and > > .Xr geom 4 , > > .Xr boot0cfg 8 , > > .Xr geom 8 , > > +.Xr glabel 8 , > > .Xr gptboot 8 > > .Sh HISTORY > > The > > > > > > -- Gary Jennejohn

Re: git: 84bf2bbbecc3 - main - stand: constrain zlib/gzip CFLAGS better

2022-07-20 Thread Gary Jennejohn
; > I'll fix a bandaide and do it better when I return from vacation. > > > > Doh! I don't have the right keys loaded in my ssh-agent, so I can't push > the change because the port forwarding on my router is broken and I can't > remotely login :( > > If someone could commit the change I suggested in > https://reviews.freebsd.org/D35860 that would be great! > Well, I can say that Warner's recommended change fixes building libsa for me. Couldn't build libsa earlier today without makeing some hackey changes to dosfs.c, tftp.c and ufs.c. -- Gary Jennejohn

Re: git: c35f527ed115 - main - sx: unset td_wantedlock around going to sleep

2023-10-23 Thread Gary Jennejohn
; > if (!(opts & SX_INTERRUPTIBLE)) > sleepq_wait(&sx->lock_object, 0); > else > error = sleepq_wait_sig(&sx->lock_object, 0); > + THREAD_CONTENDS_ON_LOCK(&sx->lock_object); > #ifdef KDTRACE_HOOKS > sleep_time += lockstat_nsecs(&sx->lock_object); > sleep_cnt++; > -- Gary Jennejohn

Re: git: 171a7bbfc048 - main - tcpdump: fix build with WITHOUT_PF=1

2023-06-14 Thread Gary Jennejohn
DLT_LOOP > { null_if_print,DLT_LOOP }, > #endif > -#ifdef DLT_PFLOG > +#if defined(DLT_PFLOG) && defined(HAVE_NET_IF_PFLOG_H) > { pflog_if_print, DLT_PFLOG }, > #endif > #ifdef DLT_PKTAP > Thank you, Gleb! -- Gary Jennejohn

Re: git: 764464af4968 - main - Fix spelling of "behavior" to be consistent with the rest of the file

2023-06-23 Thread Gary Jennejohn
m4 1.4.9 and later. > > > > American spelling. > > > > > .It Fl G , Fl -traditional > > > Disable GNU compatibility mode (see > > > .Fl g > > > > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: https://FreeBSD.org > > NTP: Web: https://nwtime.org > > > > e^(i*pi)+1=0 > > > > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e^(i*pi)+1=0 > > > -- Gary Jennejohn

Re: git: 21e45c30c35c - main - mmap(MAP_STACK): on stack grow, use original protection

2023-07-20 Thread Gary Jennejohn
nd user-exported inheritance and protection information. > > > > > * Also included is control information for virtual copy operation > > > s. > > > > > + * > > > > > + * For stack gap map entries (MAP_ENTRY_GUARD | MAP_ENTRY_GROWS_DO > > > WN > > > > > + * or UP), the next_read member is reused as the stack_guard_page > > > > > + * storage, and offset is the stack protection. > > > > > */ > > > > > struct vm_map_entry { > > > > > struct vm_map_entry *left; /* left child or previous entry > > > > > */ > > > > > > > > > > > > > This commit has caused screen (sysutils/screen) to display the following > > > > error when opening a new screen window (ctrl-A c): > > > > > > > > pid 28473 comm screen-4.9.0 has trashed its stack, killing > > > > > > > > > > > > -- > > > > Cheers, > > > > Cy Schubert > > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > > NTP: Web: https://nwtime.org > > > > > > > > e^(i*pi)+1=0 > > > > > > > > > > > > > > I'm also seeing artifacts in emails by nmh (mail/nmh) in my sent directory > > > and in the email cc'd to me. > > > > > > > > > -- > > > Cheers, > > > Cy Schubert > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > NTP: Web: https://nwtime.org > > > > > > e^(i*pi)+1=0 > > > > > > > > > > Sometimes this occurs at screen start. Then it hangs. > > > > slippy$ screen > > pid 7275 comm screen-4.9.0 has trashed its stack, killing > > Can you check this? > > diff --git a/sys/vm/vm_map.c b/sys/vm/vm_map.c > index 8c864c943f5d..4c5f1c08954d 100644 > --- a/sys/vm/vm_map.c > +++ b/sys/vm/vm_map.c > @@ -4202,7 +4202,8 @@ vm_map_copy_entry( > src_entry->start); > } else { > dst_entry->object.vm_object = NULL; > - dst_entry->offset = 0; > + if ((dst_entry->eflags & MAP_ENTRY_GUARD) == 0) > + dst_entry->offset = 0; > if (src_entry->cred != NULL) { > dst_entry->cred = curthread->td_ucred; > crhold(dst_entry->cred); > > Works for me. I tested with both pkg and screen and saw no errors. -- Gary Jennejohn