Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-22 Thread Hans Petter Selasky
On 5/21/23 23:58, Jessica Clarke wrote: On 21 May 2023, at 22:37, Hans Petter Selasky wrote: On 5/21/23 21:41, Jessica Clarke wrote: I can not know what you know before you tell me. I'm not a mind reader and I for sure don't think you are an idiot. Those are in such case your own words ab

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-22 Thread Hans Petter Selasky
On 5/22/23 01:01, Warner Losh wrote: On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky wrote: On 5/21/23 23:58, Jessica Clarke wrote: What I disputed was your commit message, which at best is extremely misleading and at worst makes no sense, and the necessity of the change. Hi Jess, Your r

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Warner Losh
On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky wrote: > On 5/21/23 23:58, Jessica Clarke wrote: > > What I disputed was your commit message, which at best is extremely > misleading and at worst makes no sense, and the necessity of the change. > > Hi Jess, > > Your request for revert has been n

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 23:51, Hans Petter Selasky wrote: > > On 5/22/23 00:32, Jessica Clarke wrote: >> Once again I will remind you that the FreeBSD tree is not somewhere for you >> to play around with experiments. Changes should be properly justified. > > Hi Jess, > > This is FreeBSD-current / m

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/22/23 00:32, Jessica Clarke wrote: Once again I will remind you that the FreeBSD tree is not somewhere for you to play around with experiments. Changes should be properly justified. Hi Jess, This is FreeBSD-current / main and my change is perfectly fine as such. Sorry. It is not my pr

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 23:13, Hans Petter Selasky wrote: > > On 5/21/23 23:37, Hans Petter Selasky wrote: >> DEFINE_MUTEX is Linux’s API, implemented in LinuxKPI. So Linux’s behaviour >> is absolutely relevant. Any deviation from Linux’s semantics is an >> incompatibility that requires patching any

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/21/23 23:58, Jessica Clarke wrote: What I disputed was your commit message, which at best is extremely misleading and at worst makes no sense, and the necessity of the change. Hi Jess, Your request for revert has been noted, but I see no urgency in such a revert. The code is perfectly f

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/21/23 23:37, Hans Petter Selasky wrote: DEFINE_MUTEX is Linux’s API, implemented in LinuxKPI. So Linux’s behaviour is absolutely relevant. Any deviation from Linux’s semantics is an incompatibility that requires patching any sources that are built for FreeBSD using LinuxKPI. It is generall

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 22:37, Hans Petter Selasky wrote: > > On 5/21/23 21:41, Jessica Clarke wrote: >>> One difference between Linux and FreeBSD when doing the monotolithic kernel >>> build: FreeBSD puts all object files resulting from compilation into the >>> same object directory. This implies t

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/21/23 21:41, Jessica Clarke wrote: One difference between Linux and FreeBSD when doing the monotolithic kernel build: FreeBSD puts all object files resulting from compilation into the same object directory. This implies there cannot be two object files sharing the same name as a result of

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 20:13, Hans Petter Selasky wrote: > > On 5/21/23 20:02, Jessica Clarke wrote: >> On 21 May 2023, at 18:46, Hans Petter Selasky wrote: >>> >>> On 5/21/23 19:05, Jessica Clarke wrote: On 21 May 2023, at 17:57, Hans Petter Selasky wrote: > If you want to change from st

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/21/23 20:02, Jessica Clarke wrote: On 21 May 2023, at 18:46, Hans Petter Selasky wrote: On 5/21/23 19:05, Jessica Clarke wrote: On 21 May 2023, at 17:57, Hans Petter Selasky wrote: If you want to change from static structures to global symbols, then my change is correct. Which will b

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 18:46, Hans Petter Selasky wrote: > > On 5/21/23 19:05, Jessica Clarke wrote: >> On 21 May 2023, at 17:57, Hans Petter Selasky wrote: >>> If you want to change from static structures to global symbols, then my >>> change is correct. >> Which will bloat symbol tables excessive

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/21/23 19:05, Jessica Clarke wrote: On 21 May 2023, at 17:57, Hans Petter Selasky wrote: If you want to change from static structures to global symbols, then my change is correct. Which will bloat symbol tables excessively. But you didn’t state this as your goal, you stated it as a beh

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Mark Millard
On May 21, 2023, at 10:14, Mark Millard wrote: > Hans Petter Selasky wrote on > Date: Sun, 21 May 2023 16:57:47 UTC : > >> On 5/21/23 18:33, Jessica Clarke wrote: >>> On 21 May 2023, at 17:21, Hans Petter Selasky wrote: The branch main has been updated by hselasky: URL

RE: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Mark Millard
Hans Petter Selasky wrote on Date: Sun, 21 May 2023 16:57:47 UTC : > On 5/21/23 18:33, Jessica Clarke wrote: > > On 21 May 2023, at 17:21, Hans Petter Selasky wrote: > >> > >> The branch main has been updated by hselasky: > >> > >> URL: > >> https://cgit.FreeBSD.org/src/commit/?id=805d759338a2

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 17:57, Hans Petter Selasky wrote: > > On 5/21/23 18:33, Jessica Clarke wrote: >> On 21 May 2023, at 17:21, Hans Petter Selasky wrote: >>> >>> The branch main has been updated by hselasky: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=805d759338a2be939fffc8bf3f25c

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
On 5/21/23 18:33, Jessica Clarke wrote: On 21 May 2023, at 17:21, Hans Petter Selasky wrote: The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=805d759338a2be939fffc8bf3f25cfaab981a9be commit 805d759338a2be939fffc8bf3f25cfaab981a9be Author: Hans P

Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Jessica Clarke
On 21 May 2023, at 17:21, Hans Petter Selasky wrote: > > The branch main has been updated by hselasky: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=805d759338a2be939fffc8bf3f25cfaab981a9be > > commit 805d759338a2be939fffc8bf3f25cfaab981a9be > Author: Hans Petter Selasky > AuthorDate

git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

2023-05-21 Thread Hans Petter Selasky
The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=805d759338a2be939fffc8bf3f25cfaab981a9be commit 805d759338a2be939fffc8bf3f25cfaab981a9be Author: Hans Petter Selasky AuthorDate: 2023-05-21 11:25:28 + Commit: Hans Petter Selasky CommitDate: