Re: git: ad8d33679999 - main - mmc_xpt: use strlcpy instead of strncpy

2025-07-01 Thread Warner Losh
On Mon, Jun 30, 2025 at 9:19 AM Warner Losh wrote: > But there's another consideration that 4195c7de2471d didn't think > through that I have just thought of... It turns out not to be an issue because ccbs are always initialized when these fields are used. Warner

Re: git: ad8d33679999 - main - mmc_xpt: use strlcpy instead of strncpy

2025-07-01 Thread Andriy Gapon
On 30/06/2025 18:19, Warner Losh wrote: You should really get changes like this reviewed. "seems like" is not a good enough reason to do this. In fact, it's a terrible reason in the CAM code. There are places that the strncpy use is intentional and you will screw things up if you use strlcpy. Too

Re: git: ad8d33679999 - main - mmc_xpt: use strlcpy instead of strncpy

2025-06-30 Thread Warner Losh
On Mon, Jun 30, 2025 at 7:57 AM Andriy Gapon wrote: > > On 30/06/2025 16:34, John Baldwin wrote: > > On 6/27/25 03:21, Andriy Gapon wrote: > >> The branch main has been updated by avg: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/? > >> id=ad8d3367c0e7f6fd2b77d2e414102bd365ec > >> > >> c

Re: git: ad8d33679999 - main - mmc_xpt: use strlcpy instead of strncpy

2025-06-30 Thread Andriy Gapon
On 30/06/2025 16:34, John Baldwin wrote: On 6/27/25 03:21, Andriy Gapon wrote: The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/? id=ad8d3367c0e7f6fd2b77d2e414102bd365ec commit ad8d3367c0e7f6fd2b77d2e414102bd365ec Author: Andriy Gapon AuthorDate:

Re: git: ad8d33679999 - main - mmc_xpt: use strlcpy instead of strncpy

2025-06-30 Thread John Baldwin
On 6/27/25 03:21, Andriy Gapon wrote: The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=ad8d3367c0e7f6fd2b77d2e414102bd365ec commit ad8d3367c0e7f6fd2b77d2e414102bd365ec Author: Andriy Gapon AuthorDate: 2025-06-23 21:31:04 + Commit: Andri