Re: git: 5f11a33ceeb3 - main - if_vlan: do not enable LRO for bridge interaces

2023-08-12 Thread Kevin Bowling
On Sat, Aug 12, 2023 at 9:01 AM Kristof Provost wrote: > > On 12 Aug 2023, at 17:42, Kevin Bowling wrote: > > On Sat, Aug 12, 2023 at 1:45 AM Kristof Provost wrote: > >> > >> I also don’t have a setup to reproduce the issues Paul reported. > >> Given the discussion in the PR I assumed everyone wa

Re: git: 5f11a33ceeb3 - main - if_vlan: do not enable LRO for bridge interaces

2023-08-12 Thread Kristof Provost
On 12 Aug 2023, at 17:42, Kevin Bowling wrote: > On Sat, Aug 12, 2023 at 1:45 AM Kristof Provost wrote: >> >> I also don’t have a setup to reproduce the issues Paul reported. >> Given the discussion in the PR I assumed everyone was happy with the fix he >> posted. > > Ok, I happened to be looking

Re: git: 5f11a33ceeb3 - main - if_vlan: do not enable LRO for bridge interaces

2023-08-12 Thread Kevin Bowling
On Sat, Aug 12, 2023 at 1:45 AM Kristof Provost wrote: > > I also don’t have a setup to reproduce the issues Paul reported. > Given the discussion in the PR I assumed everyone was happy with the fix he > posted. Ok, I happened to be looking into it when the commit went in. Please revert, it's n

Re: git: 5f11a33ceeb3 - main - if_vlan: do not enable LRO for bridge interaces

2023-08-12 Thread Kristof Provost
I also don’t have a setup to reproduce the issues Paul reported. Given the discussion in the PR I assumed everyone was happy with the fix he posted. Best regards, Kristof On 12 Aug 2023, at 3:28, Kevin Bowling wrote: > I think this may be a better fix, currently untested > > diff --git a/sys/net

Re: git: 5f11a33ceeb3 - main - if_vlan: do not enable LRO for bridge interaces

2023-08-11 Thread Kevin Bowling
I think this may be a better fix, currently untested diff --git a/sys/net/if_vlan.c b/sys/net/if_vlan.c index 6aa872a19364..51f0bc63ebda 100644 --- a/sys/net/if_vlan.c +++ b/sys/net/if_vlan.c @@ -2074,7 +2074,7 @@ vlan_capabilities(struct ifvlan *ifv) if (p->if_capabilities & IFCAP_VLAN_HWC

Re: git: 5f11a33ceeb3 - main - if_vlan: do not enable LRO for bridge interaces

2023-08-11 Thread Kevin Bowling
I am wondering what is going on with this patch, it doesn't seem like a full fix. At the very least we should clean up the "can't disable some capabilities" message. I've been looking at this for a couple hours and am wondering what is going on in if_bridge.. it looks like it correctly loops over