Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors

Looking at this snippet: + if (!cn.status) { buf = NULL; + if (err == 0) /* keep compiler happy */ + buf = NULL; + } return (buf); } And considering the comment at contrib/bearssl/inc/bearssl_x509.h

Re: git: eb18708ec8c7 - main - syncache: accept packet with no SA when TCP_MD5SIG is set

On Wed, Jan 12, 2022 at 1:27 PM Mike Karels wrote: > Rob wrote: > > For what it's worth, this behavior is consistent with OpenBSD. > > That's a useful data point, thanks. > There is value in having the same semantics as OpenBSD for the TCP_MD5SIG option . If OpenB

Re: git: eb18708ec8c7 - main - syncache: accept packet with no SA when TCP_MD5SIG is set

On Wed, Jan 12, 2022 at 6:58 AM Mike Karels wrote: > Sorry for the delayed response; I’ve been out. > No worries. This change seems wrong to me. The TCP_MD5SIG option clearly required MD5 > signatures on all connections in the past, for many years, You're right, since 2017. Before that, TCP_

Re: git: 25392fac9488 - main - libalias: Fix splay comparsion bug

Hey Gleb, as a heads up (in case you missed it)...about a week ago Lutz mentioned he’d be AFK for three weeks. On Friday, August 6, 2021, Gleb Smirnoff wrote: > Lutz, > > Wouldn't declaring 'i' to u_short fix the root of the problem? > > On Fri, Jul 02, 2021 at 10:32:30PM +, Lutz Donnerha

Re: git: f190f9193bc1 - main - Fix fsck_ufs segfaults with gjournal (SU+J)

the least intrusive fix I can come up with at the moment, while still fixing the original bug and (hopefully) not introducing others. -Rob On Fri, May 28, 2021 at 1:21 AM Rob Wing wrote: > Hmm, I provided a fix for ( > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245907) and it appear

Re: git: f190f9193bc1 - main - Fix fsck_ufs segfaults with gjournal (SU+J)

Hmm, I provided a fix for ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245907) and it appears to have created a spiderweb of breakage - as noted by jhb and chs (in commit 84768d114951e88288024f09d4beae0956c3cf21). I’ll have some time to dig into this in the next day or two. In the meantime

Re: git: d4870e3a7256 - main - bhyve/snapshot: provide a way to send other messages/data to bhyve

shoot, I messed up - the differential revision is https://reviews.freebsd.org/D29213 On Wed, May 12, 2021 at 5:33 PM Robert Wing wrote: > The branch main has been updated by rew: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=d4870e3a7256704905655e997b37a866024c2894 > > commit d4870e3a725670

Re: git: 2a50a9de8340 - main - terminfo: add terminfo database

Rod, https://lists.freebsd.org/pipermail/freebsd-current/2020-May/076047.html not sure if that's the one Bapt was referencing...because you commented in that same thread as well, linked below. https://lists.freebsd.org/pipermail/freebsd-current/2020-May/076051.html -Rob On Fri, Feb 26, 2021 at