git: 28f6910714e3 - main - net/route: properly brace the RT_LOG() macro

2023-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=28f6910714e32138fa2b2950a22aac91c04bd053 commit 28f6910714e32138fa2b2950a22aac91c04bd053 Author: Gleb Smirnoff AuthorDate: 2023-10-19 05:21:53 + Commit: Gleb Smirnoff CommitDate: 2023-10-19

git: 2d49ff1e21a7 - main - tests/netlink: mark the vlan(4) test with required module

2023-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=2d49ff1e21a74b8f641752b63a59dc3ef9e38ddc commit 2d49ff1e21a74b8f641752b63a59dc3ef9e38ddc Author: Gleb Smirnoff AuthorDate: 2023-10-19 05:21:53 + Commit: Gleb Smirnoff CommitDate: 2023-10-19

Re: git: fabf705f4b5a - main - pf: fix pf divert-to loop

2023-10-19 Thread Gleb Smirnoff
er, uma allocator backing m_tag_alloc() will allocate same amount of memory. Sorry for not messaing that in the phabricator. -- Gleb Smirnoff

Re: git: fabf705f4b5a - main - pf: fix pf divert-to loop

2023-10-19 Thread Gleb Smirnoff
; }; idir should also be __enum_uint8(pf_mtag_dir) or a typedefed type for brevity. -- Gleb Smirnoff

git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build

2023-10-20 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=6120673f7566c35023921540d2d682572d1bf1ce commit 6120673f7566c35023921540d2d682572d1bf1ce Author: Gleb Smirnoff AuthorDate: 2023-10-20 17:47:08 + Commit: Gleb Smirnoff CommitDate: 2023-10-20

Re: git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build

2023-10-22 Thread Gleb Smirnoff
On Sat, Oct 21, 2023 at 09:07:26PM +0200, Dimitry Andric wrote: D> > commit 6120673f7566c35023921540d2d682572d1bf1ce D> > Author: Gleb Smirnoff D> > AuthorDate: 2023-10-20 17:47:08 + D> > Commit: Gleb Smirnoff D> > CommitDate: 2023-10-20 17:47:08

Re: git: c35f527ed115 - main - sx: unset td_wantedlock around going to sleep

2023-10-23 Thread Gleb Smirnoff
THREAD_CONTENTION_DONE(&sx->lock_object); M> if (!(opts & SX_INTERRUPTIBLE)) M> sleepq_wait(&sx->lock_object, 0); M> else M> error = sleepq_wait_sig(&sx->lock_object, 0); M> +THREAD_CONTENDS_ON_LOCK(&sx->lock_object); M> #ifdef KDTRACE_HOOKS M> sleep_time += lockstat_nsecs(&sx->lock_object); M> sleep_cnt++; -- Gleb Smirnoff

git: f407a72a506d - main - bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS)

2023-10-26 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=f407a72a506d2630d60d9096c42058f12dff874e commit f407a72a506d2630d60d9096c42058f12dff874e Author: Gleb Smirnoff AuthorDate: 2023-10-26 09:59:21 + Commit: Gleb Smirnoff CommitDate: 2023-10-26

Re: git: b2e41172bdc0 - main - A skeleton kernel module suitable for creating new such modules.

2023-11-14 Thread Gleb Smirnoff
s, but pretty sure that it belongs to the existing directory instead of a new one. The existing directory is also connected to the build, which makes examples installed. -- Gleb Smirnoff

git: 070d9e3540e6 - main - socket tests: add socket_accept

2023-11-16 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=070d9e3540e63540e09c915963c2fc0cc55d3b2a commit 070d9e3540e63540e09c915963c2fc0cc55d3b2a Author: Gleb Smirnoff AuthorDate: 2023-11-16 16:23:48 + Commit: Gleb Smirnoff CommitDate: 2023-11-16

git: 70e30addafe4 - main - tcp: remove extraneous network epoch entry

2023-11-16 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=70e30addafe406e01db4a6643932b73082886241 commit 70e30addafe406e01db4a6643932b73082886241 Author: Gleb Smirnoff AuthorDate: 2023-11-17 02:30:35 + Commit: Gleb Smirnoff CommitDate: 2023-11-17

git: efad7cbfdc06 - main - ng_ksocket: fix upcall clearing on node shutdown

2023-11-17 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=efad7cbfdc06e92bcc589a6c0cae2f3bea0d5cb9 commit efad7cbfdc06e92bcc589a6c0cae2f3bea0d5cb9 Author: Gleb Smirnoff AuthorDate: 2023-11-17 17:23:58 + Commit: Gleb Smirnoff CommitDate: 2023-11-17

git: 43f7e2166810 - main - ng_ksocket: fix accept(2)

2023-11-17 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=43f7e21668105cc5a3c66eae5ecef0203c2df62f commit 43f7e21668105cc5a3c66eae5ecef0203c2df62f Author: Gleb Smirnoff AuthorDate: 2023-11-17 17:24:30 + Commit: Gleb Smirnoff CommitDate: 2023-11-17

git: 367e8adb4be9 - main - tests/netgraph: start ng_socket test suite

2023-11-20 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=367e8adb4be91ca3c0d40c085eaf47467d0ad25d commit 367e8adb4be91ca3c0d40c085eaf47467d0ad25d Author: Gleb Smirnoff AuthorDate: 2023-11-20 22:36:58 + Commit: Gleb Smirnoff CommitDate: 2023-11-20

git: bbbd7aab1bed - main - inpcb: garbage collect in_pcbnotifyall()

2023-11-20 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=bbbd7aab1bed9122e7137ee0957d50c9ef22b315 commit bbbd7aab1bed9122e7137ee0957d50c9ef22b315 Author: Gleb Smirnoff AuthorDate: 2023-11-20 22:38:31 + Commit: Gleb Smirnoff CommitDate: 2023-11-20

git: 219a6ca91957 - main - tcp: uninline tcp_account_for_send()

2023-11-21 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=219a6ca919576c4f7e783720f66a458d51476f3d commit 219a6ca919576c4f7e783720f66a458d51476f3d Author: Gleb Smirnoff AuthorDate: 2023-11-21 17:21:41 + Commit: Gleb Smirnoff CommitDate: 2023-11-21

git: f90306501856 - main - hpts: install kernel module

2023-11-21 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=f9030650185622d7cf8a7c81c4b3a3763539de24 commit f9030650185622d7cf8a7c81c4b3a3763539de24 Author: Gleb Smirnoff AuthorDate: 2023-11-21 17:22:46 + Commit: Gleb Smirnoff CommitDate: 2023-11-21

git: 7edc1bd9dc17 - main - When be_activate() turns on a new boot environment, it always deactivates the current one first. And if it fails to do so, it abandons activation. However, with the new boot

2021-01-08 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=7edc1bd9dc174526c69246ba45bf2c8c230d38f4 commit 7edc1bd9dc174526c69246ba45bf2c8c230d38f4 Author: Gleb Smirnoff AuthorDate: 2021-01-08 17:23:16 + Commit: Gleb Smirnoff CommitDate: 2021-01-08

git: 2903606b6063 - main - Add missing rcvar name for os-release.

2021-01-11 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=2903606b6063b5330c2311a53ade552edf5a7cef commit 2903606b6063b5330c2311a53ade552edf5a7cef Author: Gleb Smirnoff AuthorDate: 2021-01-11 16:36:37 + Commit: Gleb Smirnoff CommitDate: 2021-01-11

git: 425f68e6ce6f - main - Follow-up on 51da4b19be1. When booting a system with WITHOUT_IPFILTER the following warning printed at boot time:

2021-01-11 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=425f68e6ce6f7a89ee8d2dfb4e8faf4b5095fdf7 commit 425f68e6ce6f7a89ee8d2dfb4e8faf4b5095fdf7 Author: Gleb Smirnoff AuthorDate: 2021-01-11 20:36:54 + Commit: Gleb Smirnoff CommitDate: 2021-01-11

git: 7e4eca7136ea - main - Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on remote filesystems. Discussed this with Brooks and he can't find evidence that provoked the change in 2005

2021-01-15 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=7e4eca7136eaa35e15f67682468f09aa7127b543 commit 7e4eca7136eaa35e15f67682468f09aa7127b543 Author: Gleb Smirnoff AuthorDate: 2021-01-11 20:13:41 + Commit: Gleb Smirnoff CommitDate: 2021-01-15

git: 4f48fd7c5677 - main - Add 'tmp' to the list of FILESYSTEMS dependencies. Some scripts that depend on FILESYSTEMS run mktemp(1). For systems that have read-only root this is broken until memory di

2021-01-15 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=4f48fd7c5677c6640cac59706d0340348a5f1d64 commit 4f48fd7c5677c6640cac59706d0340348a5f1d64 Author: Gleb Smirnoff AuthorDate: 2021-01-11 19:11:29 + Commit: Gleb Smirnoff CommitDate: 2021-01-15

git: cf6ff85fe847 - main - Catch up with 6edfd179c86: document M_EXTPG. While here sore flags as they are in sys/mbuf.h

2021-01-29 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=cf6ff85fe847225e7b7ca1c3669cab6412076765 commit cf6ff85fe847225e7b7ca1c3669cab6412076765 Author: Gleb Smirnoff AuthorDate: 2021-01-28 20:56:36 + Commit: Gleb Smirnoff CommitDate: 2021-01-29

git: 3f43ada98c89 - main - Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG.

2021-01-29 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=3f43ada98c89bce5ae416e203ba0e81595a5cd88 commit 3f43ada98c89bce5ae416e203ba0e81595a5cd88 Author: Gleb Smirnoff AuthorDate: 2021-01-28 21:08:48 + Commit: Gleb Smirnoff CommitDate: 2021-01-29

Re: git: 3f43ada98c89 - main - Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG.

2021-01-29 Thread Gleb Smirnoff
On Fri, Jan 29, 2021 at 02:20:31PM -0800, John Baldwin wrote: J> On 1/29/21 12:10 PM, Gleb Smirnoff wrote: J> > The branch main has been updated by glebius: J> > J> > URL: https://cgit.FreeBSD.org/src/commit/?id=3f43ada98c89bce5ae416e203ba0e81595a5c

git: 0ace2cce386a - stable/13 - Catch up with 6edfd179c86: document M_EXTPG. While here sore flags as they are in sys/mbuf.h

2021-02-08 Thread Gleb Smirnoff
The branch stable/13 has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=0ace2cce386aebfe4eab3741f61a9c497316426d commit 0ace2cce386aebfe4eab3741f61a9c497316426d Author: Gleb Smirnoff AuthorDate: 2021-01-28 20:56:36 + Commit: Gleb Smirnoff CommitDate: 2021-02

git: 97ded49caef6 - stable/13 - Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG.

2021-02-08 Thread Gleb Smirnoff
The branch stable/13 has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=97ded49caef6a97994655f5e065c3591359ee8d3 commit 97ded49caef6a97994655f5e065c3591359ee8d3 Author: Gleb Smirnoff AuthorDate: 2021-01-28 21:08:48 + Commit: Gleb Smirnoff CommitDate: 2021-02

git: be578b67b5a5 - main - tcp_twcheck(): use correct unlock macro.

2021-05-06 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=be578b67b5a5bedbbec61c7164875b6b1e1b8fff commit be578b67b5a5bedbbec61c7164875b6b1e1b8fff Author: Gleb Smirnoff AuthorDate: 2021-05-06 17:19:21 + Commit: Gleb Smirnoff CommitDate: 2021-05-06

git: a693d17b9985 - main - pf: fix !INET or !INET6 builds

2022-03-16 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=a693d17b9985a03bd9b5108e890d669005ab41eb commit a693d17b9985a03bd9b5108e890d669005ab41eb Author: Gleb Smirnoff AuthorDate: 2022-03-16 19:52:07 + Commit: Gleb Smirnoff CommitDate: 2022-03-16

Re: git: 6ca0ca7b4cb5 - main - IPv4 multicast: fix LOR in shutdown path

2022-04-11 Thread Gleb Smirnoff
ask. I think this is fine. - This will require some locking. But if_amcount (and other similar fields) aren't properly locked now, so locking of interface flags and their counts is required anyway. -- Gleb Smirnoff

git: c4804b6b0b94 - main - Unbreak TFO, that was broken with 8d5719aa74f. These two assignments are unneccessary and used to be there before TFO as an invariant. With TFO and after 8d5719aa74f the "so

2021-06-22 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c4804b6b0b94f1c7228b62114bf294d63f6db2b7 commit c4804b6b0b94f1c7228b62114bf294d63f6db2b7 Author: Gleb Smirnoff AuthorDate: 2021-06-22 23:03:44 + Commit: Gleb Smirnoff CommitDate: 2021-06-22

Re: git: f13da24715a7 - main - net/bpf: Fix writing of buffer bigger than PAGESIZE

2021-06-23 Thread Gleb Smirnoff
m = m_getjcl(M_WAITOK, MT_DATA, M_PKTHDR, MJUM9BYTES); W> +else if (len <= MJUM16BYTES) W> +m = m_getjcl(M_WAITOK, MT_DATA, M_PKTHDR, MJUM16BYTES); W> +else W> +m = NULL; W> if (m == NULL) W> return (EIO); W> m->

git: 29b4fa787621 - main - hdaa: add missing break in hdac_pin_patch().

2021-08-03 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=29b4fa787621cbfb070323ecf2ea2da4d372bd94 commit 29b4fa787621cbfb070323ecf2ea2da4d372bd94 Author: Gleb Smirnoff AuthorDate: 2021-08-03 10:06:16 + Commit: Gleb Smirnoff CommitDate: 2021-08-03

Re: git: 25392fac9488 - main - libalias: Fix splay comparsion bug

2021-08-06 Thread Gleb Smirnoff
type; L> if (i != 0) return (i); L> -i = a->alias_addr.s_addr - b->alias_addr.s_addr; L> -return (i); L> +if (a->alias_addr.s_addr > b->alias_addr.s_addr) return (1); L> +if (a->alias_addr.s_addr < b->alias_addr.s_addr) return (-1); L> +ret

Re: git: 2f4d91f9cb22 - main - libalias: Rewrite HISTORY

2021-08-06 Thread Gleb Smirnoff
L> dev-commits-src-all@freebsd.org mailing list L> https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all L> To unsubscribe, send any mail to "dev-commits-src-all-unsubscr...@freebsd.org" -- Gleb Smirnoff ___ dev-commits-src-

git: dfc4d218ce5d - main - tcp: use straight in_pcbconnect() in tcp_connect()

2023-02-07 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=dfc4d218ce5d9e1d1d2be09c6cfc3d1c89ad27ff commit dfc4d218ce5d9e1d1d2be09c6cfc3d1c89ad27ff Author: Gleb Smirnoff AuthorDate: 2023-02-07 17:21:52 + Commit: Gleb Smirnoff CommitDate: 2023-02-07

git: 220d89212943 - main - inpcb: immediately return matching pcb on lookup

2023-02-07 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=220d892129439e4596b8ef054f56b6e0ede03538 commit 220d892129439e4596b8ef054f56b6e0ede03538 Author: Gleb Smirnoff AuthorDate: 2023-02-07 17:21:52 + Commit: Gleb Smirnoff CommitDate: 2023-02-07

git: a22561501ff8 - main - net: use pfil_mbuf_{in,out} where we always have an mbuf

2023-02-14 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=a22561501ff807b227305617ea2fb46072ce8b06 commit a22561501ff807b227305617ea2fb46072ce8b06 Author: Gleb Smirnoff AuthorDate: 2023-02-14 18:02:49 + Commit: Gleb Smirnoff CommitDate: 2023-02-14

git: caf32b260ad4 - main - pfil: add pfil_mem_{in,out}() and retire pfil_run_hooks()

2023-02-14 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=caf32b260ad46b17a4c1a8ce6383e37ac489f023 commit caf32b260ad46b17a4c1a8ce6383e37ac489f023 Author: Gleb Smirnoff AuthorDate: 2023-02-14 18:02:49 + Commit: Gleb Smirnoff CommitDate: 2023-02-14

git: 96871af01382 - main - inpcb: use family specific sockaddr argument for bind functions

2023-02-15 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=96871af01382ecaec59ccbf6999ba8ad76a5f9e9 commit 96871af01382ecaec59ccbf6999ba8ad76a5f9e9 Author: Gleb Smirnoff AuthorDate: 2023-02-15 18:30:16 + Commit: Gleb Smirnoff CommitDate: 2023-02-15

git: 71e70c25c008 - main - Revert "unix/dgram: return EAGAIN instead of ENOBUFS when O_NONBLOCK set"

2023-02-21 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=71e70c25c0085a4e6e5eef834ca8a29b65435d62 commit 71e70c25c0085a4e6e5eef834ca8a29b65435d62 Author: Gleb Smirnoff AuthorDate: 2023-02-21 16:50:07 + Commit: Gleb Smirnoff CommitDate: 2023-02-21

Re: git: ef6fcc5e2b07 - main - nfsd: Add VNET_SYSUNINIT() macros for vnet cleanup

2023-02-21 Thread Gleb Smirnoff
te VNET_SYSUNINIT() that is complement to VNET_SYSINIT() * makes it easier to write SYSUNINIT(), if module is unloadable * sometimes global SYSINIT cab be avoided, if a static initializer is enough What do you guys think? -- Gleb Smirnoff

Re: git: 453aa7fac989 - main - tcp: ensure the tcpcb is not NULL when logging an event

2023-02-22 Thread Gleb Smirnoff
therefore handle it. I wonder when does that happen? IMHO better fix such calls than plug the problem here. -- Gleb Smirnoff

git: a17065710862 - main - unix/dgram tests: match the kernel behavior

2023-02-22 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=a170657108623cd48e3d695ca74c428a564912ee commit a170657108623cd48e3d695ca74c428a564912ee Author: Gleb Smirnoff AuthorDate: 2023-02-23 04:44:46 + Commit: Gleb Smirnoff CommitDate: 2023-02-23

Re: git: ef6fcc5e2b07 - main - nfsd: Add VNET_SYSUNINIT() macros for vnet cleanup

2023-02-22 Thread Gleb Smirnoff
age in TCP/IP. Please fill free to commandeer those reviews from me and finalize them if you agree with general idea. -- Gleb Smirnoff

Re: git: ef6fcc5e2b07 - main - nfsd: Add VNET_SYSUNINIT() macros for vnet cleanup

2023-02-23 Thread Gleb Smirnoff
simple - just wrap every global variable into VNET() macro and you are done. Don't make non-default vnet in any sense different to the default one! It actually works pretty good if the recipe is being followed. Sometimes this leads to pretty large mechanical changes, and people try to avoid that.

git: d8c70d6dfb65 - main - nanobsd: fix typo

2023-02-27 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=d8c70d6dfb65218dd3272b34512083621d3ed46d commit d8c70d6dfb65218dd3272b34512083621d3ed46d Author: Gleb Smirnoff AuthorDate: 2023-02-27 19:26:18 + Commit: Gleb Smirnoff CommitDate: 2023-02-27

git: 5f7bea295283 - main - iflib: fix regression with new pfil(9) KPI

2023-02-28 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=5f7bea2952830ae60d4b65dafdc8411ac9d991f0 commit 5f7bea2952830ae60d4b65dafdc8411ac9d991f0 Author: Gleb Smirnoff AuthorDate: 2023-02-28 16:56:20 + Commit: Gleb Smirnoff CommitDate: 2023-02-28

git: 7fc82fd1f82e - main - ipfw: garbage collect ip_fw_chk_ptr

2023-03-03 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=7fc82fd1f82eb37ff52a9199f1e7d640748811ba commit 7fc82fd1f82eb37ff52a9199f1e7d640748811ba Author: Gleb Smirnoff AuthorDate: 2023-03-03 18:29:44 + Commit: Gleb Smirnoff CommitDate: 2023-03-03

Re: git: 35b6e52c30a2 - main - net.inet6.ip6.log_interval: use ppsratecheck(9) internally

2023-03-13 Thread Gleb Smirnoff
ews.freebsd.org/D38758 I'd suggest to use counter_ratecheck() as we do with IPv4 ICMP. I can provide you a patch if you are willing to test it. -- Gleb Smirnoff

Re: git: 5091ca26507b - main - pf: save on branching in the common case in pf_test

2021-09-09 Thread Gleb Smirnoff
ation for a setup without divert(4) at cost of pessimization for a setup with divert(4). IMHO, __predict_false() predicate should guard against error paths and other unusual events, not favor one setup over other. -- Gleb Smirnoff ___ dev-commits-src-all@freebsd

git: 26cf4b53d9c1 - main - netgraph: pass return value from callout_stop() unmodified to callers of ng_uncallout. Most of them do not check it anyway, so very little node changes are required.

2021-09-10 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=26cf4b53d9c12238479d4b2068d3037cb1940a39 commit 26cf4b53d9c12238479d4b2068d3037cb1940a39 Author: Gleb Smirnoff AuthorDate: 2021-08-06 20:12:13 + Commit: Gleb Smirnoff CommitDate: 2021-09-10

git: 0a76c63dd498 - main - ng_l2tp: improve seq structure locking.

2021-09-10 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=0a76c63dd4987d8f7af37fe93569ce8a020cf43e commit 0a76c63dd4987d8f7af37fe93569ce8a020cf43e Author: Gleb Smirnoff AuthorDate: 2021-08-06 22:49:51 + Commit: Gleb Smirnoff CommitDate: 2021-09-10

git: 89042ff77668 - main - ng_l2tp: improve callout locking.

2021-09-10 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=89042ff77668555e77c88549e6ba697088ee72f9 commit 89042ff77668555e77c88549e6ba697088ee72f9 Author: Gleb Smirnoff AuthorDate: 2021-08-06 23:04:31 + Commit: Gleb Smirnoff CommitDate: 2021-09-10

git: b2954f0a8f7d - main - netgraph: add ng_uncallout_drain().

2021-09-10 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=b2954f0a8f7db160053555d4ad86ce3abf036077 commit b2954f0a8f7db160053555d4ad86ce3abf036077 Author: Gleb Smirnoff AuthorDate: 2021-08-06 20:16:32 + Commit: Gleb Smirnoff CommitDate: 2021-09-10

Re: git: 5091ca26507b - main - pf: save on branching in the common case in pf_test

2021-09-10 Thread Gleb Smirnoff
doing divert without M> having to check for it, but that's far in the future. That would be great, but before we have such tools, I believe optimization for one particular setup at cost of pessimization of other setups is not a way to go. -- Gleb Smirnoff __

Re: git: 2e5ff01d0a1f - main - if_vlan: add the ALTQ support to if_vlan.

2021-09-10 Thread Gleb Smirnoff
irtual interface may classify traffic, but actual queueing should happen only at the point of physical bottlneck - the NIC. Anyway, if somebody builds useful setups with such hack, let it live. Same rationale was used when adding ALTQ to other virtual interfaces. Just grumbling. -- Gleb Sm

git: c96b4d87ba33 - main - pkg: fix regression that breaks bootstrap from not a current directory.

2021-09-10 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c96b4d87ba3336e6d4bea04c49d6abde158b7aae commit c96b4d87ba3336e6d4bea04c49d6abde158b7aae Author: Gleb Smirnoff AuthorDate: 2021-09-10 21:49:17 + Commit: Gleb Smirnoff CommitDate: 2021-09-10

Re: git: 5091ca26507b - main - pf: save on branching in the common case in pf_test

2021-09-17 Thread Gleb Smirnoff
rd and should not measurably hurt M> divert. I understand your concerns, but this is the reality of network. A machine supports multiple protocols and encapsulations or whatever the same time. I understand, that some machines and workloads would work 99% of the time on just one protocol. So you cr

git: c6213beff4f5 - main - Add flag BIO_SWAP to mark IOs that are associated with swap.

2021-09-28 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c6213beff4f51d6c9cc4e41682538d203249359e commit c6213beff4f51d6c9cc4e41682538d203249359e Author: Gleb Smirnoff AuthorDate: 2021-09-28 18:11:50 + Commit: Gleb Smirnoff CommitDate: 2021-09-28

git: 183f8e1e575b - main - Externalize nsw_cluster_max and initialize it early.

2021-09-28 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=183f8e1e575b526515e70400a22af243cd1a4a78 commit 183f8e1e575b526515e70400a22af243cd1a4a78 Author: Gleb Smirnoff AuthorDate: 2021-09-28 18:13:33 + Commit: Gleb Smirnoff CommitDate: 2021-09-28

git: 2dbc9a388eeb - main - Fix memory deadlock when GELI partition is used for swap.

2021-09-28 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=2dbc9a388eeb73a6b17eb6fd1349a2a7e95123cc commit 2dbc9a388eeb73a6b17eb6fd1349a2a7e95123cc Author: Gleb Smirnoff AuthorDate: 2021-09-28 18:19:29 + Commit: Gleb Smirnoff CommitDate: 2021-09-28

Re: git: c6213beff4f5 - main - Add flag BIO_SWAP to mark IOs that are associated with swap.

2021-09-28 Thread Gleb Smirnoff
Ian, On Tue, Sep 28, 2021 at 12:26:34PM -0600, Ian Lepore wrote: I> > URL: I> > https://cgit.FreeBSD.org/src/commit/?id=c6213beff4f51d6c9cc4e41682538d203249359e I> > I> > commit c6213beff4f51d6c9cc4e41682538d203249359e I> > Author: Gleb Smirnoff I> > A

git: b984d153e057 - main - Don't set GELI UMA zone as UMA_ZONE_NOFREE.

2021-10-01 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=b984d153e057b7879632b8e6015a05ce3f177580 commit b984d153e057b7879632b8e6015a05ce3f177580 Author: Gleb Smirnoff AuthorDate: 2021-10-01 17:24:50 + Commit: Gleb Smirnoff CommitDate: 2021-10-01

git: a37e4fd1ea8c - main - Re-style dfcef8771484 to keep the code and variables related to listening sockets separated from code for generic sockets.

2021-10-01 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=a37e4fd1ea8ccb2a5e54083d7cfc7b1b1784072d commit a37e4fd1ea8ccb2a5e54083d7cfc7b1b1784072d Author: Gleb Smirnoff AuthorDate: 2021-10-01 20:38:24 + Commit: Gleb Smirnoff CommitDate: 2021-10-01

git: 964b8f8b993d - main - ifnet: garbage collect unused function ifaddr_byindex().

2022-01-28 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=964b8f8b993d48f66a3d3b46a4cd67c1f6d1e326 commit 964b8f8b993d48f66a3d3b46a4cd67c1f6d1e326 Author: Gleb Smirnoff AuthorDate: 2022-01-28 17:51:52 + Commit: Gleb Smirnoff CommitDate: 2022-01-28

Re: git: 91f44749c6fe - main - ifnet: make if_index global

2022-01-31 Thread Gleb Smirnoff
NET for their lifetime, so less problems would exist. I already lost count of problems created by if_vmove :( M> Sorry for chiming in late, but my sentiment against this change is M> obvious... I'm also sorry for not including you in the review. Please add yourself to https://reviews.freebsd.org/project/members/24/ -- Gleb Smirnoff

Re: git: 91f44749c6fe - main - ifnet: make if_index global

2022-02-01 Thread Gleb Smirnoff
. -- Gleb Smirnoff

Re: git: 91f44749c6fe - main - ifnet: make if_index global

2022-02-01 Thread Gleb Smirnoff
, that was maintaining two indexes a M> > virtual and non-virtual: M> > M> > https://reviews.freebsd.org/D33265 M> > M> > If you ask me of a perfect version of this design, I would say same M> > thing I already said in other topics: if_vmove shall not exist. M> M> If if_vmove() did not exist, how would we move real ifnets (such as M> em / bge / igb), or vlan cloners attached to those, from vnet0 to M> another vnet, and vice versa? Instead of if_vmove() there should have been a KPI that would allow fully detach and free an interface from the driver and then allocate and attach a different instance again in a different VNET. -- Gleb Smirnoff

Re: git: 91f44749c6fe - main - ifnet: make if_index global

2022-02-02 Thread Gleb Smirnoff
are now. Back in December this approach lead to dummynet tests to keep panicing, however fixing real life scenatios. But now, with 80fc25025ff, I suppose it shall pass all tests and indeed fix the problem for real life scenarios. -- Gleb Smirnoff

Re: git: 0c424c90eaa6 - main - tcp: move ECN handling code to a common file

2022-02-05 Thread Gleb Smirnoff
e is no reason to use KMOD_TCPSTAT_INC() in the tcp_ecn.c. Now it is a file statically compiled into kernel, unlike RACK or BBR. It should use just TCPSTAT_INC(). -- Gleb Smirnoff

Re: git: 1790549d801f - main - tcp: use TCPSTAT_INC in kernel ecn functions

2022-02-05 Thread Gleb Smirnoff
R> R> Both eventually resolve to counter_s64_add(), but better R> use the correct macros. Yep. The non-kmod version will calculate stat offset at compile time and counter_u64_add() will be inlined. This all will end in literally one instruction (on amd64) instead of a function call. -- Gleb Smirnoff

git: c999e3481d93 - main - dmesg: detect wrapped msgbuf on the kernel side and if so, skip first line

2022-02-05 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c999e3481d936980354d09e3d6a138e5dde5fabc commit c999e3481d936980354d09e3d6a138e5dde5fabc Author: Gleb Smirnoff AuthorDate: 2022-02-05 21:25:38 + Commit: Gleb Smirnoff CommitDate: 2022-02-05

git: d2e24c54ef83 - stable/13 - nd6: use CARP link level address in SLLAO for NS sent out

2022-02-07 Thread Gleb Smirnoff
The branch stable/13 has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=d2e24c54ef8311a053eddb05a0ce336daf890abb commit d2e24c54ef8311a053eddb05a0ce336daf890abb Author: Thomas Steen Rasmussen AuthorDate: 2022-01-25 05:02:47 + Commit: Gleb Smirnoff CommitDate

git: 65572cade35a - main - unix/dgram: return EAGAIN instead of ENOBUFS when O_NONBLOCK set

2022-02-14 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=65572cade35a93add2168a7a012f808ac499218b commit 65572cade35a93add2168a7a012f808ac499218b Author: Gleb Smirnoff AuthorDate: 2022-02-14 17:21:55 + Commit: Gleb Smirnoff CommitDate: 2022-02-14

git: d2b3a0ed31ef - main - sendto: don't clear transient errors for atomic protocols

2022-02-23 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=d2b3a0ed31ef6270c712d0779a95bb222df88909 commit d2b3a0ed31ef6270c712d0779a95bb222df88909 Author: Gleb Smirnoff AuthorDate: 2022-02-17 17:07:31 + Commit: Gleb Smirnoff CommitDate: 2022-02-23

Re: git: c05b382edb17 - main - Revert "bootstrap: No need to disable shared libraries for bootstrap tools"

2021-10-11 Thread Gleb Smirnoff
ain -DNO_CLEAN" before building a kernel: M> https://syzkaller.appspot.com/text?tag=CrashLog&x=10b4cb98b0 I have exactly same failure on absolutely clean amd64 build. Thanks for reverting, I wonder how did it work locally. -- Gleb Smirnoff

git: 2144431c1152 - main - Remove in_ifaddr_lock acquisiton to access in_ifaddrhead.

2021-10-13 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=2144431c11529d1107f4440a5fe57559fb20002c commit 2144431c11529d1107f4440a5fe57559fb20002c Author: Gleb Smirnoff AuthorDate: 2021-10-08 19:56:24 + Commit: Gleb Smirnoff CommitDate: 2021-10-13

Re: git: 0a76c63dd498 - main - ng_l2tp: improve seq structure locking.

2021-10-18 Thread Gleb Smirnoff
experience a bug when some network-associated program (usually ifconfig) blocks forever in kernel, please get in touch with me. On Fri, Sep 10, 2021 at 06:28:00PM +, Gleb Smirnoff wrote: T> The branch main has been updated by glebius: T> T> URL: https://cgit.FreeBSD.org/src/c

git: 5a78df20ce77 - main - in_pcb: garbage collect unused structure in_pcblist

2021-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=5a78df20ce77e418503d0264d3daa26487908b1f commit 5a78df20ce77e418503d0264d3daa26487908b1f Author: Gleb Smirnoff AuthorDate: 2021-04-27 17:43:56 + Commit: Gleb Smirnoff CommitDate: 2021-10-18

git: 744a64bd920c - main - in_pcb: garbage collect in_pcbrele()

2021-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=744a64bd920c79b74a695a53cddfbecee4935c05 commit 744a64bd920c79b74a695a53cddfbecee4935c05 Author: Gleb Smirnoff AuthorDate: 2021-04-27 22:11:08 + Commit: Gleb Smirnoff CommitDate: 2021-10-18

git: 147f018a720b - main - Move in6_pcbsetport() to in6_pcb.c

2021-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=147f018a720b80da4ba61bec90a6efc6eaa4913e commit 147f018a720b80da4ba61bec90a6efc6eaa4913e Author: Gleb Smirnoff AuthorDate: 2021-10-18 17:11:20 + Commit: Gleb Smirnoff CommitDate: 2021-10-18

git: 0f617ae48a91 - main - Add in_pcb_var.h for KPIs that are private to in_pcb.c and in6_pcb.c.

2021-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=0f617ae48a911caab3130d0e80cfb425bc3b653b commit 0f617ae48a911caab3130d0e80cfb425bc3b653b Author: Gleb Smirnoff AuthorDate: 2021-10-18 17:14:03 + Commit: Gleb Smirnoff CommitDate: 2021-10-18

git: 9b7501e7977c - main - in_mcast: garbage collect inp_gcmoptions()

2021-10-18 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=9b7501e7977c1f4a0a4a798cdf0af64846009df8 commit 9b7501e7977c1f4a0a4a798cdf0af64846009df8 Author: Gleb Smirnoff AuthorDate: 2021-10-18 18:36:07 + Commit: Gleb Smirnoff CommitDate: 2021-10-18

git: 32723a3ba961 - main - sockstat: make err(3) on jail errors more verbose.

2021-10-19 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=32723a3ba9611d7947ccf639fcdef5fa0b330571 commit 32723a3ba9611d7947ccf639fcdef5fa0b330571 Author: Gleb Smirnoff AuthorDate: 2021-10-19 16:46:41 + Commit: Gleb Smirnoff CommitDate: 2021-10-19

git: 1fec1fa8146d - main - sockstat: don't query jail vnet if system is running without VIMAGE.

2021-10-19 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=1fec1fa8146dc3b3244955afe337c4e9892ccb4b commit 1fec1fa8146dc3b3244955afe337c4e9892ccb4b Author: Gleb Smirnoff AuthorDate: 2021-10-19 16:47:54 + Commit: Gleb Smirnoff CommitDate: 2021-10-19

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-20 Thread Gleb Smirnoff
e used on servers, rather than on laptops. If somebody is using vt(4) instead of X on a laptop, then this person is special. Either really impared, as Shawn suggested, or just a geek who hates GUI. In the latter case, they should tweak the configuration. -- Gleb Smirnoff

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-21 Thread Gleb Smirnoff
op to this point, so can't test. How is that possible that vt(4) affects X11? -- Gleb Smirnoff

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-21 Thread Gleb Smirnoff
x27;m looking forward to upgrade my desktop past your commit and expecting my BELOVED bell to be turned off. Just like you, I hate idea of tweaking configuration, I want it ON by default as it used to be from the beginning of times. Unlike Slawa, I got commit bit, so I can go and turn it back on. So, yeah, looks like creating a poll about a precious bell could be a solution of this dispute. -- Gleb Smirnoff

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-22 Thread Gleb Smirnoff
On Thu, Oct 21, 2021 at 09:58:31PM +0300, Vladimir Kondratyev wrote: V> On 21.10.2021 20:03, Gleb Smirnoff wrote: V> > On Thu, Oct 21, 2021 at 11:02:14AM +0300, Slawa Olhovchenkov wrote: V> > S> > laptops. If somebody is using vt(4) instead of X on a laptop, then V> &

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-22 Thread Gleb Smirnoff
produces no sound at all. J> J> FYI, Xorg server beeps via xf86OSRingBell(), i.e., J> J> https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/os-support/bsd/bsd_bell.c#L61 J> J> IOW, if console cannot beep, xterm does not beep. Oh! Thanks for explanation! -- Gleb Smirnoff

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-22 Thread Gleb Smirnoff
thms, the poll may show up even in feed of people who don't follow Warner or retwitters directly. You know, some people love to express their opinion on social media, so why not to click on the poll, to help those FreeBSD guys? To sum up, we are asking semi-random set of people a question charged with a correct answer. What would you expect? -- Gleb Smirnoff

Re: git: 225639e7db68 - main - vt: Disable bell by default

2021-10-22 Thread Gleb Smirnoff
do to distort who sees it. And likely a dozen W> other W> factors I've not even thought of. W> W> Warner W> W> P.S. We likely should fix this bug, and also change the note to 880, which W> is W> A5 (the second A above middle C). Please see W> https://reviews.freebsd.org/D32594 W> for a fix for the bug I found here. -- Gleb Smirnoff

git: fba15546837f - stable/13 - Mark sppp(4) as gone in FreeBSD 14.

2021-10-22 Thread Gleb Smirnoff
The branch stable/13 has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=fba15546837fe7285a15487a3fee93e551dc5be2 commit fba15546837fe7285a15487a3fee93e551dc5be2 Author: Gleb Smirnoff AuthorDate: 2021-10-22 18:27:00 + Commit: Gleb Smirnoff CommitDate: 2021-10

git: 6aae3517ed25 - main - Retire synchronous PPP kernel driver sppp(4).

2021-10-22 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=6aae3517ed2500fb963ba0a4264b4756088dd0f4 commit 6aae3517ed2500fb963ba0a4264b4756088dd0f4 Author: Gleb Smirnoff AuthorDate: 2021-10-21 04:08:13 + Commit: Gleb Smirnoff CommitDate: 2021-10-22

git: c2426723394b - main - Fix sconfig(8) build.

2021-10-22 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c2426723394ba9ab8ffa0d69bd132af1aaa2ea12 commit c2426723394ba9ab8ffa0d69bd132af1aaa2ea12 Author: Gleb Smirnoff AuthorDate: 2021-10-22 20:28:44 + Commit: Gleb Smirnoff CommitDate: 2021-10-22

git: c8ee75f2315e - main - Use network epoch to protect local IPv4 addresses hash.

2021-10-22 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c8ee75f2315e8267ad814dc5b4645ef205f0e0e1 commit c8ee75f2315e8267ad814dc5b4645ef205f0e0e1 Author: Gleb Smirnoff AuthorDate: 2021-10-10 17:02:26 + Commit: Gleb Smirnoff CommitDate: 2021-10-22

git: f2d266f3b081 - main - Don't run ip_ctloutput() for divert socket.

2021-10-25 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=f2d266f3b0815a364289320385f94c3f87dc3c40 commit f2d266f3b0815a364289320385f94c3f87dc3c40 Author: Gleb Smirnoff AuthorDate: 2021-10-22 23:24:56 + Commit: Gleb Smirnoff CommitDate: 2021-10-25

git: d89c820b0da1 - main - Remove div_ctlinput().

2021-10-25 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=d89c820b0da17992d4ccd8a075c1b81382cef1a9 commit d89c820b0da17992d4ccd8a075c1b81382cef1a9 Author: Gleb Smirnoff AuthorDate: 2021-10-22 23:21:10 + Commit: Gleb Smirnoff CommitDate: 2021-10-25

git: e28330832be4 - main - tcp: socket option to get stack alias name

2021-10-27 Thread Gleb Smirnoff
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=e28330832be41d2ef012dda1dafef25895ab2c6b commit e28330832be41d2ef012dda1dafef25895ab2c6b Author: Peter Lei AuthorDate: 2021-10-26 03:08:54 + Commit: Gleb Smirnoff CommitDate: 2021-10-27 15:21

  1   2   3   4   5   6   7   8   9   10   >