Re: git: 7bcc7a0b88cc - stable/14 - libkern: avoid local var in order_base_2()

2025-02-11 Thread Zhenlei Huang
> On Feb 11, 2025, at 1:23 PM, Jessica Clarke wrote: > > On 11 Feb 2025, at 03:30, Zhenlei Huang > wrote: >>> On Feb 10, 2025, at 7:15 PM, Doug Moore wrote: >>> >>> The branch stable/14 has been updated by dougm: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit

Re: git: 7bcc7a0b88cc - stable/14 - libkern: avoid local var in order_base_2()

2025-02-10 Thread Jessica Clarke
On 11 Feb 2025, at 03:30, Zhenlei Huang wrote: >> On Feb 10, 2025, at 7:15 PM, Doug Moore wrote: >> >> The branch stable/14 has been updated by dougm: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=7bcc7a0b88ccb5e1fe31de88ab9a17e46859318b >> >> commit 7bcc7a0b88ccb5e1fe31de88ab9a17e468

Re: git: 7bcc7a0b88cc - stable/14 - libkern: avoid local var in order_base_2()

2025-02-10 Thread Doug Moore
b...@freebsd.org presented the problem that this change fixed.  I think it was in a driver.  It may have been a case in which the macro argument had side effects, and having it appear twice in the macro made those side effects happen twice.  But I have not preserved the original report from bz.

Re: git: 7bcc7a0b88cc - stable/14 - libkern: avoid local var in order_base_2()

2025-02-10 Thread Zhenlei Huang
> On Feb 10, 2025, at 7:15 PM, Doug Moore wrote: > > The branch stable/14 has been updated by dougm: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7bcc7a0b88ccb5e1fe31de88ab9a17e46859318b > > commit 7bcc7a0b88ccb5e1fe31de88ab9a17e46859318b > Author: Doug Moore > AuthorDate: 2024-0

git: 7bcc7a0b88cc - stable/14 - libkern: avoid local var in order_base_2()

2025-02-10 Thread Doug Moore
The branch stable/14 has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=7bcc7a0b88ccb5e1fe31de88ab9a17e46859318b commit 7bcc7a0b88ccb5e1fe31de88ab9a17e46859318b Author: Doug Moore AuthorDate: 2024-09-27 23:43:07 + Commit: Doug Moore CommitDate: 2025-02-10 10:30