Re: generated sources Was: git: 408957613bc0 - main - Regen

2024-06-10 Thread John Baldwin
On 5/23/24 2:37 PM, Brooks Davis wrote: On Thu, May 23, 2024 at 11:20:08AM -0700, Gleb Smirnoff wrote: Hi, sorry for slightly diverting the discussion, but looks like this thread is the right place... On Wed, May 22, 2024 at 12:55:24PM -0700, John Baldwin wrote: J> I don't think it's worth

Re: git: 408957613bc0 - main - Regen

2024-05-23 Thread Brooks Davis
On Fri, May 24, 2024 at 01:10:04AM +0100, Lexi Winter wrote: > Brooks Davis: > > This is more or less standard practice for generated files. These > > commits are of basically no interest. > > to be clear, i'm certainly not expecting a detailed commit message for > things like this. my only conc

Re: git: 408957613bc0 - main - Regen

2024-05-23 Thread Lexi Winter
Brooks Davis: > This is more or less standard practice for generated files. These > commits are of basically no interest. to be clear, i'm certainly not expecting a detailed commit message for things like this. my only concern is that when viewing the commit log for all of src/, or for src/sys/

Re: generated sources Was: git: 408957613bc0 - main - Regen

2024-05-23 Thread Brooks Davis
On Thu, May 23, 2024 at 11:20:08AM -0700, Gleb Smirnoff wrote: > Hi, > > sorry for slightly diverting the discussion, but looks like this thread is the > right place... > > On Wed, May 22, 2024 at 12:55:24PM -0700, John Baldwin wrote: > J> I don't think it's worth reverting at this point. For

generated sources Was: git: 408957613bc0 - main - Regen

2024-05-23 Thread Gleb Smirnoff
Hi, sorry for slightly diverting the discussion, but looks like this thread is the right place... On Wed, May 22, 2024 at 12:55:24PM -0700, John Baldwin wrote: J> I don't think it's worth reverting at this point. For `make sysent` I would J> suggest 'sysent: Regen' as a commit log in the futur

Re: git: 408957613bc0 - main - Regen

2024-05-22 Thread John Baldwin
On 5/22/24 3:36 AM, Dmitry Salychev wrote: Lexi Winter writes: [[PGP Signed Part:Undecided]] Mariusz Zaborski: The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c812c3ae276ace03697ebd commit 408957613bc065c812c3ae276ace03697ebd

Re: git: 408957613bc0 - main - Regen

2024-05-22 Thread Brooks Davis
On Wed, May 22, 2024 at 08:55:51AM +0100, Lexi Winter wrote: > Mariusz Zaborski: > > The branch main has been updated by oshogbo: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c812c3ae276ace03697ebd > > > > commit 408957613bc065c812c3ae276ace03697ebd > > Author:

Re: git: 408957613bc0 - main - Regen

2024-05-22 Thread Mariusz Zaborski
Hello, Not really as a mistake :) The files in question have many such commits (not only committed by me). So I have assumed this is a common practice. I'm happy to provide more details next time. However, I don't plan to revert it at this point as it seems pointless to complicate the log even mor

Re: git: 408957613bc0 - main - Regen

2024-05-22 Thread Dmitry Salychev
Lexi Winter writes: > [[PGP Signed Part:Undecided]] > Mariusz Zaborski: >> The branch main has been updated by oshogbo: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c812c3ae276ace03697ebd >> >> commit 408957613bc065c812c3ae276ace03697ebd >> Author: Mariusz

Re: git: 408957613bc0 - main - Regen

2024-05-22 Thread Lexi Winter
Mariusz Zaborski: > The branch main has been updated by oshogbo: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c812c3ae276ace03697ebd > > commit 408957613bc065c812c3ae276ace03697ebd > Author: Mariusz Zaborski > AuthorDate: 2024-05-21 20:02:50 + > Commit: M

git: 408957613bc0 - main - Regen

2024-05-21 Thread Mariusz Zaborski
The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c812c3ae276ace03697ebd commit 408957613bc065c812c3ae276ace03697ebd Author: Mariusz Zaborski AuthorDate: 2024-05-21 20:02:50 + Commit: Mariusz Zaborski CommitDate: 2024-05