Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS

2021-08-05 Thread Hans Petter Selasky
On 8/5/21 8:49 PM, Hans Petter Selasky wrote: On 8/5/21 7:10 PM, Andrew Gallatin wrote: +    tsleep_sbt(sc, PZERO, "waiting for work", SBT_MAX, SBT_1S, 0); Hi, This basically puts a useless callout into the timer subsystem forever. I think if you don't care about this tsleep being accura

Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS

2021-08-05 Thread Hans Petter Selasky
On 8/5/21 7:10 PM, Andrew Gallatin wrote: + tsleep_sbt(sc, PZERO, "waiting for work", SBT_MAX, SBT_1S, 0); Hi, This basically puts a useless callout into the timer subsystem forever. I think if you don't care about this tsleep being accurate, then lock Giant and use sbt = 0.

Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS

2021-08-05 Thread Andrew Gallatin
On 8/5/21 1:41 PM, Ian Lepore wrote:   if (nbufs != ktls_max_alloc) { Finding a different way to spell "forever" is not a valid way to fix a problem where you're being warned that it is not safe to sleep forever. The assert was warning you that the code was vulnerable to hanging forever du

Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS

2021-08-05 Thread Ian Lepore
On Thu, 2021-08-05 at 17:10 +, Andrew Gallatin wrote: > The branch main has been updated by gallatin: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2694c869ff9ff60fd8e3d4d7936b7dc61763c18a > > commit 2694c869ff9ff60fd8e3d4d7936b7dc61763c18a > Author: Andrew Gallatin > AuthorDate: 20

Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS

2021-08-05 Thread Ed Maste
On Thu, 5 Aug 2021 at 13:10, Andrew Gallatin wrote: > > The branch main has been updated by gallatin: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2694c869ff9ff60fd8e3d4d7936b7dc61763c18a > > commit 2694c869ff9ff60fd8e3d4d7936b7dc61763c18a > Author: Andrew Gallatin > AuthorDate: 2021-0

git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS

2021-08-05 Thread Andrew Gallatin
The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=2694c869ff9ff60fd8e3d4d7936b7dc61763c18a commit 2694c869ff9ff60fd8e3d4d7936b7dc61763c18a Author: Andrew Gallatin AuthorDate: 2021-08-05 17:05:00 + Commit: Andrew Gallatin CommitDate: 2021-08-