Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-28 Thread Peter Jeremy
On 2021-Nov-28 20:43:39 -0500, Yoshihiro Ota wrote: >I wonder creating /etc/rc.d/nfsswap that depends on nfsclient can give a >smoother shutdown like swaplate depends on mountlate. /etc/rc.d/swaplate already attempts a swapoff but the check in swapoff_one() is sufficiently rubbery that the check

Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-28 Thread Yoshihiro Ota
Hi, I wonder creating /etc/rc.d/nfsswap that depends on nfsclient can give a smoother shutdown like swaplate depends on mountlate. Hiro On Sun, 28 Nov 2021 04:00:56 +0200 Konstantin Belousov wrote: > On Sun, Nov 28, 2021 at 12:22:46PM +1100, Peter Jeremy wrote: > > On 2021-Nov-27 01:26:17 +02

Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-27 Thread Peter Jeremy
On 2021-Nov-28 04:00:56 +0200, Konstantin Belousov wrote: >On Sun, Nov 28, 2021 at 12:22:46PM +1100, Peter Jeremy wrote: >> On 2021-Nov-27 01:26:17 +0200, Konstantin Belousov >> wrote: >The cause for your panic is not the network interface down state (in fact, >I think that interface state up),

Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-27 Thread Konstantin Belousov
On Sun, Nov 28, 2021 at 12:22:46PM +1100, Peter Jeremy wrote: > On 2021-Nov-27 01:26:17 +0200, Konstantin Belousov > wrote: > >commit 9c62295373f728459c19138f5aa03d9cb8422554 > >Author: Konstantin Belousov > >Date: Sat Nov 27 01:22:27 2021 +0200 > > > >swapoff_one(): only check free pages

Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-27 Thread Peter Jeremy
On 2021-Nov-27 01:26:17 +0200, Konstantin Belousov wrote: >commit 9c62295373f728459c19138f5aa03d9cb8422554 >Author: Konstantin Belousov >Date: Sat Nov 27 01:22:27 2021 +0200 > >swapoff_one(): only check free pages count manually turning swap off That didn't work but I don't think the under

Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-26 Thread Konstantin Belousov
On Fri, Nov 26, 2021 at 09:53:03PM +1100, Peter Jeremy wrote: > On 2021-Nov-25 19:35:10 +, Konstantin Belousov wrote: > >swap_pager: lock vnode in swapdev_strategy() > > > >VOP_STRATEGY() requires locked vnode. Note that we lock the swap vnode > >while pages are busy, but this

Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy()

2021-11-26 Thread Peter Jeremy
On 2021-Nov-25 19:35:10 +, Konstantin Belousov wrote: >swap_pager: lock vnode in swapdev_strategy() > >VOP_STRATEGY() requires locked vnode. Note that we lock the swap vnode >while pages are busy, but this would only cause real LoR if pages belong >to the swap vnode, which