[GitHub] incubator-zeppelin pull request: Clone a note

2015-08-18 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132184238 LGTM! Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: ZEPPELIN 228 - Add unit tests for...

2015-08-24 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/250 ZEPPELIN 228 - Add unit tests for angular controllers You can merge this pull request into a Git repository by running: $ git pull https://github.com/r-kamath/incubator-zeppelin

[GitHub] incubator-zeppelin pull request: Fix NotebookList Ordering

2015-08-24 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/245#issuecomment-134364975 Is there a way to avoid calling sort from the template. How about sorting it as soon as we receive `NOTES_INFO` ? --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...

2015-08-26 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/261 ZEPPELIN-181 Provide more Feedback on UI when Clicking the Cancel/Stop Button of a Pending/Running Paragraph On branch ZEPPELIN-181 Changes to be committed: modified

[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...

2015-08-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-135654070 @corneadoug @felixcheung thanks for the feedback. trying to make some changes in the server side to have CANCELING status. will post my updates here

[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...

2015-08-31 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-136307043 @corneadoug let me know if the update is good. Currently the new status `CANCELING` is used only for `cancelParagraph` server call and in the UI

[GitHub] incubator-zeppelin pull request: Rename and improve existing zeppe...

2015-09-09 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/289#issuecomment-139127028 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-10 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/292 ZEPPELIN-294 Enable karma code coverage plugin https://cloud.githubusercontent.com/assets/2031306/9782316/e27a2d8c-57b9-11e5-9c13-c9ff212c7bc0.png";> You can merge this pull

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139183078 @corneadoug Thanks for the comment. Updated in 5316b61 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...

2015-09-11 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-139471003 will reopen when the patch is ready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...

2015-09-11 Thread r-kamath
Github user r-kamath closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-13 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139978374 http://stackoverflow.com/a/26635182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-306 - Fix Notebook Actio...

2015-09-22 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/314#issuecomment-142472787 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-29 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-144015973 @corneadoug let me know if I have missed anything here --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-299 Support clearing out...

2015-10-26 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/372 ZEPPELIN-299 Support clearing output for paragraph add an option to clear output/result for paragraph on UI and necessary backend changes https://cloud.githubusercontent.com

[GitHub] incubator-zeppelin pull request: ZEPPELIN-299 Support clearing out...

2015-10-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/372#issuecomment-151397841 @corneadoug cleaned up the unused param in a311fce > How would this affect running paragraphs? clear output button is disabled when a paragr

[GitHub] incubator-zeppelin pull request: ZEPPELIN-299 Support clearing out...

2015-10-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/372#issuecomment-151495442 Not sure what's the right way. Disable the link or show another confirm box ? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: ZEPPELIN-299 Support clearing out...

2015-10-28 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/372#issuecomment-151749451 @corneadoug :+1: for hiding the option. > (Hide in Notebook if anything is running, Hide in paragraph if that paragraph is running or queued)

[GitHub] incubator-zeppelin pull request: [Zeppelin-239] The elapsed time i...

2015-11-05 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/325#issuecomment-154006771 @cloverhearts please close and reopen this PR to trigger a new CI build. thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-385 Read-only mode for z...

2015-11-05 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/389#issuecomment-154282387 @babokim Thanks for the update. Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-388: auto nav to new not...

2015-11-06 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/394#issuecomment-154417725 @MikeTYChen I think the `broadcastNote` method in NotebookServer.java isn't sending the new notebook object to the current socket. May be we need to f

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-09 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/414 ZEPPELIN-387 Allow enable/disable of specific paragraphs - When "run all" is called the disabled paragraphs are not executed. - There is no "run" button for

[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...

2015-11-09 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/415 ZEPPELIN-52 Long statements in paragraph and going beneath the control bar before https://issues.apache.org/jira/secure/attachment/12726406/Screen%20Shot%202015-04-18%20at

[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...

2015-11-09 Thread r-kamath
Github user r-kamath closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...

2015-11-09 Thread r-kamath
GitHub user r-kamath reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/415 ZEPPELIN-52 Long statements in paragraph and going beneath the control bar before https://issues.apache.org/jira/secure/attachment/12726406/Screen%20Shot%202015-04-18%20at

[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...

2015-11-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155382830 @prabhjyotsingh tested on Firefox and IE :tada: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155385289 Hi @corneadoug, That sounds like a right spot for the enable/disable menu item. Updated in 87aa4e8. Please take a look at the new screenshots. Thanks

[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...

2015-11-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155420038 @Leemoonsoo Thanks for the document. >...without adding more empty spaces inside of Paragraph... makes sense. working on a better solut

[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...

2015-11-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155457111 @Leemoonsoo how about we hide the control bar and show it on mouseover event of the paragraph --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...

2015-11-11 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155704705 >what do you think make it aware contents length of 1st line and hide (or make it almost transparent) control only when there're text underneath, a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-15 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156930130 @Leemoonsoo @corneadoug @jongyoul updates from 3a7175a https://cloud.githubusercontent.com/assets/2031306/11175456/6b5e88dc-8c58-11e5-99ff

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-157418759 @corneadoug fixed the z.run() case in bdf703d --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-426 - Allowing new parag...

2015-11-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/440#issuecomment-157420527 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-423 Exclude DEPENDENCIES...

2015-11-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/434#issuecomment-157451614 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

2015-11-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/426#issuecomment-157452053 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...

2015-11-17 Thread r-kamath
Github user r-kamath closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-447: removing of redunda...

2015-11-19 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/449#issuecomment-158306521 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-20 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158579034 @corneadoug @Leemoonsoo build issues are fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

2015-11-23 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159150182 :+1: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...

2015-11-23 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/467 Add basic documentation for Markdown You can merge this pull request into a Git repository by running: $ git pull https://github.com/r-kamath/incubator-zeppelin markdownDocUpdate

[GitHub] incubator-zeppelin pull request: Add more unit tests for notebook ...

2015-11-24 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/470 Add more unit tests for notebook controller You can merge this pull request into a Git repository by running: $ git pull https://github.com/r-kamath/incubator-zeppelin

[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...

2015-11-24 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/467#issuecomment-159509640 @felixcheung thanks for the suggestion. I've included the markdown4j link in d839992 --- If your project is set up for it, you can reply to this emai

[GitHub] incubator-zeppelin pull request: ZEPPELIN-463: UI freezes if table...

2015-11-25 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/472#issuecomment-159612911 @prabhjyotsingh is there a way to tweak Perfect Scrollbar to make it work on large dataset ? --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-461] fix typos in geode...

2015-11-25 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/471#issuecomment-159811414 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [Minor] Possible to make a hang w...

2015-11-25 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/466#issuecomment-159811505 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Cleanup redundant css units and u...

2015-11-25 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/476 Cleanup redundant css units and use shorthand property for background You can merge this pull request into a Git repository by running: $ git pull https://github.com/r-kamath

[GitHub] incubator-zeppelin pull request: Fix paragraph actions dropdown st...

2015-11-26 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/478 Fix paragraph actions dropdown styling for Firefox Before on Firefox https://cloud.githubusercontent.com/assets/2031306/11418764/ff5f1bc6-9448-11e5-9eb6-cf0f6f79be2e.png

[GitHub] incubator-zeppelin pull request: Add animation for dropdown menu

2015-11-26 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/479 Add animation for dropdown menu You can merge this pull request into a Git repository by running: $ git pull https://github.com/r-kamath/incubator-zeppelin animateMenu

[GitHub] incubator-zeppelin pull request: Fix 'create' -> 'cancel' -> 'crea...

2015-11-26 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/473#issuecomment-159868995 tested on local. works fine. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS

2015-11-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160080960 tested. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: ZEPPELIN-467 Fix ace editor focus...

2015-11-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/482#issuecomment-160082731 :+1: LGTM. works well on Chrome and Firefox --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: Add more unit tests for notebook ...

2015-11-30 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/470#issuecomment-160670161 @corneadoug those logs are caused by the function calls from tests. Will see if there is a way to ignore the console logs from karma config (similar to

[GitHub] incubator-zeppelin pull request: [WIP] Replace standard alert and ...

2015-12-01 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/501 [WIP] Replace standard alert and confirm with BootstrapDialog Before https://cloud.githubusercontent.com/assets/2031306/11523424/303e835a-98e8-11e5-9f97-c4618b2905ee.png

[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup

2015-12-03 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/511 Cron UI fix and css cleanup - add spacing between links in presets - remove inline css and fix alignment Before https://cloud.githubusercontent.com/assets/2031306

[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161568060 @corneadoug currently it is 2px. will update to 5px --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161568503 @corneadoug 87c21cd https://cloud.githubusercontent.com/assets/2031306/11556938/ce510db4-99cf-11e5-8f55-e15704f9e4cb.png";> --- If your projec

[GitHub] incubator-zeppelin pull request: Don't set Dirty state if text is ...

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/505#issuecomment-161570344 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-480 Enter/return key on ...

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/509#issuecomment-161571362 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Add animation for dropdown menu

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/479#issuecomment-161573209 @corneadoug my idea was to have some animation instead of `display:block`. 0.2s sounds good to me. 55f9969 --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/500#issuecomment-161577146 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Replace standard alert and confir...

2015-12-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/501#issuecomment-161613487 I was waiting for CI to pass. Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: Edit title fix for Notebook and P...

2015-12-03 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/512 Edit title fix for Notebook and Paragraph - enable autofocus to input field *(no need to click twice to edit title)* - fix esc key handler on edit input to revert the change *(edit

[GitHub] incubator-zeppelin pull request: Edit title fix for Notebook and P...

2015-12-04 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/512#issuecomment-162040934 @prabhjyotsingh adding transition requires too many other changes. Planning to do it in a different ticket/PR --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-484] A small utility to...

2015-12-04 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162049203 @Leemoonsoo I do `curl https://patch-diff.githubusercontent.com/raw/apache/incubator-zeppelin/pull/.patch | git apply` in master, review it and reset

[GitHub] incubator-zeppelin pull request: Replace standard alert and confir...

2015-12-05 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/501#issuecomment-162218643 @corneadoug we can remove the title box if necessary. Even in the standard alert/confirm there is nothing in the title box. IMHO the standard ones are not

[GitHub] incubator-zeppelin pull request: Add more unit tests for notebook ...

2015-12-07 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/470#issuecomment-162448468 @corneadoug `captureConsole` isn't working for me too. Two options I can think of are, 1) Let the tests print the log messages on console 2) R

[GitHub] incubator-zeppelin pull request: Add more unit tests for notebook ...

2015-12-07 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/470#issuecomment-162451893 re-defining`console.log = function() {}` in main.js works! We can use this till we get `captureConsole: false` working. Thank you --- If your project

[GitHub] incubator-zeppelin pull request: Edit title fix for Notebook and P...

2015-12-07 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/512#issuecomment-162518422 @corneadoug fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Hot Fix - ZEPPELIN-492

2015-12-08 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/521#issuecomment-162851284 @corneadoug LGTM. Thanks for finding this issue. Will re-work on #479 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...

2015-12-09 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/525 Interpreter properties editor updates - Add extra validations in add new interpreter property function to prevent 'undefined' - Instead of an empty table show a me

[GitHub] incubator-zeppelin pull request: Add/pr teamplate

2015-12-09 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163163806 @corneadoug can you also add PR status in readme ? `[![Issue Stats](http://issuestats.com/github/apache/incubator-zeppelin/badge/pr)](http

[GitHub] incubator-zeppelin pull request: Add/pr teamplate

2015-12-09 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163164018 :+1: for bookmarklet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: Add/pr teamplate

2015-12-09 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163167311 @corneadoug similar to build status this badge is useful for checking the pr status --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: Edit title fix for Notebook and P...

2015-12-09 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/512#issuecomment-163179592 @corneadoug try merging master on #324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [WIP] fix bootstrap dialog defaul...

2015-12-14 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/532 [WIP] fix bootstrap dialog default button ### What is this PR for? Fix default focus issue on bootstrap alert/confirm box ### What type of PR is it? Improvement

[GitHub] incubator-zeppelin pull request: Replace standard alert and confir...

2015-12-14 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/501#issuecomment-164659614 > Neither the cancel nor the OK button has focus on them. Would be nice to have either one pre-focussed. @gauravkumar37 thanks for the feedback. I

[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...

2015-12-14 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-164673854 @corneadoug thanks for the review. Removed the table header style and other changes in de75e49 --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...

2015-12-15 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/535#issuecomment-164823355 :+1: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Fix edit note name bug

2015-12-15 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/539 Fix edit note name bug ### What is this PR for? hide and show of the editor is not functioning properly ### What type of PR is it? Bug fix ### Is there a

[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...

2015-12-15 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-165015122 @corneadoug border-top looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Add firebug and firepath for debu...

2015-12-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/490#issuecomment-165386214 @prabhjyotsingh please rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Option to restart interpreter fro...

2015-12-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-165386267 @prabhjyotsingh rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: Fix typo / grammar from rest-note...

2015-12-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/545#issuecomment-165421322 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...

2015-12-20 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166117118 @cloverhearts Thanks for the fix. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: update error message and output s...

2015-12-30 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/583 update error message and output style ### What is this PR for? Styling text and error output ### What type of PR is it? Improvement ### How should this be

[GitHub] incubator-zeppelin pull request: update error message and output s...

2016-01-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/583#issuecomment-168601911 @Leemoonsoo @corneadoug cool. Thanks for the feedback --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: update error message and output s...

2016-01-03 Thread r-kamath
Github user r-kamath closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-565 ZEPPELIN-564 Paragra...

2016-01-06 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/606 ZEPPELIN-565 ZEPPELIN-564 Paragraph UI bugs ### What is this PR for? Bug fix paragraph UI ### What type of PR is it? Bug Fix ### Is there a relevant Jira issue

[GitHub] incubator-zeppelin pull request: ZEPPELIN-593 Test Paragraph actio...

2016-01-10 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/619 ZEPPELIN-593 Test Paragraph action Disable run and refactor common methods ### What is this PR for? Add new selenium test for disable paragraph action and refactor some of the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-593 Test Paragraph actio...

2016-01-13 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/619#issuecomment-171232018 @bzz I've updated the patch as per the review comment. Thanks --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-zeppelin pull request: Update default notebook generateN...

2016-01-13 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/633 Update default notebook generateName function for create note dialog ### What is this PR for? The current default name for a notebook in create dialog is random, which is difficult

[GitHub] incubator-zeppelin pull request: Update default notebook generateN...

2016-01-15 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/633#issuecomment-171914279 @felixcheung @prabhjyotsingh travis fails for `SPARK_VER="1.4.1" HADOOP_VER="2.3" PROFILE="-Pspark-1.4 -Phadoop-2.3

[GitHub] incubator-zeppelin pull request: ZEPPELIN-593 Test Paragraph actio...

2016-01-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/619#issuecomment-172448650 @bzz @Leemoonsoo ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Update default notebook generateN...

2016-01-18 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/633#issuecomment-172540423 @corneadoug thanks for the detailed review. updates in b6c1f31 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: Add filter to quickly search the ...

2016-01-20 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/660 Add filter to quickly search the notebook from the list ### What is this PR for? Allows the user to instantly find the notebook from the list shown on the home page and in the

[GitHub] incubator-zeppelin pull request: Fix build failure due to latest b...

2016-01-26 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/677 Fix build failure due to latest bower (1.7.5) ### What is this PR for? Build fails due to new bower version 1.7.5. This PR tries to fix this issue by adding the previous version

[GitHub] incubator-zeppelin pull request: [Hot Fix] Fix build failure due t...

2016-01-26 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/677#issuecomment-175465448 Travis build failure is not related to this change https://cloud.githubusercontent.com/assets/2031306/12606910/1cf5d024-c4f7-11e5-99d9-0bcc6d3569f7.png

[GitHub] incubator-zeppelin pull request: Add filter to quickly search the ...

2016-01-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/660#issuecomment-175597946 @corneadoug thanks for the comments. please take a look at updates --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Add filter to quickly search the ...

2016-02-02 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/660#issuecomment-179029777 @corneadoug padding fixed in ed41d41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: Propagate maven -DskipTests optio...

2016-02-03 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/682#issuecomment-179099186 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

  1   2   >