[GitHub] incubator-zeppelin pull request: untracked files configuration.

2015-08-23 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/248#issuecomment-134048578 Good catch, thank you, looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: untracked files configuration.

2015-08-24 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/248#issuecomment-134471923 Any reason to close without merging? Also, I guess the history have been re-wrintte as the reviewed code have disappeared from this PR https

[GitHub] incubator-zeppelin pull request: ZEPPELIN-160 Working with provide...

2015-08-25 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/244#issuecomment-134503417 Quick question: > This patch makes Zeppelin binary independent from spark version. Once Zeppelin is been built, SPARK_HOME can point any version of sp

[GitHub] incubator-zeppelin pull request: ZEPPELIN-219: Paragaph mode auto-...

2015-08-26 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/206#issuecomment-135284755 @corneadoug not sure but think that to be able to see it in "create new PR" ui you need to make sure that the branch you are using is actually de

[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...

2015-08-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135623563 @janzhongi we might need to also rebase it on latest master before merging --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...

2015-08-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135623920 It would be very cool to have at least some kind of readme doc at https://github.com/apache/incubator-zeppelin/tree/gh-pages/docs/interpreter on what is Kylin

[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...

2015-08-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135642779 True! Looks good to me then. Looking forward for some docs --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: Zeppelin interpreter documentatio...

2015-08-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/256#issuecomment-135643911 Thank you very much for the contribution! For the REST API doc - I wish we could use swagger... --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: Zeppelin interpreter documentatio...

2015-08-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/256#issuecomment-136224311 @Leemoonsoo thank you for pointing out the history! Looks great to me. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Update documentation: Set informa...

2015-08-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/265#issuecomment-136234485 Does anybody know what is the reason for such a restriction on maven version? It would be good to have it in description here\JIRA issue. --- If your project

[GitHub] incubator-zeppelin pull request: Update documentation: Set informa...

2015-08-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/265#issuecomment-136240841 Mailing list mentions `maven 3.1.0` regarding to some compatibility issues with [eirslett/frontend-maven-plugin](https://github.com/eirslett/frontend-maven

[GitHub] incubator-zeppelin pull request: Update documentation: Set informa...

2015-08-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/265#issuecomment-136242085 Guys, how do you think, will it worth to investigate further to find the reason? this is quite important as it affects everybody who builds the project --- If

[GitHub] incubator-zeppelin pull request: Update documentation: Set informa...

2015-08-31 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/265#issuecomment-136542427 That is what I meant - if we want to make a statement like this, we better test before and know the reason why it is like that. --- If your project is set up

[GitHub] incubator-zeppelin pull request: ZEPPELIN-160 Working with provide...

2015-09-01 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/244#issuecomment-136617604 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-zeppelin pull request: Hbase Interpreter

2015-09-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/55#issuecomment-137296797 Yes it does (and looks like [CI is failing](https://travis-ci.org/apache/incubator-zeppelin/builds/78497074)), but somehow I do not see Travis feedback for this

[GitHub] incubator-zeppelin pull request: Update documentation: Set informa...

2015-09-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/265#issuecomment-137321948 As far as I know, the only requirment on min maven version comes from eirslett/frontend-maven-plugin#229 and is enforced here [frontend-maven-plugin/pom.xml#L15

[GitHub] incubator-zeppelin pull request: Enforcing maven version < 3.1.0

2015-09-02 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/275 Enforcing maven version < 3.1.0 As per eirslett/frontend-maven-plugin#229 zeppelin-web build requires maven version above 3.1.0 This PR enforces it though maven [prerequisi

[GitHub] incubator-zeppelin pull request: ZEPPELIN-273 Spark 1.5 support

2015-09-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/269#issuecomment-137324580 Looks great to me :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: Enforcing maven version >= 3.1.0

2015-09-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/275#issuecomment-137326980 @ejono thank you! The reason for current restriction on mvn version in Zeppelin is discussed in #265. Spark project must have it's own reaso

[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-137373722 Thank you for great contribution! Can you please also provide the documentation for new interpreter (needs to be in a separate PR to gh-pages branch

[GitHub] incubator-zeppelin pull request: ZEPPELIN-262 Use spark-submit to ...

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/270#issuecomment-137376098 This is awesome improvement, thank you @Leemoonsoo Looks great to me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-137605638 Most probably you also want to update ` conf/zeppelin-site.xml.template` property `zeppelin.interpreters` with name of the new interpreter class --- If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: Enforcing maven version >= 3.1.0

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/275#issuecomment-137611813 To trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Enforcing maven version >= 3.1.0

2015-09-03 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/275 Enforcing maven version >= 3.1.0 As per eirslett/frontend-maven-plugin#229 zeppelin-web build requires maven version above 3.1.0 This PR enforces it though maven [prerequisi

[GitHub] incubator-zeppelin pull request: Enforcing maven version >= 3.1.0

2015-09-03 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-137622263 From CI, seems like Selenium tests hang ``` No output has been received in the last 10 minutes, this potentially indicates a stalled build or something

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-137622429 Something strange going on with TravisCI: ``` WARNING: We were unable to find a .travis.yml file. This may not be what you want. Build will be

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-137622615 Same again, it complains on `.travis.yml`, which is clearly present in the codebase... Going to wait and then trigger once again --- If your project is set up

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-03 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-76 skip Selenium tests o...

2015-09-03 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/280 ZEPPELIN-76 skip Selenium tests on package Selenium-based tests are now triggerd by scalatest, instead of maven-failsafe-plugin, that is why they were triggered on `mvn package

[GitHub] incubator-zeppelin pull request: ZEPPELIN-76 skip Selenium tests o...

2015-09-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/280#issuecomment-137667231 Ready to merge. #81 can be merged right after --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [Doc] Update installation instruc...

2015-09-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/81#issuecomment-137667393 Ready to merge, after #280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: Fix zeppelin-server security test...

2015-09-04 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/281 Fix zeppelin-server security tests on case-sensitive hostname On os x, w/ case-sensitive hostname some test for zeppelin-server were failing ``` $hostname MacBookPro.local

[GitHub] incubator-zeppelin pull request: Zeppelin interpreter documentatio...

2015-09-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/271#issuecomment-137867310 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-279: move website w/ doc...

2015-09-04 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/282 ZEPPELIN-279: move website w/ docs to master branch Deatilas at the [ZEPPELIN-279](https://issues.apache.org/jira/browse/ZEPPELIN-279) You can merge this pull request into a Git repository

[GitHub] incubator-zeppelin pull request: ZEPPELIN-279: cleanup gh-pages br...

2015-09-04 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/283 ZEPPELIN-279: cleanup gh-pages branch after move to master Details at the [ZEPPELIN-279](https://issues.apache.org/jira/browse/ZEPPELIN-279) You can merge this pull request into a Git

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-137878460 Giving it one more chance... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-04 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-04 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-137878442 CI is *very unstable* - same command over the same branch passes on my machine ``` mvn package -Pspark-1.1 -Phadoop-2.3 -B -pl 'zep

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-137891154 On CI `mvn package -Pspark-1.1 -Phadoop-2.3 -Ppyspark -B -pl 'zeppelin-interpreter,spark-dependencies,

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-05 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-05 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-283] IllegalArgumentExc...

2015-09-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/284#issuecomment-138148712 Good catch, thank you for fixing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/279#issuecomment-138149747 `mvn package -Pspark-1.1 -Phadoop-2.3 -B -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server' '-Dtest=org.apache.zeppelin.rest.*Test&#

[GitHub] incubator-zeppelin pull request: adds test for the create, Update ...

2015-09-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138153634 Are you sure that things like 754c55e and 4f3c840 a849b4b d1d32b1 are intended to be part of this PR\contribution? --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: ZEPPELIN-276: Fix test failing on...

2015-09-06 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/285 ZEPPELIN-276: Fix test failing on 'mvn clean package' Do so by moving copy dependencies to earlier mvn phase, so they got included in classpath from `interpreter.sh

[GitHub] incubator-zeppelin pull request: adds test for the create, Update ...

2015-09-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138184596 No problem, enthusiastic :+1: for tests! Yes, interactive rebasing might be a good idea or it might be even simpler to re-create this PR from the latest

[GitHub] incubator-zeppelin pull request: Zeppelin - 241: Add REST API Sett...

2015-09-07 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/286#issuecomment-138418139 +1, looks great, thank you for contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [Doc] Update installation instruc...

2015-09-07 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/81#issuecomment-138419289 Closing this one, will take care of doc update in different PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: [Doc] Update installation instruc...

2015-09-07 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Lowering to ping timeout to have ...

2015-09-07 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/272#issuecomment-138419747 Sounds good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Adding leaflet and data validator...

2015-09-07 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/238#issuecomment-138420058 @Madhuka can you please rebase it on\merge in a latest master? \cc @corneadoug for the review --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: Adding Map and data Validator wit...

2015-09-07 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/231#issuecomment-138420213 @Madhuka what is the status? Shall we close this one in favor of #238 ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-08 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138760753 Shall we rebase it on latest master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-08 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138790015 `This branch has conflicts that must be resolved` signifies that it is not aligned with the latest master, you need to make sure both checks are green here

[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn

2015-09-11 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139701580 Great contribution, thank you! Could you explain a bit what's it for and how user will benefit from it? Also, all new interpreter PRs should in

[GitHub] incubator-zeppelin pull request: [Website] adding DOAP file for pr...

2015-09-11 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/300 [Website] adding DOAP file for projects.apache.org This PR adds a hand-crafted description of Zeppelin project in RDF to be listed at [projects.apache.org](https://projects.apache.org

[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn

2015-09-12 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139782977 @leonardofoderaro thank you for prompt response and do not worry, please take your time! Also it's good practice to put issue number in the name of t

[GitHub] incubator-zeppelin pull request: ZEPPELIN-303

2015-09-13 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/301#issuecomment-139929570 Thank you for addressing this issue! Nit: It would simplify the reviewers life if there is a short description in PR title (emails become meaningful

[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-296 add flink docs

2015-09-13 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/303 [WIP] ZEPPELIN-296 add flink docs [ZEPPELIN-296](https://issues.apache.org/jira/browse/ZEPPELIN-296) initial documentation for Apache Flink interpreter While we are at it, there

[GitHub] incubator-zeppelin pull request: ZEPPELIN-303 Zeppelin should exit...

2015-09-14 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/301#issuecomment-139982564 Thank you @jongyoul , looks great to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [Website] adding DOAP file for pr...

2015-09-14 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/300#issuecomment-139983208 Ready to be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Add dockerfile (and makefile) to ...

2015-09-14 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/175#issuecomment-139987266 Sorry for by late reply, having a default Docker image for Zeppelin is a great idea, couple of things though: - I think that `MAINTAINER` field should

[GitHub] incubator-zeppelin pull request: Line chart with focus

2015-09-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/312#issuecomment-141337226 Thank you for contribution! Shall #310 be closed then? A bit on description as well as a screenshot for GUI changes is a big help for reviewer

[GitHub] incubator-zeppelin pull request: Paragraph CSS to its own file

2015-09-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/311#issuecomment-141337360 @corneadoug may be you could add [WIP] in the title? This will help reviewers to focus better, only on ready PRs. --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: [Website] adding DOAP file for pr...

2015-09-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/300#issuecomment-141337423 Merging if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-296 add flink docs

2015-09-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/303#issuecomment-141338149 @chiwanpark @felixcheung - thank you for reviews! The feedback has been addressed in 364010c --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: ZEPPELIN-296 add flink docs

2015-09-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/303#issuecomment-141339543 Ready to be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-141852973 @randerzander thank you for bringing it to our attention! So, it looks like selenium in-browser Integration Tests of Zeppelin Server submodule are

[GitHub] incubator-zeppelin pull request: ZEPPELIN-303 Zeppelin should exit...

2015-09-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/301#issuecomment-141860887 Merging if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-296 add flink docs

2015-09-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/303#issuecomment-141861737 @chiwanpark thank you! addressed in 8a2f909 squashed Flink commits ready to be merged --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: Make forceY([0]) optional for lin...

2015-09-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/310#issuecomment-141862125 I think we should be good closing this one, as it is part as #312 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: Line chart with focus

2015-09-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/312#issuecomment-141862138 @catap thank you for clean explanation! \cc @corneadoug for a review --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: MapR 4 Profile corrected, Added A...

2015-09-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/110#issuecomment-142476921 +1 for splitting. @WalterDalton which part are you interested in particular? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Tajo jdbc thrift interpreters

2015-09-25 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/73#issuecomment-143169281 Shall we update or close this one, after #39 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-324: Zeppelin-web builds...

2015-09-26 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/327#issuecomment-143515518 Looks good to me. Although it's still better to have a description, rather then title, explaining the problem --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: ZEPPELIN-335: Apache Pig interpre...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/338#issuecomment-145813137 Yes, tests and update for the [docs](http://zeppelin.incubator.apache.org/docs/development/howtocontributewebsite.html) will be great to see as part of this PR

[GitHub] incubator-zeppelin pull request: Add Shift+Enter description to to...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/337#issuecomment-145816117 Good catch! Looks great to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145816809 For this PR to be merged faster, it should include only your commits, related to the described work. Are you sure 0cfa463 is one of them? --- If your

[GitHub] incubator-zeppelin pull request: [Zeppelin-239] The elapsed time i...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/325#issuecomment-145818547 CI is failing on this PR. Usually having it green (or at least updating on why is it red) fosters the reviewers to review\accept changes much faster

[GitHub] incubator-zeppelin pull request: ZEPPELIN-289: User can now enter ...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/320#issuecomment-145819977 Looks interesting, thank you for contributing! Please help me to understand, am I right that these changes potentially affect all interpreter's s

[GitHub] incubator-zeppelin pull request: ZEPPELIN-349: Resolve NPE on null...

2015-10-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/348#issuecomment-148914200 Looks great to me. Thank you @tzolov and :+1: for a nice test! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: ZEPPELIN-345 Duplicate "Ctri + n"...

2015-10-17 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/346#issuecomment-148914355 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-zeppelin pull request: Format table and fix flink to fli...

2015-10-18 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/350#issuecomment-149101340 Thank you so much for catching this. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-361 Move licese of subco...

2015-10-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/365#issuecomment-151710799 Looks great to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-357] Add support for a ...

2015-10-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/368#issuecomment-151712066 Looks great to me! @felixcheung shall we reflect `zeppelin.dep.additionalRemoteRepository` somewhere in the docs? --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: Add dockerfile (and makefile) to ...

2015-11-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/175#issuecomment-153590401 Thank your addressing all the feedback @sjeandeaux ! It looks great but I have one more question, sorry if I missed that one before. As @jersub mention

[GitHub] incubator-zeppelin pull request: ZEPPELIN-386 provide links to ind...

2015-11-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/387#issuecomment-153590702 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-406 Handle license issue...

2015-11-08 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/407#issuecomment-154893887 Tested and looks good to me. The only thing though (not sure if that is relevant) is that somehow a downloads page for me is missing the content of the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-404 Certain project depe...

2015-11-08 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/404#issuecomment-154894521 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

2015-11-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158706111 Shall not we have an error handling in case if .note.json -> note.json fails? I.e next time when zeppelin starts and have .note.json it could recover privi

  1   2   3   4   5   >