Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217450451
@onkarshedge it's perfectly fine, you did very well and thank you for
taking a stab!
Shall we continue with original plan of submitting a PR to
https://
Github user onkarshedge commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217352893
Ohh, I get it. I was adding new NotebookRepos in zeppelin-site.xml this
way. So I was getting only one Notebookrepo and wrote the code in PR to combine
t
Github user onkarshedge closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217091429
@onkarshedge I believe you can add test(s) in this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user onkarshedge commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217082413
@bzz so shall I send another pull request with the test case in
ZeppelinConfigurationTest.java or in this PR itself ?
---
If your project is set up for
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217056217
Hi @onkarshedge thank you for submitting a fix!
In case of fixing a bug in any code, first thing to do is to try adding
some kind of (unit-)test to the e
GitHub user onkarshedge opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/873
Zeppelin configuration getStringValue() returns multiple values commaâ¦
### What is this PR for?
ZeppelinConfiguration getStringValue(String name,String d) returns only a
single
