Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136595120
I have more feedbacks/changes, especially to match @djoelz comments.
So I will do a PR on your branch :)
---
If your project is set up for it, you can
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136593446
@Leemoonsoo : Ready for Merge
@bzz, @corneadoug This contain notification services
---
If your project is set up for it, you can reply to this email and
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136569467
@corneadoug
Hover is fixed for less transparent and Error Notifications have removed so
PR only contain notification services.
Default message
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136568386
@djoelz Current Zeppelin doesn't have facility to show error messages or
system failures for the users on web user interface. So the notification
service wil
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136546770
console = web browser dev tools console.
What I mean is that those message are visual feedback, they wouldn't be
enough for debug.
But copy pasting
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136544298
@corneadoug think of a case where the user does not have access to the
console. Think Zeppelin hosted as a website. Then users might run into issues
that they
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136541499
@djoelz this could be useful.
But I guess this type of error is only as a visual signal that something
went wrong and message would be pretty short, yo
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136521271
also what if I want to copy the error? If I click it disappears. Maybe a
close X or something and the text is selectable?
---
If your project is set up for i
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136307533
@corneadoug Thanks for the feedback I will update PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-136287425
Just tested it out a bit.
I'm not a big fan of the hover effect on the error (it gets a bit
transparent)
I also think the message time should
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-135935396
zeppelin Notifications are designed to inform users about status of
zeppelin.
(All Notifications messages should give informative feedback.)
1.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-135905228
looks good... what is the guideline on when to show this notification?
---
If your project is set up for it, you can reply to this email and have your
re
GitHub user Madhuka opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/263
ZEPPELIN-269 : Adding Error Msg and Notifications feature
### Adding Error Messages and Notifications feature
- [x] Notifications feature added
- [x] UI-Notifications componen
13 matches
Mail list logo
