[GitHub] incubator-zeppelin pull request: ZEPPELIN 228 - Add unit tests for...

2015-09-05 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/250#issuecomment-138047071 Happy to see people writing tests after it is been fixed. @r-kamath : How is the test coverage for controllers? It is good to have plugging for grunt

[GitHub] incubator-zeppelin pull request: adds test for the create, Update ...

2015-09-05 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138046469 Fixed and ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-05 Thread bzz
Github user bzz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-zeppelin pull request: ZEPPELIN-278 fix build warnings a...

2015-09-05 Thread bzz
GitHub user bzz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/279 ZEPPELIN-278 fix build warnings and rat hang `mvn apache-rat:check` passes All sub-modules now use same version of: - maven-dependency-plugin - scala compiler You can me

[GitHub] incubator-zeppelin pull request: ZEPPELIN-279: move website w/ doc...

2015-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-279: move website w/ doc...

2015-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Re: [DISCUSS] moving website with documentation from gh-pages to master branch

2015-09-05 Thread Alexander Bezzubov
Guys, thank you for your support! ZEPPELIN-279 was created to track the progress Alex. On Sat, Sep 5, 2015 at 7:56 AM, Felix Cheung wrote: > +1 > > > > > > On Thu, Sep 3, 2015 at 1:04 PM -0700, "Christian Tzolov" < > ctzo...@pivotal.io> wrote: > +1 > >

[GitHub] incubator-zeppelin pull request: ZEPPELIN 228 - Add unit tests for...

2015-09-05 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/250#issuecomment-137924782 Thanks, Overall looks good. It's a good starting point --- If your project is set up for it, you can reply to this email and have your reply appear on