Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1400269014
Can someone do a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Reamer commented on PR #4532:
URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400278340
@huage1994
I think we can proceed with this change. Please rebase your branch to the
current master.
--
This is an automated message from the Apache Git Service.
To respond to the m
jongyoul merged PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa
huage1994 commented on PR #4532:
URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400410386
> @huage1994 I think we can proceed with this change. Please rebase your
branch to the current master.
Thanks @Reamer for reminding! đź‘Ť
--
This is an automated message from
zjffdu commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1402059634
@halfvector @zenozeng @PrabhuJoseph @vineethNaroju I have updated this PR
and CI is passed now. Feel free to try it to see whether it solves your
problems.
--
This is an automated mes
jongyoul commented on PR #805:
URL: https://github.com/apache/zeppelin/pull/805#issuecomment-1403144355
@ustas4 Thank you for the feedback. BTW, could you please make an issue and
share it with user@, dev@, or slack channel? I would be helpful for others to
understand the problem.
--
Thi
Reamer commented on code in PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#discussion_r1086434414
##
.github/workflows/core.yml:
##
@@ -277,10 +277,10 @@ jobs:
auto-activate-base: false
use-mamba: true
- name: run tests for flink before
zjffdu commented on code in PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#discussion_r1086503324
##
.github/workflows/core.yml:
##
@@ -277,10 +277,10 @@ jobs:
auto-activate-base: false
use-mamba: true
- name: run tests for flink before
Reamer commented on PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#issuecomment-1404800082
I need a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jongyoul commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087820276
##
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##
@@ -242,18 +233,22 @@ public void progres
jongyoul commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087820276
##
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##
@@ -242,18 +233,22 @@ public void progres
Reamer commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087924889
##
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##
@@ -242,18 +233,22 @@ public void progress(
Reamer commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1410210938
I think we can merge this change and move forward with #4558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zjffdu merged PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
jongyoul merged PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa
Reamer opened a new pull request, #4559:
URL: https://github.com/apache/zeppelin/pull/4559
### What is this PR for?
This pull request migrates the JUnit 4 tests to Junit 5 tests.
### What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apach
dependabot[bot] opened a new pull request, #4560:
URL: https://github.com/apache/zeppelin/pull/4560
Bumps
[http-cache-semantics](https://github.com/kornelski/http-cache-semantics) to
4.1.1 and updates ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These depende
zjffdu opened a new pull request, #4561:
URL: https://github.com/apache/zeppelin/pull/4561
### What is this PR for?
Recently CI is failed due to sqlalchemy api change. This PR enforce the
sqlalchemy version to make the CI pass.
### What type of PR is it?
Hot Fix
zjffdu commented on PR #4561:
URL: https://github.com/apache/zeppelin/pull/4561#issuecomment-1416721203
CI is passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
zjffdu merged PR #4561:
URL: https://github.com/apache/zeppelin/pull/4561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
jongyoul merged PR #4543:
URL: https://github.com/apache/zeppelin/pull/4543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa
zjffdu commented on PR #4558:
URL: https://github.com/apache/zeppelin/pull/4558#issuecomment-1418377416
CI is passed, will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jongyoul merged PR #4558:
URL: https://github.com/apache/zeppelin/pull/4558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa
dependabot[bot] commented on PR #4496:
URL: https://github.com/apache/zeppelin/pull/4496#issuecomment-1418588323
Looks like these dependencies are no longer a dependency, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dependabot[bot] closed pull request #4496: Bump flink.hadoop.version from 2.7.7
to 3.1.1.7.2.15.0-147 in /flink/flink-scala-parent
URL: https://github.com/apache/zeppelin/pull/4496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Reamer opened a new pull request, #4562:
URL: https://github.com/apache/zeppelin/pull/4562
### What is this PR for?
This PR implements the sharing of credentials between users and groups.
Due to additional information in the credential file, the structure has been
changed. There is
qinbo12 opened a new pull request, #4563:
URL: https://github.com/apache/zeppelin/pull/4563
This pull request migrates solve the concurrency problem caused by multiple
concurrent calls to note clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dependabot[bot] opened a new pull request, #4564:
URL: https://github.com/apache/zeppelin/pull/4564
Removes [cacheable-request](https://github.com/jaredwray/cacheable-request).
It's no longer used after updating ancestor dependency
[ng-packagr](https://github.com/ng-packagr/ng-packagr). The
canhtran commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1427370649
I'm rebuilding from source for flink 1.16.0 but there aren't any `Flink
interpreter` after the build. There is only `flink-cmd interpreter`. Please let
me know if there is anything that
zjffdu commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1427386135
@canhtran How did you build Zeppelin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
canhtran commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1428335587
@zjffdu Hi Zeff, thanks for the reply
I followed the link here
https://zeppelin.apache.org/docs/latest/setup/basics/how_to_build.html.
1. Clone the latest source of zeppelin
2.
ottok92 opened a new pull request, #4565:
URL: https://github.com/apache/zeppelin/pull/4565
### What is this PR for?
https://issues.apache.org/jira/browse/ZEPPELIN-5352
Changes made to add support for Flink in k8s mode were not reflected in the
interpreter documentation.
###
zjffdu commented on PR #4565:
URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1429642372
Thanks for the contribution, BTW, have you even tried run flink on k8s in
Zeppelin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cometta commented on PR #4388:
URL: https://github.com/apache/zeppelin/pull/4388#issuecomment-1430827058
will the official release of zeppelin with 3.3 support available soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ottok92 commented on PR #4565:
URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1431234117
@zjffdu not yet but I will try it over the next couple of days and let you
know if I find any issue 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the m
canhtran commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432832112
It seems like the issue starting from #4558
I built the zeppelin at commit `f30ea77accc921db3f06aadd5675f71140bc6da2`
and it's fine
https://user-images.githubusercontent.com/3
zjffdu commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432962218
Thanks @canhtran for the feedback,
https://github.com/apache/zeppelin/pull/4558 indeed cause this issue. The
workaround is using `mvn clean package -DskipTests -Pflink-113`
--
This is
zjffdu opened a new pull request, #4566:
URL: https://github.com/apache/zeppelin/pull/4566
### What is this PR for?
A trivial PR to use flink-113 as default profile, so that user don't need to
specify profile to build flink-interpreter modules. Otherwise the following
command won't b
jongyoul commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433126434
Long time no see. I think you'd better rebase this branch, not mering
current master :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
proceane commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433197598
oh...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
zjffdu merged PR #4566:
URL: https://github.com/apache/zeppelin/pull/4566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
ottok92 commented on PR #4565:
URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1435643769
@zjffdu it seems this
[zeppelin-server.yaml](https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml)
is particularly setup for Spark.
I tried defining `ZEPPELIN_FLINK
akishichinibu opened a new pull request, #4567:
URL: https://github.com/apache/zeppelin/pull/4567
### What is this PR for?
Zeppelin Interpreter Support Kotlin From 1.3.50 To 1.8.10
### What type of PR is it?
Improvement
### Todos
* [x] - Task
### What is the Jira
akishichinibu opened a new pull request, #4568:
URL: https://github.com/apache/zeppelin/pull/4568
### What is this PR for?
Zeppelin Interpreter Support InfluxDB From 1.7.0 To 2.3.0
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira
tranvanthai opened a new pull request, #4569:
URL: https://github.com/apache/zeppelin/pull/4569
### What is this PR for?
Currently, the path of the test folder in the Java Interpreter module was
wrong. I open this PR to correct it.
### What type of PR is it?
Improvement
Reamer commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1441617178
Please open a JIRA ticket. A stack trace of the error would be good in the
ticket. It would also be good if you use the pull request template.
--
This is an automated message from the A
Reamer commented on PR #4569:
URL: https://github.com/apache/zeppelin/pull/4569#issuecomment-1443236925
The tests run through, but without log output. In my opinion, this can be
omitted at the moment. How do you see it?
```
2023-02-24T08:53:44.5652238Z [INFO]
-
Reamer merged PR #4569:
URL: https://github.com/apache/zeppelin/pull/4569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
kkalyan commented on code in PR #3496:
URL: https://github.com/apache/zeppelin/pull/3496#discussion_r1117828333
##
zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html:
##
@@ -88,8 +88,10 @@
Toggle Dropdown
-CSV
-TSV
+Copy as TSV
+
phongnt opened a new pull request, #4570:
URL: https://github.com/apache/zeppelin/pull/4570
### What is this PR for?
Fixed maven build failed on module `zeppelin-server` with profile `hadoop3`.
### What type of PR is it?
Bug Fix
### Todos
* [ ] Run maven build after fix
Reamer commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1446266520
If no further comments are received, I will merge the PullRequest on
Wednesday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cometta commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1446277819
i able to compile the master branch after your patching, but when i start
python notebook example, run below cell
```
%python.ipython
import sys
sys?
```
i get below
phongnt commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447567707
@cometta I think Maven command in Dockerfile is not official for distribute
docker image.
I tried to start Zeppelin in docker by `docker run -p 8080:8080 --rm --name
zeppelin apache/z
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##
influxdb/pom.xml:
##
@@ -35,8 +35,8 @@
influxdb
UTF-8
-1.7.0
-3.13.1
+2.3.0
+4.7.2
Review Comment:
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##
influxdb/pom.xml:
##
@@ -35,8 +35,8 @@
influxdb
UTF-8
-1.7.0
-3.13.1
+2.3.0
+4.7.2
Review Comment:
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##
influxdb/pom.xml:
##
@@ -35,8 +35,8 @@
influxdb
UTF-8
-1.7.0
-3.13.1
+2.3.0
+4.7.2
Review Comment:
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##
influxdb/pom.xml:
##
@@ -35,8 +35,8 @@
influxdb
UTF-8
-1.7.0
-3.13.1
+2.3.0
+4.7.2
Review Comment:
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##
influxdb/pom.xml:
##
@@ -35,8 +35,8 @@
influxdb
UTF-8
-1.7.0
-3.13.1
+2.3.0
+4.7.2
Review Comment:
cometta commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447899439
@phongnt , sorry you confused with number of questions i asked. for this
issue, only happen in master branch of the repo, not older version of Zeppelin.
To see this issue, you need to r
phongnt commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447926387
@cometta Base on your error message, I think your Python Interpreter have
problem as your installed Python package on your server (k8s). Could you please
share your Python Interpreter se
cometta commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1448202540
i use the master branch to build the docker image. below is python
interpreter setting, it is the default one
 to 1.2.8 and
updates ancestor dependencies
[minimist](https://github.com/minimistjs/minimist),
[mkdirp](https://github.com/isaacs/nod
qinbo12 commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1449392398
> Please open a JIRA ticket. A stack trace of the error would be good in the
ticket. It would also be good if you use the pull request template.
Hello, I have JIRA sheet and provid
akishichinibu commented on PR #4567:
URL: https://github.com/apache/zeppelin/pull/4567#issuecomment-1449427666
Hi @dkaznacheev,
I’m trying to upgrade the Kotlin version to 1.8.10 in the Kotlin
interpreter, but I found that there’s a great change in the compiler API since
1.4. Could you
cometta commented on PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1449479976
i retest again, the python error no longer occurs after i clear the browser
cache. issue resolved. just take note that to use spark 3.3, on pom.xml ,
change the line 3.3.2 when using
Reamer commented on PR #4559:
URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449891496
> I just have a very small question about this: I noticed that you removed
the `public` modifier from the `@Test` method but retain the `public` modifier
for methods that are decorated by
Reamer merged PR #4570:
URL: https://github.com/apache/zeppelin/pull/4570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
bigjar commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451139614
Hi, @zjffdu. when I use flink.udf.jars, I found two problems. One is it can
not find the org.apache.zeppelin.shaded.com.google.common.io.Files, because the
#4545 had change the shaded pr
canhtran commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451248958
I'm also facing the below issue while testing the zeppelin with flink 1.16.
I guess we need to modify/copy the libraries in flink to resolve it but haven't
figured it out.
```
PrabhuJoseph commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451314800
> I'm also facing the below issue while testing the zeppelin with flink
1.16. I guess we need to modify/copy the libraries in flink to resolve it but
haven't figured it out.
canhtran commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451342014
Thanks @PrabhuJoseph. It works by copying the `flink-sql-client-1.16.jar` to
`lib` folder. The documentation missed this step, I will raise a PR for it.
Thanks again
--
This is an au
canhtran opened a new pull request, #4572:
URL: https://github.com/apache/zeppelin/pull/4572
### What is this PR for?
Update the Flink interpreter documentation to adapt with Flink 1.16 and above
### What type of PR is it?
Documentation
### Todos
* [ ] - Task
huage1994 commented on code in PR #4559:
URL: https://github.com/apache/zeppelin/pull/4559#discussion_r1122608228
##
zeppelin-plugins/notebookrepo/s3/pom.xml:
##
@@ -109,15 +131,11 @@
javax.xml.bind
jaxb-api
-
akishichinibu opened a new pull request, #4573:
URL: https://github.com/apache/zeppelin/pull/4573
### What is this PR for?
Zeppelin Interpreter Support SPARQL From 3.12.0 To 3.17.0
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira
akishichinibu commented on code in PR #4573:
URL: https://github.com/apache/zeppelin/pull/4573#discussion_r1127450230
##
sparql/pom.xml:
##
@@ -33,7 +33,7 @@
sparql
-3.12.0
+3.17.0
Review Comment:
The Java 11 is [required since Jena
4](https
Reamer merged PR #4559:
URL: https://github.com/apache/zeppelin/pull/4559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
jongyoul commented on PR #4573:
URL: https://github.com/apache/zeppelin/pull/4573#issuecomment-1458109071
BTW, is it necessary to keep this interpreter? I don't know about the detail
but sometimes I feel like we should think we could maintain this interpreter
continuously or not. WDYT?
--
jongyoul commented on PR #4567:
URL: https://github.com/apache/zeppelin/pull/4567#issuecomment-1459737471
Is it still in progress? I'm asking because it's still draft pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jongyoul commented on PR #4525:
URL: https://github.com/apache/zeppelin/pull/4525#issuecomment-1459740582
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
michaelSaid closed pull request #4574: feat [INC-58754] Incorta notebook base
imp
URL: https://github.com/apache/zeppelin/pull/4574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Reamer merged PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
dependabot[bot] opened a new pull request, #4575:
URL: https://github.com/apache/zeppelin/pull/4575
Bumps [jettison](https://github.com/jettison-json/jettison) from 1.5.2 to
1.5.4.
Release notes
Sourced from https://github.com/jettison-json/jettison/releases";>jettison's
releases.
huage1994 merged PR #4575:
URL: https://github.com/apache/zeppelin/pull/4575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.ap
dependabot[bot] opened a new pull request, #4576:
URL: https://github.com/apache/zeppelin/pull/4576
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.6.1
to 2.12.7.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits";>compare view
zjffdu closed pull request #4577: #1 [READ. ME]
URL: https://github.com/apache/zeppelin/pull/4577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
NicolasGong opened a new pull request, #4578:
URL: https://github.com/apache/zeppelin/pull/4578
### What is this PR for?
Method contains useless variables
### What type of PR is it?
Improvement
### What is the Jira issue?
* [ZEPPELIN-5891]
--
This is an auto
xiaomin0322 opened a new pull request, #4579:
URL: https://github.com/apache/zeppelin/pull/4579
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/c
Reamer commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1494169052
Very strange, we want to clone the metadata. How does the code work without
a source NoteId?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
NicolasGong commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1495285576
> Very strange, we want to clone the metadata. How does the code work
without a source NoteId?
I think this method is to put the new NoteId and AuthenticationInfo into the
cac
Reamer commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1495667645
I think we can delete the `cloneNoteMeta` method completely and replace it
with `createNoteAuth`.
In my opinion, the original rights should not be transferred from the old
Note to
NicolasGong commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1498391860
I agree with you and resubmitted the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Reamer commented on PR #4579:
URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1498753398
Open a Jira ticket and get your PullRequest into shape. The source code is
also indented incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the mess
Reamer commented on code in PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#discussion_r1159526125
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java:
##
@@ -93,12 +93,7 @@ public void createNoteAuth(String noteId, Authentication
Reamer merged PR #4576:
URL: https://github.com/apache/zeppelin/pull/4576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach
Reamer opened a new pull request, #4580:
URL: https://github.com/apache/zeppelin/pull/4580
### What is this PR for?
This PR removes the use of Powermock in further tests.
### What type of PR is it?
- Refactoring
### What is the Jira issue?
* https://issues.apache.or
NicolasGong commented on code in PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#discussion_r1160369614
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java:
##
@@ -93,12 +93,7 @@ public void createNoteAuth(String noteId, Authentic
xiaomin0322 commented on PR #4579:
URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1501041328
I have updated the jira link, the address is:
https://issues.apache.org/jira/browse/ZEPPELIN-5893, please attention
--
This is an automated message from the Apache Git Service.
To
Reamer commented on PR #4580:
URL: https://github.com/apache/zeppelin/pull/4580#issuecomment-1501121841
I need a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
NicolasGong commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1501294629
Some checks were not successful,but i don't know why. These errors do not
appear to be related to this commit。
--
This is an automated message from the Apache Git Service.
To respo
1 - 100 of 394 matches
Mail list logo
